# git rev-parse -q --verify f41c880e164dc3c9fc3eff6ed27e97583af41986^{commit}
f41c880e164dc3c9fc3eff6ed27e97583af41986
already have revision, skipping fetch
# git checkout -q -f -B kisskb f41c880e164dc3c9fc3eff6ed27e97583af41986
# git clean -qxdf
# < git log -1
# commit f41c880e164dc3c9fc3eff6ed27e97583af41986
# Author: Nicholas Piggin <npiggin@gmail.com>
# Date:   Mon Jun 3 16:05:31 2019 +1000
# 
#     powerpc/64s: Fix THP PMD collapse serialisation
#     
#     Commit 1b2443a547f9 ("powerpc/book3s64: Avoid multiple endian
#     conversion in pte helpers") changed the actual bitwise tests in
#     pte_access_permitted by using pte_write() and pte_present() helpers
#     rather than raw bitwise testing _PAGE_WRITE and _PAGE_PRESENT bits.
#     
#     The pte_present change now returns true for ptes which are
#     !_PAGE_PRESENT and _PAGE_INVALID, which is the combination used by
#     pmdp_invalidate to synchronize access from lock-free lookups.
#     pte_access_permitted is used by pmd_access_permitted, so allowing GUP
#     lock free access to proceed with such PTEs breaks this
#     synchronisation.
#     
#     This bug has been observed on HPT host, with random crashes and
#     corruption in guests, usually together with bad PMD messages in the
#     host.
#     
#     Fix this by adding an explicit check in pmd_access_permitted, and
#     documenting the condition explicitly.
#     
#     The pte_write() change should be okay, and would prevent GUP from
#     falling back to the slow path when encountering savedwrite ptes, which
#     matches what x86 (that does not implement savedwrite) does.
#     
#     Fixes: 1b2443a547f9 ("powerpc/book3s64: Avoid multiple endian conversion in pte helpers")
#     Cc: stable@vger.kernel.org # v4.20+
#     Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
#     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
# < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-gcc --version
# < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-ld --version
# < git log --format=%s --max-count=1 f41c880e164dc3c9fc3eff6ed27e97583af41986
# < make -s -j 48 ARCH=arm64 O=/kisskb/build/powerpc-fixes_arm64-defconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-  defconfig
# make -s -j 48 ARCH=arm64 O=/kisskb/build/powerpc-fixes_arm64-defconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-  
arch/arm64/Makefile:27: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratum
arch/arm64/Makefile:40: LSE atomics not supported by binutils
/kisskb/src/net/ipv4/fib_semantics.c: In function 'fib_check_nh_v4_gw':
/kisskb/src/net/ipv4/fib_semantics.c:1027:12: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (!tbl || err) {
            ^
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c: In function 'sh_mobile_i2c_isr':
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c:399:26: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized]
   pd->msg->buf[real_pos] = data;
                          ^
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c:372:16: note: 'data' was declared here
  unsigned char data;
                ^
In file included from /kisskb/src/include/linux/rwsem.h:16:0,
                 from /kisskb/src/include/linux/notifier.h:15,
                 from /kisskb/src/include/linux/clk.h:17,
                 from /kisskb/src/drivers/tty/serial/sh-sci.c:24:
/kisskb/src/drivers/tty/serial/sh-sci.c: In function 'sci_dma_rx_submit':
/kisskb/src/include/linux/spinlock.h:288:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
   _raw_spin_unlock_irqrestore(lock, flags); \
   ^
/kisskb/src/drivers/tty/serial/sh-sci.c:1353:16: note: 'flags' was declared here
  unsigned long flags;
                ^
warning: same basename if the following are built as modules:
  arch/arm64/lib/crc32.ko
  lib/crc32.ko
Completed OK
# rm -rf /kisskb/build/powerpc-fixes_arm64-defconfig_arm64-gcc5.4
# Build took: 0:03:54.533001