Buildresult: linus/arm64-defconfig/arm64-gcc5 built on Jun 4 2019, 07:43
kisskb
Revisions
|
Branches
|
Compilers
|
Configs
|
Build Results
|
Build Failures
|
Status:
OK
Date/Time:
Jun 4 2019, 07:43
Duration:
0:01:35.293309
Builder:
ka4
Revision:
rcu: locking and unlocking need to always be at least barriers (
66be4e66a7f422128748e3c3ef6ee72b20a6197b)
Target:
linus/arm64-defconfig/arm64-gcc5
Branch:
linus
Compiler:
arm64-gcc5
(aarch64-linux-gcc.br_real (Buildroot 2016.11-git-00613-ge98b4dd) 5.4.0 / GNU ld (GNU Binutils) 2.25.1)
Config:
defconfig
(
download
)
Log:
Download original
Possible warnings (3)
net/ipv4/fib_semantics.c:1023:12: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/i2c/busses/i2c-sh_mobile.c:399:26: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized] include/linux/spinlock.h:288:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
Full Log
# git rev-parse -q --verify 66be4e66a7f422128748e3c3ef6ee72b20a6197b^{commit} 66be4e66a7f422128748e3c3ef6ee72b20a6197b already have revision, skipping fetch # git checkout -q -f -B kisskb 66be4e66a7f422128748e3c3ef6ee72b20a6197b # git clean -qxdf # < git log -1 # commit 66be4e66a7f422128748e3c3ef6ee72b20a6197b # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Mon Jun 3 13:26:20 2019 -0700 # # rcu: locking and unlocking need to always be at least barriers # # Herbert Xu pointed out that commit bb73c52bad36 ("rcu: Don't disable # preemption for Tiny and Tree RCU readers") was incorrect in making the # preempt_disable/enable() be conditional on CONFIG_PREEMPT_COUNT. # # If CONFIG_PREEMPT_COUNT isn't enabled, the preemption enable/disable is # a no-op, but still is a compiler barrier. # # And RCU locking still _needs_ that compiler barrier. # # It is simply fundamentally not true that RCU locking would be a complete # no-op: we still need to guarantee (for example) that things that can # trap and cause preemption cannot migrate into the RCU locked region. # # The way we do that is by making it a barrier. # # See for example commit 386afc91144b ("spinlocks and preemption points # need to be at least compiler barriers") from back in 2013 that had # similar issues with spinlocks that become no-ops on UP: they must still # constrain the compiler from moving other operations into the critical # region. # # Now, it is true that a lot of RCU operations already use READ_ONCE() and # WRITE_ONCE() (which in practice likely would never be re-ordered wrt # anything remotely interesting), but it is also true that that is not # globally the case, and that it's not even necessarily always possible # (ie bitfields etc). # # Reported-by: Herbert Xu <herbert@gondor.apana.org.au> # Fixes: bb73c52bad36 ("rcu: Don't disable preemption for Tiny and Tree RCU readers") # Cc: stable@kernel.org # Cc: Boqun Feng <boqun.feng@gmail.com> # Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-gcc --version # < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-ld --version # < git log --format=%s --max-count=1 66be4e66a7f422128748e3c3ef6ee72b20a6197b # < make -s -j 120 ARCH=arm64 O=/kisskb/build/linus_arm64-defconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- defconfig # make -s -j 120 ARCH=arm64 O=/kisskb/build/linus_arm64-defconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- arch/arm64/Makefile:27: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratum arch/arm64/Makefile:40: LSE atomics not supported by binutils /kisskb/src/net/ipv4/fib_semantics.c: In function 'fib_check_nh_v4_gw': /kisskb/src/net/ipv4/fib_semantics.c:1023:12: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] if (!tbl || err) { ^ /kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c: In function 'sh_mobile_i2c_isr': /kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c:399:26: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized] pd->msg->buf[real_pos] = data; ^ /kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c:372:16: note: 'data' was declared here unsigned char data; ^ In file included from /kisskb/src/include/linux/rwsem.h:16:0, from /kisskb/src/include/linux/notifier.h:15, from /kisskb/src/include/linux/clk.h:17, from /kisskb/src/drivers/tty/serial/sh-sci.c:24: /kisskb/src/drivers/tty/serial/sh-sci.c: In function 'sci_dma_rx_submit': /kisskb/src/include/linux/spinlock.h:288:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] _raw_spin_unlock_irqrestore(lock, flags); \ ^ /kisskb/src/drivers/tty/serial/sh-sci.c:1353:16: note: 'flags' was declared here unsigned long flags; ^ Completed OK # rm -rf /kisskb/build/linus_arm64-defconfig_arm64-gcc5.4 # Build took: 0:01:35.293309
© Michael Ellerman 2006-2018.