# git rev-parse -q --verify 66be4e66a7f422128748e3c3ef6ee72b20a6197b^{commit} 66be4e66a7f422128748e3c3ef6ee72b20a6197b already have revision, skipping fetch # git checkout -q -f -B kisskb 66be4e66a7f422128748e3c3ef6ee72b20a6197b # git clean -qxdf # < git log -1 # commit 66be4e66a7f422128748e3c3ef6ee72b20a6197b # Author: Linus Torvalds # Date: Mon Jun 3 13:26:20 2019 -0700 # # rcu: locking and unlocking need to always be at least barriers # # Herbert Xu pointed out that commit bb73c52bad36 ("rcu: Don't disable # preemption for Tiny and Tree RCU readers") was incorrect in making the # preempt_disable/enable() be conditional on CONFIG_PREEMPT_COUNT. # # If CONFIG_PREEMPT_COUNT isn't enabled, the preemption enable/disable is # a no-op, but still is a compiler barrier. # # And RCU locking still _needs_ that compiler barrier. # # It is simply fundamentally not true that RCU locking would be a complete # no-op: we still need to guarantee (for example) that things that can # trap and cause preemption cannot migrate into the RCU locked region. # # The way we do that is by making it a barrier. # # See for example commit 386afc91144b ("spinlocks and preemption points # need to be at least compiler barriers") from back in 2013 that had # similar issues with spinlocks that become no-ops on UP: they must still # constrain the compiler from moving other operations into the critical # region. # # Now, it is true that a lot of RCU operations already use READ_ONCE() and # WRITE_ONCE() (which in practice likely would never be re-ordered wrt # anything remotely interesting), but it is also true that that is not # globally the case, and that it's not even necessarily always possible # (ie bitfields etc). # # Reported-by: Herbert Xu # Fixes: bb73c52bad36 ("rcu: Don't disable preemption for Tiny and Tree RCU readers") # Cc: stable@kernel.org # Cc: Boqun Feng # Cc: Paul E. McKenney # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld --version # < git log --format=%s --max-count=1 66be4e66a7f422128748e3c3ef6ee72b20a6197b # < make -s -j 80 ARCH=nds32 O=/kisskb/build/linus_nds32-allmodconfig_nds32le CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- allmodconfig # make -s -j 80 ARCH=nds32 O=/kisskb/build/linus_nds32-allmodconfig_nds32le CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- /kisskb/src/drivers/hwtracing/intel_th/msu.c: In function 'msc_buffer_win_alloc': /kisskb/src/drivers/hwtracing/intel_th/msu.c:783:21: warning: unused variable 'i' [-Wunused-variable] int ret = -ENOMEM, i; ^ /kisskb/src/drivers/hwtracing/intel_th/msu.c: In function 'msc_buffer_win_free': /kisskb/src/drivers/hwtracing/intel_th/msu.c:863:6: warning: unused variable 'i' [-Wunused-variable] int i; ^ /kisskb/src/drivers/input/joystick/analog.c:160:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^~~~~~~ WARNING: EXPORT symbol "clear_page" [vmlinux] version generation failed, symbol will not be versioned. WARNING: EXPORT symbol "copy_page" [vmlinux] version generation failed, symbol will not be versioned. WARNING: "clear_page" [fs/ocfs2/dlm/ocfs2_dlm.ko] has no CRC! WARNING: "clear_page" [fs/ntfs/ntfs.ko] has no CRC! WARNING: "copy_page" [fs/nilfs2/nilfs2.ko] has no CRC! WARNING: "copy_page" [fs/nfs/nfs.ko] has no CRC! WARNING: "clear_page" [fs/gfs2/gfs2.ko] has no CRC! WARNING: "copy_page" [fs/fuse/fuse.ko] has no CRC! WARNING: "clear_page" [fs/fuse/fuse.ko] has no CRC! WARNING: "copy_page" [fs/cachefiles/cachefiles.ko] has no CRC! WARNING: "copy_page" [fs/btrfs/btrfs.ko] has no CRC! WARNING: "clear_page" [fs/btrfs/btrfs.ko] has no CRC! WARNING: "clear_page" [drivers/scsi/sd_mod.ko] has no CRC! WARNING: "clear_page" [drivers/md/raid456.ko] has no CRC! WARNING: "copy_page" [drivers/md/dm-integrity.ko] has no CRC! WARNING: "clear_page" [drivers/md/dm-integrity.ko] has no CRC! WARNING: "copy_page" [drivers/gpu/drm/ttm/ttm.ko] has no CRC! WARNING: "clear_page" [drivers/gpu/drm/ttm/ttm.ko] has no CRC! WARNING: "copy_page" [drivers/block/drbd/drbd.ko] has no CRC! warning: same module names found: drivers/regulator/88pm800.ko drivers/mfd/88pm800.ko warning: same module names found: drivers/gpu/drm/bridge/adv7511/adv7511.ko drivers/media/i2c/adv7511.ko warning: same module names found: drivers/net/phy/asix.ko drivers/net/usb/asix.ko warning: same module names found: fs/coda/coda.ko drivers/media/platform/coda/coda.ko warning: same module names found: drivers/net/phy/realtek.ko drivers/net/dsa/realtek.ko Completed OK # rm -rf /kisskb/build/linus_nds32-allmodconfig_nds32le # Build took: 0:10:28.152877