# git rev-parse -q --verify 84b028243ef07a3f65c1857343ada2b1022f8bed^{commit} 84b028243ef07a3f65c1857343ada2b1022f8bed already have revision, skipping fetch # git checkout -q -f -B kisskb 84b028243ef07a3f65c1857343ada2b1022f8bed # git clean -qxdf # < git log -1 # commit 84b028243ef07a3f65c1857343ada2b1022f8bed # Author: Suraj Jitindar Singh # Date: Mon Jun 17 17:16:19 2019 +1000 # # KVM: PPC: Book3S HV: Only write DAWR[X] when handling h_set_dawr in real mode # # The hcall H_SET_DAWR is used by a guest to set the data address # watchpoint register (DAWR). This hcall is handled in the host in # kvmppc_h_set_dawr() which can be called in either real mode on the # guest exit path from hcall_try_real_mode() in book3s_hv_rmhandlers.S, # or in virtual mode when called from kvmppc_pseries_do_hcall() in # book3s_hv.c. # # The function kvmppc_h_set_dawr() updates the dawr and dawrx fields in # the vcpu struct accordingly and then also writes the respective values # into the DAWR and DAWRX registers directly. It is necessary to write # the registers directly here when calling the function in real mode # since the path to re-enter the guest won't do this. However when in # virtual mode the host DAWR and DAWRX values have already been # restored, and so writing the registers would overwrite these. # Additionally there is no reason to write the guest values here as # these will be read from the vcpu struct and written to the registers # appropriately the next time the vcpu is run. # # This also avoids the case when handling h_set_dawr for a nested guest # where the guest hypervisor isn't able to write the DAWR and DAWRX # registers directly and must rely on the real hypervisor to do this for # it when it calls H_ENTER_NESTED. # # Fixes: c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 option") # Signed-off-by: Suraj Jitindar Singh # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 84b028243ef07a3f65c1857343ada2b1022f8bed # < make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-fixes_52xx_pcm030_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- 52xx/pcm030_defconfig # make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-fixes_52xx_pcm030_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/kernel/futex.c: In function 'do_futex': /kisskb/src/kernel/futex.c:1658:17: warning: 'oldval' may be used uninitialized in this function [-Wmaybe-uninitialized] return oldval == cmparg; ^ /kisskb/src/kernel/futex.c:1633:6: note: 'oldval' was declared here int oldval, ret; ^ INFO: Uncompressed kernel (size 0x48dda0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x500000) Image Name: Linux-5.2.0-rc2trunk+ Created: Wed Jun 19 00:03:32 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2329979 Bytes = 2275.37 KiB = 2.22 MiB Load Address: 00000000 Entry Point: 00000000 Completed OK # rm -rf /kisskb/build/powerpc-fixes_52xx_pcm030_defconfig_powerpc-gcc5 # Build took: 0:00:48.552832