# git rev-parse -q --verify cac803c330638f238288c767c934352776cffc4c^{commit} cac803c330638f238288c767c934352776cffc4c already have revision, skipping fetch # git checkout -q -f -B kisskb cac803c330638f238288c767c934352776cffc4c # git clean -qxdf # < git log -1 # commit cac803c330638f238288c767c934352776cffc4c # Author: Naveen N. Rao # Date: Thu Jun 27 15:29:40 2019 +0530 # # powerpc/xmon: Fix disabling tracing while in xmon # # Commit ed49f7fd6438d ("powerpc/xmon: Disable tracing when entering # xmon") added code to disable recording trace entries while in xmon. The # commit introduced a variable 'tracing_enabled' to record if tracing was # enabled on xmon entry, and used this to conditionally enable tracing # during exit from xmon. # # However, we are not checking the value of 'fromipi' variable in # xmon_core() when setting 'tracing_enabled'. Due to this, when secondary # cpus enter xmon, they will see tracing as being disabled already and # tracing won't be re-enabled on exit. Fix the same. # # Fixes: ed49f7fd6438d ("powerpc/xmon: Disable tracing when entering xmon") # Signed-off-by: Naveen N. Rao # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-ld --version # < git log --format=%s --max-count=1 cac803c330638f238288c767c934352776cffc4c # < make -s -j 48 ARCH=parisc O=/kisskb/build/powerpc-next_parisc-defconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- defconfig # make -s -j 48 ARCH=parisc O=/kisskb/build/powerpc-next_parisc-defconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- In file included from /kisskb/src/arch/parisc/math-emu/fcnvxf.c:51: /kisskb/src/arch/parisc/math-emu/fcnvxf.c: In function 'sgl_to_sgl_fcnvxf': /kisskb/src/arch/parisc/math-emu/cnv_float.h:63:52: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] #define Int_isinexact_to_sgl(int_value) (int_value << 33 - SGL_EXP_LENGTH) ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fcnvxf.c:101:6: note: in expansion of macro 'Int_isinexact_to_sgl' if (Int_isinexact_to_sgl(src)) { ^~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/cnv_float.h:67:21: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] if ((int_value << 34 - SGL_EXP_LENGTH) || Slow(sgl_value)) \ ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fcnvxf.c:112:5: note: in expansion of macro 'Sgl_roundnearest_from_int' Sgl_roundnearest_from_int(src,result); ^~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fcnvxf.c: In function 'dbl_to_sgl_fcnvxf': /kisskb/src/arch/parisc/math-emu/cnv_float.h:71:27: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] ((Dintp1(dint_valueA) << 33 - SGL_EXP_LENGTH) || Dintp2(dint_valueB)) ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fcnvxf.c:257:6: note: in expansion of macro 'Dint_isinexact_to_sgl' if (Dint_isinexact_to_sgl(srcp1,srcp2)) { ^~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/cnv_float.h:75:31: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] if ((Dintp1(dint_valueA) << 34 - SGL_EXP_LENGTH) || \ ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fcnvxf.c:268:5: note: in expansion of macro 'Sgl_roundnearest_from_dint' Sgl_roundnearest_from_dint(srcp1,srcp2,result); ^~~~~~~~~~~~~~~~~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/powerpc-next_parisc-defconfig_parisc # Build took: 0:01:10.534704