# git rev-parse -q --verify cac803c330638f238288c767c934352776cffc4c^{commit} cac803c330638f238288c767c934352776cffc4c already have revision, skipping fetch # git checkout -q -f -B kisskb cac803c330638f238288c767c934352776cffc4c # git clean -qxdf # < git log -1 # commit cac803c330638f238288c767c934352776cffc4c # Author: Naveen N. Rao # Date: Thu Jun 27 15:29:40 2019 +0530 # # powerpc/xmon: Fix disabling tracing while in xmon # # Commit ed49f7fd6438d ("powerpc/xmon: Disable tracing when entering # xmon") added code to disable recording trace entries while in xmon. The # commit introduced a variable 'tracing_enabled' to record if tracing was # enabled on xmon entry, and used this to conditionally enable tracing # during exit from xmon. # # However, we are not checking the value of 'fromipi' variable in # xmon_core() when setting 'tracing_enabled'. Due to this, when secondary # cpus enter xmon, they will see tracing as being disabled already and # tracing won't be re-enabled on exit. Fix the same. # # Fixes: ed49f7fd6438d ("powerpc/xmon: Disable tracing when entering xmon") # Signed-off-by: Naveen N. Rao # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 cac803c330638f238288c767c934352776cffc4c # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig KCONFIG_SEED=0xB7097F9D # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # yes \n | make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- oldconfig yes: standard output: Broken pipe # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/mm/book3s64/radix_tlb.c:670: warning: "radix__flush_all_mm" redefined #define radix__flush_all_mm radix__local_flush_all_mm In file included from /kisskb/src/arch/powerpc/include/asm/book3s/64/radix.h:18, from /kisskb/src/arch/powerpc/include/asm/book3s/64/pgtable.h:299, from /kisskb/src/arch/powerpc/include/asm/book3s/64/mmu-hash.h:24, from /kisskb/src/arch/powerpc/include/asm/book3s/64/mmu.h:46, from /kisskb/src/arch/powerpc/include/asm/mmu.h:356, from /kisskb/src/arch/powerpc/include/asm/lppaca.h:36, from /kisskb/src/arch/powerpc/include/asm/paca.h:21, from /kisskb/src/arch/powerpc/include/asm/current.h:16, from /kisskb/src/include/linux/thread_info.h:21, from /kisskb/src/include/asm-generic/preempt.h:5, from ./arch/powerpc/include/generated/asm/preempt.h:1, from /kisskb/src/include/linux/preempt.h:78, from /kisskb/src/include/linux/spinlock.h:51, from /kisskb/src/include/linux/mmzone.h:8, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/mm.h:10, from /kisskb/src/arch/powerpc/mm/book3s64/radix_tlb.c:12: /kisskb/src/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h:68: note: this is the location of the previous definition #define radix__flush_all_mm(mm) radix__local_flush_all_mm(mm) /kisskb/src/arch/powerpc/mm/book3s64/radix_tlb.c: In function '__radix__flush_tlb_range': /kisskb/src/arch/powerpc/mm/book3s64/radix_tlb.c:713:5: error: implicit declaration of function 'exit_flush_lazy_tlbs'; did you mean 'enter_lazy_tlb'? [-Werror=implicit-function-declaration] exit_flush_lazy_tlbs(mm); ^~~~~~~~~~~~~~~~~~~~ enter_lazy_tlb /kisskb/src/arch/powerpc/mm/book3s64/radix_tlb.c: In function 'radix__tlb_flush': /kisskb/src/arch/powerpc/mm/book3s64/radix_tlb.c:883:3: error: implicit declaration of function '__flush_all_mm'; did you mean 'flush_all_mm'? [-Werror=implicit-function-declaration] __flush_all_mm(mm, true); ^~~~~~~~~~~~~~ flush_all_mm cc1: some warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:279: arch/powerpc/mm/book3s64/radix_tlb.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:489: arch/powerpc/mm/book3s64] Error 2 make[3]: *** Waiting for unfinished jobs.... /kisskb/src/kernel/locking/lockdep.c:2821:13: warning: 'print_lock_trace' defined but not used [-Wunused-function] static void print_lock_trace(struct lock_trace *trace, unsigned int spaces) ^~~~~~~~~~~~~~~~ make[2]: *** [/kisskb/src/scripts/Makefile.build:489: arch/powerpc/mm] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1071: arch/powerpc] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:179: sub-make] Error 2 Command 'make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc8 # Build took: 0:01:43.172407