# git rev-parse -q --verify b0b9f351fd616a01eea7c8d44e798db5a122a005^{commit} b0b9f351fd616a01eea7c8d44e798db5a122a005 already have revision, skipping fetch # git checkout -q -f -B kisskb b0b9f351fd616a01eea7c8d44e798db5a122a005 # git clean -qxdf # < git log -1 # commit b0b9f351fd616a01eea7c8d44e798db5a122a005 # Author: Masahiro Yamada # Date: Fri Jul 5 19:01:44 2019 +0900 # # powerpc/boot: pass CONFIG options in a simpler and more robust way # # Commit 5e9dcb6188a4 ("powerpc/boot: Expose Kconfig symbols to wrapper") # was wrong, but commit e41b93a6be57 ("powerpc/boot: Fix build failures # with -j 1") was also wrong. # # The correct dependency is: # # $(obj)/serial.o: $(obj)/autoconf.h # # However, I do not see the reason why we need to copy autoconf.h to # arch/power/boot/. Nor do I see consistency in the way of passing # CONFIG options. # # decompress.c references CONFIG_KERNEL_GZIP and CONFIG_KERNEL_XZ, which # are passed via the command line. # # serial.c includes autoconf.h to reference a couple of CONFIG options, # but this is fragile because we often forget to include "autoconf.h" # from source files. # # In fact, it is already broken. # # ppc_asm.h references CONFIG_PPC_8xx, but utils.S is not given any way # to access CONFIG options. So, CONFIG_PPC_8xx is never defined here. # # Pass $(LINUXINCLUDE) to make sure CONFIG options are accessible from # all .c and .S files in arch/powerpc/boot/. # # I also removed the -traditional flag to make include/linux/kconfig.h # work. This flag makes the preprocessor imitate the behavior of the # pre-standard C compiler, but I do not understand why it is necessary. # # Signed-off-by: Masahiro Yamada # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20190705100144.28785-2-yamada.masahiro@socionext.com # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-ld --version # < git log --format=%s --max-count=1 b0b9f351fd616a01eea7c8d44e798db5a122a005 # < make -s -j 8 ARCH=parisc O=/kisskb/build/powerpc-next_parisc-defconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- defconfig # make -s -j 8 ARCH=parisc O=/kisskb/build/powerpc-next_parisc-defconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- In file included from /kisskb/src/arch/parisc/math-emu/fcnvxf.c:51: /kisskb/src/arch/parisc/math-emu/fcnvxf.c: In function 'sgl_to_sgl_fcnvxf': /kisskb/src/arch/parisc/math-emu/cnv_float.h:63:52: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] #define Int_isinexact_to_sgl(int_value) (int_value << 33 - SGL_EXP_LENGTH) ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fcnvxf.c:101:6: note: in expansion of macro 'Int_isinexact_to_sgl' if (Int_isinexact_to_sgl(src)) { ^~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/cnv_float.h:67:21: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] if ((int_value << 34 - SGL_EXP_LENGTH) || Slow(sgl_value)) \ ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fcnvxf.c:112:5: note: in expansion of macro 'Sgl_roundnearest_from_int' Sgl_roundnearest_from_int(src,result); ^~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fcnvxf.c: In function 'dbl_to_sgl_fcnvxf': /kisskb/src/arch/parisc/math-emu/cnv_float.h:71:27: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] ((Dintp1(dint_valueA) << 33 - SGL_EXP_LENGTH) || Dintp2(dint_valueB)) ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fcnvxf.c:257:6: note: in expansion of macro 'Dint_isinexact_to_sgl' if (Dint_isinexact_to_sgl(srcp1,srcp2)) { ^~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/cnv_float.h:75:31: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context] if ((Dintp1(dint_valueA) << 34 - SGL_EXP_LENGTH) || \ ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fcnvxf.c:268:5: note: in expansion of macro 'Sgl_roundnearest_from_dint' Sgl_roundnearest_from_dint(srcp1,srcp2,result); ^~~~~~~~~~~~~~~~~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/powerpc-next_parisc-defconfig_parisc # Build took: 0:01:37.123390