Buildresult: crypto/x86_64-allnoconfig/x86_64-gcc8 built on Jul 18 2019, 19:40

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Jul 18 2019, 19:40
Duration:	0:00:19.250078
Builder:	ka2
Revision:	padata: use smp_mb in padata_reorder to avoid orphaned padata jobs (`cf144f81a99d1a3928f90b0936accfd3f45c9a0a)`
Target:	crypto/x86_64-allnoconfig/x86_64-gcc8
Branch:	crypto
Compiler:	x86_64-gcc8 (x86_64-linux-gcc (GCC) 8.1.0 / GNU ld (GNU Binutils) 2.30)
Config:	allnoconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify cf144f81a99d1a3928f90b0936accfd3f45c9a0a^{commit} cf144f81a99d1a3928f90b0936accfd3f45c9a0a already have revision, skipping fetch # git checkout -q -f -B kisskb cf144f81a99d1a3928f90b0936accfd3f45c9a0a # git clean -qxdf # < git log -1 # commit cf144f81a99d1a3928f90b0936accfd3f45c9a0a # Author: Daniel Jordan <daniel.m.jordan@oracle.com> # Date: Tue Jul 16 12:32:53 2019 -0400 # # padata: use smp_mb in padata_reorder to avoid orphaned padata jobs # # Testing padata with the tcrypt module on a 5.2 kernel... # # # modprobe tcrypt alg="pcrypt(rfc4106(gcm(aes)))" type=3 # # modprobe tcrypt mode=211 sec=1 # # ...produces this splat: # # INFO: task modprobe:10075 blocked for more than 120 seconds. # Not tainted 5.2.0-base+ #16 # modprobe D 0 10075 10064 0x80004080 # Call Trace: # ? __schedule+0x4dd/0x610 # ? ring_buffer_unlock_commit+0x23/0x100 # schedule+0x6c/0x90 # schedule_timeout+0x3b/0x320 # ? trace_buffer_unlock_commit_regs+0x4f/0x1f0 # wait_for_common+0x160/0x1a0 # ? wake_up_q+0x80/0x80 # { crypto_wait_req } # entries in braces added by hand # { do_one_aead_op } # { test_aead_jiffies } # test_aead_speed.constprop.17+0x681/0xf30 [tcrypt] # do_test+0x4053/0x6a2b [tcrypt] # ? 0xffffffffa00f4000 # tcrypt_mod_init+0x50/0x1000 [tcrypt] # ... # # The second modprobe command never finishes because in padata_reorder, # CPU0's load of reorder_objects is executed before the unlocking store in # spin_unlock_bh(pd->lock), causing CPU0 to miss CPU1's increment: # # CPU0 CPU1 # # padata_reorder padata_do_serial # LOAD reorder_objects // 0 # INC reorder_objects // 1 # padata_reorder # TRYLOCK pd->lock // failed # UNLOCK pd->lock # # CPU0 deletes the timer before returning from padata_reorder and since no # other job is submitted to padata, modprobe waits indefinitely. # # Add a pair of full barriers to guarantee proper ordering: # # CPU0 CPU1 # # padata_reorder padata_do_serial # UNLOCK pd->lock # smp_mb() # LOAD reorder_objects # INC reorder_objects # smp_mb__after_atomic() # padata_reorder # TRYLOCK pd->lock # # smp_mb__after_atomic is needed so the read part of the trylock operation # comes after the INC, as Andrea points out. Thanks also to Andrea for # help with writing a litmus test. # # Fixes: 16295bec6398 ("padata: Generic parallelization/serialization interface") # Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com> # Cc: <stable@vger.kernel.org> # Cc: Andrea Parri <andrea.parri@amarulasolutions.com> # Cc: Boqun Feng <boqun.feng@gmail.com> # Cc: Herbert Xu <herbert@gondor.apana.org.au> # Cc: Paul E. McKenney <paulmck@linux.ibm.com> # Cc: Peter Zijlstra <peterz@infradead.org> # Cc: Steffen Klassert <steffen.klassert@secunet.com> # Cc: linux-arch@vger.kernel.org # Cc: linux-crypto@vger.kernel.org # Cc: linux-kernel@vger.kernel.org # Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 cf144f81a99d1a3928f90b0936accfd3f45c9a0a # < make -s -j 24 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- allnoconfig # make -s -j 24 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- Completed OK # rm -rf /kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc8 # Build took: 0:00:19.250078

© Michael Ellerman 2006-2018.