# git rev-parse -q --verify fde46ba593df92c4d787d2cc35a11f46583c89a6^{commit} fde46ba593df92c4d787d2cc35a11f46583c89a6 already have revision, skipping fetch # git checkout -q -f -B kisskb fde46ba593df92c4d787d2cc35a11f46583c89a6 # git clean -qxdf # < git log -1 # commit fde46ba593df92c4d787d2cc35a11f46583c89a6 # Author: Nathan Chancellor # Date: Mon Jun 3 15:11:58 2019 -0700 # # PCI: rpaphp: Avoid a sometimes-uninitialized warning # # When building with -Wsometimes-uninitialized, clang warns: # # drivers/pci/hotplug/rpaphp_core.c:243:14: warning: variable 'fndit' is # used uninitialized whenever 'for' loop exits because its condition is # false [-Wsometimes-uninitialized] # for (j = 0; j < entries; j++) { # ^~~~~~~~~~~ # drivers/pci/hotplug/rpaphp_core.c:256:6: note: uninitialized use occurs # here # if (fndit) # ^~~~~ # drivers/pci/hotplug/rpaphp_core.c:243:14: note: remove the condition if # it is always true # for (j = 0; j < entries; j++) { # ^~~~~~~~~~~ # drivers/pci/hotplug/rpaphp_core.c:233:14: note: initialize the variable # 'fndit' to silence this warning # int j, fndit; # ^ # = 0 # # fndit is only used to gate a sprintf call, which can be moved into the # loop to simplify the code and eliminate the local variable, which will # fix this warning. # # Fixes: 2fcf3ae508c2 ("hotplug/drc-info: Add code to search ibm,drc-info property") # Suggested-by: Nick Desaulniers # Signed-off-by: Nathan Chancellor # Acked-by: Tyrel Datwyler # Acked-by: Joel Savitz # Signed-off-by: Michael Ellerman # Link: https://github.com/ClangBuiltLinux/linux/issues/504 # Link: https://lore.kernel.org/r/20190603221157.58502-1-natechancellor@gmail.com # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 fde46ba593df92c4d787d2cc35a11f46583c89a6 # < make -s -j 24 ARCH=x86 O=/kisskb/build/powerpc-next_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # yes \n | make -s -j 24 ARCH=x86 O=/kisskb/build/powerpc-next_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- oldconfig yes: standard output: Broken pipe # make -s -j 24 ARCH=x86 O=/kisskb/build/powerpc-next_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- Completed OK # rm -rf /kisskb/build/powerpc-next_x86-allmodconfig_x86_64-gcc8 # Build took: 0:30:00.591164