# git gc # git rev-parse -q --verify 1a288d0d920dfb9747bbefc8d601a971885f470f^{commit} # git fetch -q -n -f git://gitlab.ozlabs.ibm.com/mirror/linux-kbuild.git for-next # git rev-parse -q --verify 1a288d0d920dfb9747bbefc8d601a971885f470f^{commit} 1a288d0d920dfb9747bbefc8d601a971885f470f # git checkout -q -f -B kisskb 1a288d0d920dfb9747bbefc8d601a971885f470f # git clean -qxdf # < git log -1 # commit 1a288d0d920dfb9747bbefc8d601a971885f470f # Author: Denis Efremov # Date: Sun Jul 28 13:09:06 2019 +0300 # # modpost: check for static EXPORT_SYMBOL* functions # # This patch adds a check to warn about static EXPORT_SYMBOL* functions # during the modpost. In most of the cases, a static symbol marked for # exporting is an odd combination that should be fixed either by deleting # the exporting mark or by removing the static attribute and adding the # appropriate declaration to headers. # # This check could help to detect the following problems: # 1. 550113d4e9f5 ("i2c: add newly exported functions to the header, too") # 2. 54638c6eaf44 ("net: phy: make exported variables non-static") # 3. 98ef2046f28b ("mm: remove the exporting of totalram_pages") # 4. 73df167c819e ("s390/zcrypt: remove the exporting of ap_query_configuration") # 5. a57caf8c527f ("sunrpc/cache: remove the exporting of cache_seq_next") # 6. e4e4730698c9 ("crypto: skcipher - remove the exporting of skcipher_walk_next") # 7. 14b4c48bb1ce ("gve: Remove the exporting of gve_probe") # 8. 9b79ee9773a8 ("scsi: libsas: remove the exporting of sas_wait_eh") # 9. ... # # Build time impact, allmodconfig, Dell XPS 15 9570 (measurements 3x): # $ make mrproper; make allmodconfig; time make -j12; \ # git checkout HEAD~1; \ # make mrproper; make allmodconfig; time make -j12 # 1. # (with patch) 17635,94s user 1895,54s system 1085% cpu 29:59,22 total # (w/o patch) 17275,42s user 1803,87s system 1112% cpu 28:35,66 total # 2. # (with patch) 17369,51s user 1763,28s system 1111% cpu 28:41,47 total # (w/o patch) 16880,50s user 1670,93s system 1113% cpu 27:46,56 total # 3. # (with patch) 17937,88s user 1842,53s system 1109% cpu 29:42,26 total # (w/o patch) 17267,55s user 1725,09s system 1111% cpu 28:28,17 total # # Thus, the current implementation adds approx. 1 min for allmodconfig. # # Acked-by: Emil Velikov # Signed-off-by: Denis Efremov # Signed-off-by: Masahiro Yamada # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-ld --version # < git log --format=%s --max-count=1 1a288d0d920dfb9747bbefc8d601a971885f470f # < make -s -j 24 ARCH=arm O=/kisskb/build/kbuild_versatile_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- versatile_defconfig # make -s -j 24 ARCH=arm O=/kisskb/build/kbuild_versatile_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2591:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1852:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:194:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here WARNING: "return_address" [vmlinux] is the static EXPORT_SYMBOL_GPL WARNING: "cpu_arm926_set_pte_ext" [vmlinux] is the static EXPORT_SYMBOL WARNING: "cpu_arm926_dcache_clean_area" [vmlinux] is the static EXPORT_SYMBOL WARNING: "drm_client_close" [vmlinux] is the static EXPORT_SYMBOL WARNING: "arm926_flush_user_cache_range" [vmlinux] is the static EXPORT_SYMBOL WARNING: "arm926_flush_kern_cache_all" [vmlinux] is the static EXPORT_SYMBOL WARNING: "jiffies" [vmlinux] is the static EXPORT_SYMBOL WARNING: "arm926_flush_user_cache_all" [vmlinux] is the static EXPORT_SYMBOL WARNING: "arm926_flush_kern_dcache_area" [vmlinux] is the static EXPORT_SYMBOL WARNING: "arm926_coherent_kern_range" [vmlinux] is the static EXPORT_SYMBOL WARNING: "return_address" [vmlinux] is the static EXPORT_SYMBOL_GPL WARNING: "cpu_arm926_set_pte_ext" [vmlinux] is the static EXPORT_SYMBOL WARNING: "cpu_arm926_dcache_clean_area" [vmlinux] is the static EXPORT_SYMBOL WARNING: "drm_client_close" [vmlinux] is the static EXPORT_SYMBOL WARNING: "arm926_flush_user_cache_range" [vmlinux] is the static EXPORT_SYMBOL WARNING: "arm926_flush_kern_cache_all" [vmlinux] is the static EXPORT_SYMBOL WARNING: "arm926_flush_user_cache_all" [vmlinux] is the static EXPORT_SYMBOL WARNING: "arm926_flush_kern_dcache_area" [vmlinux] is the static EXPORT_SYMBOL WARNING: "arm926_coherent_kern_range" [vmlinux] is the static EXPORT_SYMBOL Completed OK # rm -rf /kisskb/build/kbuild_versatile_defconfig_arm # Build took: 0:04:42.928321