# git rev-parse -q --verify 5faa15883ebc90132b58c685316de2cd24735e90^{commit} 5faa15883ebc90132b58c685316de2cd24735e90 already have revision, skipping fetch # git checkout -q -f -B kisskb 5faa15883ebc90132b58c685316de2cd24735e90 # git clean -qxdf # < git log -1 # commit 5faa15883ebc90132b58c685316de2cd24735e90 # Author: Christopher M. Riedl # Date: Mon Aug 12 22:13:14 2019 -0500 # # powerpc/spinlocks: Fix oops in shared-processor spinlocks # # Booting w/ ppc64le_defconfig + CONFIG_PREEMPT results in the attached # kernel trace due to calling shared-processor spinlocks while not # running in an SPLPAR. Previously, the out-of-line spinlocks # implementations were selected based on CONFIG_PPC_SPLPAR at compile # time without a runtime shared-processor LPAR check. # # To fix, call the actual spinlock implementations from a set of common # functions, spin_yield() and rw_yield(), which check for # shared-processor LPAR during runtime and select the appropriate lock # implementation. # # BUG: Kernel NULL pointer dereference at 0x00000100 # Faulting instruction address: 0xc000000000097f88 # Oops: Kernel access of bad area, sig: 7 [#1] # LE PAGE_SIZE=64K MMU=Radix MMU=Hash PREEMPT SMP NR_CPUS=2048 NUMA PowerNV # Modules linked in: # CPU: 0 PID: 2 Comm: kthreadd Not tainted 5.2.0-rc6-00491-g249155c20f9b #28 # NIP: c000000000097f88 LR: c000000000c07a88 CTR: c00000000015ca10 # REGS: c0000000727079f0 TRAP: 0300 Not tainted (5.2.0-rc6-00491-g249155c20f9b) # MSR: 9000000002009033 CR: 84000424 XER: 20040000 # CFAR: c000000000c07a84 DAR: 0000000000000100 DSISR: 00080000 IRQMASK: 1 # GPR00: c000000000c07a88 c000000072707c80 c000000001546300 c00000007be38a80 # GPR04: c0000000726f0c00 0000000000000002 c00000007279c980 0000000000000100 # GPR08: c000000001581b78 0000000080000001 0000000000000008 c00000007279c9b0 # GPR12: 0000000000000000 c000000001730000 c000000000142558 0000000000000000 # GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 # GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 # GPR24: c00000007be38a80 c000000000c002f4 0000000000000000 0000000000000000 # GPR28: c000000072221a00 c0000000726c2600 c00000007be38a80 c00000007be38a80 # NIP [c000000000097f88] __spin_yield+0x48/0xa0 # LR [c000000000c07a88] __raw_spin_lock+0xb8/0xc0 # Call Trace: # [c000000072707c80] [c000000072221a00] 0xc000000072221a00 (unreliable) # [c000000072707cb0] [c000000000bffb0c] __schedule+0xbc/0x850 # [c000000072707d70] [c000000000c002f4] schedule+0x54/0x130 # [c000000072707da0] [c0000000001427dc] kthreadd+0x28c/0x2b0 # [c000000072707e20] [c00000000000c1cc] ret_from_kernel_thread+0x5c/0x70 # Instruction dump: # 4d9e0020 552a043e 210a07ff 79080fe0 0b080000 3d020004 3908b878 794a1f24 # e8e80000 7ce7502a e8e70000 38e70100 <7ca03c2c> 70a70001 78a50020 4d820020 # ---[ end trace 474d6b2b8fc5cb7e ]--- # # Fixes: 499dcd41378e ("powerpc/64s: Allocate LPPACAs individually") # Signed-off-by: Christopher M. Riedl # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20190813031314.1828-4-cmr@informatik.wtf # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-ld --version # < git log --format=%s --max-count=1 5faa15883ebc90132b58c685316de2cd24735e90 # < make -s -j 48 ARCH=parisc O=/kisskb/build/powerpc-next_parisc-defconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- defconfig # make -s -j 48 ARCH=parisc O=/kisskb/build/powerpc-next_parisc-defconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- /kisskb/src/arch/parisc/math-emu/fpudispatch.c: In function 'decode_0c': /kisskb/src/arch/parisc/math-emu/fpudispatch.c:312:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+2] = fpregs[r1+2]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:313:9: note: here case 1: /* double */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:314:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+1] = fpregs[r1+1]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:315:9: note: here case 0: /* single */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:327:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+2] = fpregs[r1+2]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:328:9: note: here case 1: /* double */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:329:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+1] = fpregs[r1+1]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:330:9: note: here case 0: /* single */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:343:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+2] = fpregs[r1+2]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:344:9: note: here case 1: /* double */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:345:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+1] = fpregs[r1+1]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:346:9: note: here case 0: /* single */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:359:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+2] = fpregs[r1+2]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:360:9: note: here case 1: /* double */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:361:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+1] = fpregs[r1+1]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:362:9: note: here case 0: /* single */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:305:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:319:4: note: here case 3: /* FABS */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:320:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:335:4: note: here case 6: /* FNEG */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:336:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:351:4: note: here case 7: /* FNEGABS */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:352:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:367:4: note: here case 4: /* FSQRT */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:368:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:379:4: note: here case 5: /* FRND */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:410:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:422:4: note: here case 1: /* FCNVXF */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:423:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:437:4: note: here case 2: /* FCNVFX */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:438:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:452:4: note: here case 3: /* FCNVFXT */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:453:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:467:4: note: here case 5: /* FCNVUF (PA2.0 only) */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:468:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:482:4: note: here case 6: /* FCNVFU (PA2.0 only) */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:483:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:497:4: note: here case 7: /* FCNVFUT (PA2.0 only) */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:498:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:512:4: note: here case 4: /* undefined */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:574:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:593:4: note: here case 1: /* FTEST */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:625:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:636:4: note: here case 1: /* FSUB */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:637:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:648:4: note: here case 2: /* FMPY */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:649:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:660:4: note: here case 3: /* FDIV */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:661:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:672:4: note: here case 4: /* FREM */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:300:3: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (subop) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:393:2: note: here case 1: /* class 1 */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:408:3: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (subop) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:516:2: note: here case 2: /* class 2 */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:521:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (fpu_type_flags & PA2_0_FPU_FLAG) { ^ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:614:2: note: here case 3: /* class 3 */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c: In function 'decode_0e': /kisskb/src/arch/parisc/math-emu/fpudispatch.c:738:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+1] = fpregs[r1+1]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:739:9: note: here case 0: /* single */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:749:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+1] = fpregs[r1+1]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:750:9: note: here case 0: /* single */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:760:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+1] = fpregs[r1+1]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:761:9: note: here case 0: /* single */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:771:18: warning: this statement may fall through [-Wimplicit-fallthrough=] fpregs[t+1] = fpregs[r1+1]; ~~~~~~~~~~~~^~~~~~~~~~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:772:9: note: here case 0: /* single */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:733:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:743:4: note: here case 3: /* FABS */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:744:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:754:4: note: here case 6: /* FNEG */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:755:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:765:4: note: here case 7: /* FNEGABS */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:766:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:776:4: note: here case 4: /* FSQRT */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:777:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:788:4: note: here case 5: /* FRMD */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:817:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:829:4: note: here case 1: /* FCNVXF */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:830:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:844:4: note: here case 2: /* FCNVFX */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:845:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:859:4: note: here case 3: /* FCNVFXT */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:860:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:874:4: note: here case 5: /* FCNVUF (PA2.0 only) */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:875:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:889:4: note: here case 6: /* FCNVFU (PA2.0 only) */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:890:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:904:4: note: here case 7: /* FCNVFUT (PA2.0 only) */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:905:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:919:4: note: here case 4: /* undefined */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:1021:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:1029:4: note: here case 1: /* FSUB */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:1030:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:1038:4: note: here case 2: /* FMPY or XMPYU */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:1042:8: warning: this statement may fall through [-Wimplicit-fallthrough=] if (extru(ir,fpxpos,1)) { ^ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:1074:4: note: here case 3: /* FDIV */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:1075:5: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (fmt) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:1083:4: note: here case 4: /* FREM */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:728:3: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (subop) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:802:2: note: here case 1: /* class 1 */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:815:3: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (subop) { ^~~~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:922:2: note: here case 2: /* class 2 */ ^~~~ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:938:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (fpu_type_flags & PA2_0_FPU_FLAG) { ^ /kisskb/src/arch/parisc/math-emu/fpudispatch.c:997:2: note: here case 3: /* class 3 */ ^~~~ /kisskb/src/arch/parisc/mm/fault.c: In function 'parisc_acctyp': /kisskb/src/arch/parisc/mm/fault.c:67:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (bit22set(inst)) ^ /kisskb/src/arch/parisc/mm/fault.c:70:2: note: here case 0x0: /* indexed/memory management */ ^~~~ /kisskb/src/drivers/scsi/ncr53c8xx.c: In function 'ncr_int_sir': /kisskb/src/drivers/scsi/ncr53c8xx.c:6713:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (tp->lp[0]) { ^ /kisskb/src/drivers/scsi/ncr53c8xx.c:6717:2: note: here case SIR_RESEL_BAD_TARGET: /* Will send a TARGET RESET message */ ^~~~ /kisskb/src/drivers/scsi/ncr53c8xx.c: In function 'ncr_prepare_setting': /kisskb/src/drivers/scsi/ncr53c8xx.c:3908:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (np->sv_scntl3) { ^ /kisskb/src/drivers/scsi/ncr53c8xx.c:3913:3: note: here case 3: /* SYMBIOS controllers report HVD through GPIO3 */ ^~~~ /kisskb/src/drivers/scsi/ncr53c8xx.c:3914:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (INB(nc_gpreg) & 0x08) ^ /kisskb/src/drivers/scsi/ncr53c8xx.c:3916:3: note: here case 2: /* Set HVD unconditionally */ ^~~~ /kisskb/src/drivers/scsi/ncr53c8xx.c:3917:18: warning: this statement may fall through [-Wimplicit-fallthrough=] np->scsi_mode = SMODE_HVD; /kisskb/src/drivers/scsi/ncr53c8xx.c:3918:3: note: here case 1: /* Trust previous settings for HVD */ ^~~~ Completed OK # rm -rf /kisskb/build/powerpc-next_parisc-defconfig_parisc # Build took: 0:01:07.506410