# git rev-parse -q --verify 07a9d6cdcca83271b0ba04ec0d333cd9cd352a51^{commit} 07a9d6cdcca83271b0ba04ec0d333cd9cd352a51 already have revision, skipping fetch # git checkout -q -f -B kisskb 07a9d6cdcca83271b0ba04ec0d333cd9cd352a51 # git clean -qxdf # < git log -1 # commit 07a9d6cdcca83271b0ba04ec0d333cd9cd352a51 # Author: Gustavo A. R. Silva # Date: Wed Aug 7 11:42:29 2019 -0500 # # perf/x86/intel/uncore: Use struct_size() in kzalloc_node() # # One of the more common cases of allocation size calculations is finding # the size of a structure that has a zero-sized array at the end, along # with memory for some number of elements for that array. For example: # # struct intel_uncore_box { # ... # struct intel_uncore_extra_reg shared_regs[0]; # }; # # size = sizeof(struct intel_uncore_box) + count * sizeof(struct intel_uncore_extra_reg); # instance = kzalloc_node(size, GFP_KERNEL, node); # # Instead of leaving these open-coded and prone to type mistakes, we can # now use the new struct_size() helper: # # instance = kzalloc_node(struct_size(instance, shared_regs, count), GFP_KERNEL, # node); # # Notice that, in this case, variable size is not necessary, hence it # is removed. # # This code was detected with the help of Coccinelle. # # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 07a9d6cdcca83271b0ba04ec0d333cd9cd352a51 # < make -s -j 8 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # make -s -j 8 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] /kisskb/src/arch/powerpc/kernel/align.c: In function 'emulate_spe': /kisskb/src/arch/powerpc/kernel/align.c:178:8: error: this statement may fall through [-Werror=implicit-fallthrough=] ret |= __get_user_inatomic(temp.v[3], p++); ^~ /kisskb/src/arch/powerpc/kernel/align.c:179:3: note: here case 4: ^~~~ /kisskb/src/arch/powerpc/kernel/align.c:181:8: error: this statement may fall through [-Werror=implicit-fallthrough=] ret |= __get_user_inatomic(temp.v[5], p++); ^~ /kisskb/src/arch/powerpc/kernel/align.c:182:3: note: here case 2: ^~~~ /kisskb/src/arch/powerpc/kernel/align.c:261:8: error: this statement may fall through [-Werror=implicit-fallthrough=] ret |= __put_user_inatomic(data.v[3], p++); ^~ /kisskb/src/arch/powerpc/kernel/align.c:262:3: note: here case 4: ^~~~ /kisskb/src/arch/powerpc/kernel/align.c:264:8: error: this statement may fall through [-Werror=implicit-fallthrough=] ret |= __put_user_inatomic(data.v[5], p++); ^~ /kisskb/src/arch/powerpc/kernel/align.c:265:3: note: here case 2: ^~~~ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:273: arch/powerpc/kernel/align.o] Error 1 make[2]: *** [/kisskb/src/scripts/Makefile.build:490: arch/powerpc/kernel] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1079: arch/powerpc] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:179: sub-make] Error 2 Command 'make -s -j 8 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc8 # Build took: 0:00:35.139972