# git rev-parse -q --verify a8318c13e79badb92bc6640704a64cc022a6eb97^{commit}
a8318c13e79badb92bc6640704a64cc022a6eb97
already have revision, skipping fetch
# git checkout -q -f -B kisskb a8318c13e79badb92bc6640704a64cc022a6eb97
# git clean -qxdf
# < git log -1
# commit a8318c13e79badb92bc6640704a64cc022a6eb97
# Author: Gustavo Romero <gromero@linux.ibm.com>
# Date:   Wed Sep 4 00:55:28 2019 -0400
# 
#     powerpc/tm: Fix restoring FP/VMX facility incorrectly on interrupts
#     
#     When in userspace and MSR FP=0 the hardware FP state is unrelated to
#     the current process. This is extended for transactions where if tbegin
#     is run with FP=0, the hardware checkpoint FP state will also be
#     unrelated to the current process. Due to this, we need to ensure this
#     hardware checkpoint is updated with the correct state before we enable
#     FP for this process.
#     
#     Unfortunately we get this wrong when returning to a process from a
#     hardware interrupt. A process that starts a transaction with FP=0 can
#     take an interrupt. When the kernel returns back to that process, we
#     change to FP=1 but with hardware checkpoint FP state not updated. If
#     this transaction is then rolled back, the FP registers now contain the
#     wrong state.
#     
#     The process looks like this:
#        Userspace:                      Kernel
#     
#                    Start userspace
#                     with MSR FP=0 TM=1
#                       < -----
#        ...
#        tbegin
#        bne
#                    Hardware interrupt
#                        ---- >
#                                         <do_IRQ...>
#                                         ....
#                                         ret_from_except
#                                           restore_math()
#                                             /* sees FP=0 */
#                                             restore_fp()
#                                               tm_active_with_fp()
#                                                 /* sees FP=1 (Incorrect) */
#                                               load_fp_state()
#                                             FP = 0 -> 1
#                       < -----
#                    Return to userspace
#                      with MSR TM=1 FP=1
#                      with junk in the FP TM checkpoint
#        TM rollback
#        reads FP junk
#     
#     When returning from the hardware exception, tm_active_with_fp() is
#     incorrectly making restore_fp() call load_fp_state() which is setting
#     FP=1.
#     
#     The fix is to remove tm_active_with_fp().
#     
#     tm_active_with_fp() is attempting to handle the case where FP state
#     has been changed inside a transaction. In this case the checkpointed
#     and transactional FP state is different and hence we must restore the
#     FP state (ie. we can't do lazy FP restore inside a transaction that's
#     used FP). It's safe to remove tm_active_with_fp() as this case is
#     handled by restore_tm_state(). restore_tm_state() detects if FP has
#     been using inside a transaction and will set load_fp and call
#     restore_math() to ensure the FP state (checkpoint and transaction) is
#     restored.
#     
#     This is a data integrity problem for the current process as the FP
#     registers are corrupted. It's also a security problem as the FP
#     registers from one process may be leaked to another.
#     
#     Similarly for VMX.
#     
#     A simple testcase to replicate this will be posted to
#     tools/testing/selftests/powerpc/tm/tm-poison.c
#     
#     This fixes CVE-2019-15031.
#     
#     Fixes: a7771176b439 ("powerpc: Don't enable FP/Altivec if not checkpointed")
#     Cc: stable@vger.kernel.org # 4.15+
#     Signed-off-by: Gustavo Romero <gromero@linux.ibm.com>
#     Signed-off-by: Michael Neuling <mikey@neuling.org>
#     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
#     Link: https://lore.kernel.org/r/20190904045529.23002-2-gromero@linux.vnet.ibm.com
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version
# < git log --format=%s --max-count=1 a8318c13e79badb92bc6640704a64cc022a6eb97
# < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  mpc885_ads_defconfig
# Added to kconfig CONFIG_HUGETLBFS=y
# yes \n | make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  oldconfig
yes: standard output: Broken pipe
# make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  
/kisskb/src/fs/proc/inode.c: In function 'proc_reg_open':
/kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here
/kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl':
/kisskb/src/kernel/printk/printk.c:194:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page':
/kisskb/src/mm/hugetlb.c:1465:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized]
Image Name:   Linux-5.3.0-rc2-ga8318c13e79b
Created:      Thu Sep  5 00:59:06 2019
Image Type:   PowerPC Linux Kernel Image (gzip compressed)
Data Size:    1864587 Bytes = 1820.89 KiB = 1.78 MiB
Load Address: 00400000
Entry Point:  004001dc
Completed OK
# rm -rf /kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc-gcc4.6
# Build took: 0:00:25.963767