Buildresult: powerpc-next/mgcoge_defconfig/powerpc-gcc5 built on Sep 5 2019, 22:55

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Sep 5 2019, 22:55
Duration:	0:00:55.962582
Builder:	ka1
Revision:	powerpc/64: Fix stacktrace on BE when function_graph is enabled (`35f7eea41dba2cdfb11be7a37eb21cf010fd3220)`
Target:	powerpc-next/mgcoge_defconfig/powerpc-gcc5
Branch:	powerpc-next
Compiler:	powerpc-gcc5 (powerpc64-linux-gcc (GCC) 5.5.0 / GNU ld (GNU Binutils) 2.29.1.20170915)
Config:	mgcoge_defconfig (download)
Log:	Download original Possible warnings (1) arch/powerpc/kernel/head_32.S:934: Warning: invalid register expression Full Log # git rev-parse -q --verify 35f7eea41dba2cdfb11be7a37eb21cf010fd3220^{commit} 35f7eea41dba2cdfb11be7a37eb21cf010fd3220 already have revision, skipping fetch # git checkout -q -f -B kisskb 35f7eea41dba2cdfb11be7a37eb21cf010fd3220 # git clean -qxdf # < git log -1 # commit 35f7eea41dba2cdfb11be7a37eb21cf010fd3220 # Author: Michael Ellerman <mpe@ellerman.id.au> # Date: Fri Aug 23 22:29:01 2019 +1000 # # powerpc/64: Fix stacktrace on BE when function_graph is enabled # # Currently if we oops or warn while function_graph is active the stack # trace looks like: # .trace_graph_return+0xac/0x100 # .ftrace_return_to_handler+0x98/0x140 # .return_to_handler+0x20/0x40 # .return_to_handler+0x0/0x40 # .return_to_handler+0x0/0x40 # .return_to_handler+0x0/0x40 # .return_to_handler+0x0/0x40 # .return_to_handler+0x0/0x40 # .return_to_handler+0x0/0x40 # .cpu_startup_entry+0x34/0x40 # .start_secondary+0x680/0x6f0 # start_secondary_prolog+0x10/0x14 # # Notice the multiple entries that just show .return_to_handler. # # There is logic in show_stack() to detect this case and print the # traced function, but we inadvertently broke it in commit # 7d56c65a6ff9 ("powerpc/ftrace: Remove mod_return_to_handler") (2014), # because that commit accidentally removed the dereference of rth which # gets the text address from the function descriptor. Hence this is only # broken on big endian (or technically ELFv1). # # Fix it by using the proper accessor, which is ppc_function_entry(). # Result is we get a stack trace such as: # # .trace_graph_return+0x134/0x160 # .ftrace_return_to_handler+0x94/0x140 # .return_to_handler+0x20/0x40 # .return_to_handler+0x0/0x40 (.shared_cede_loop+0x48/0x130) # .return_to_handler+0x0/0x40 (.cpuidle_enter_state+0xa0/0x690) # .return_to_handler+0x0/0x40 (.cpuidle_enter+0x44/0x70) # .return_to_handler+0x0/0x40 (.call_cpuidle+0x68/0xc0) # .return_to_handler+0x0/0x40 (.do_idle+0x37c/0x400) # .return_to_handler+0x0/0x40 (.cpu_startup_entry+0x30/0x50) # .rest_init+0x224/0x348 # # Fixes: 7d56c65a6ff9 ("powerpc/ftrace: Remove mod_return_to_handler") # Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> # Reviewed-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> # Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> # Link: https://lore.kernel.org/r/20190823122901.32667-1-mpe@ellerman.id.au # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 35f7eea41dba2cdfb11be7a37eb21cf010fd3220 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_mgcoge_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mgcoge_defconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_mgcoge_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/kernel/head_32.S: Assembler messages: /kisskb/src/arch/powerpc/kernel/head_32.S:934: Warning: invalid register expression Completed OK # rm -rf /kisskb/build/powerpc-next_mgcoge_defconfig_powerpc-gcc5 # Build took: 0:00:55.962582

© Michael Ellerman 2006-2018.