# git rev-parse -q --verify d41a3effbb53b1bcea41e328d16a4d046a508381^{commit}
d41a3effbb53b1bcea41e328d16a4d046a508381
already have revision, skipping fetch
# git checkout -q -f -B kisskb d41a3effbb53b1bcea41e328d16a4d046a508381
# git clean -qxdf
# < git log -1
# commit d41a3effbb53b1bcea41e328d16a4d046a508381
# Author: Hillf Danton <hdanton@sina.com>
# Date:   Mon Sep 2 13:37:29 2019 +0100
# 
#     keys: Fix missing null pointer check in request_key_auth_describe()
#     
#     If a request_key authentication token key gets revoked, there's a window in
#     which request_key_auth_describe() can see it with a NULL payload - but it
#     makes no check for this and something like the following oops may occur:
#     
#             BUG: Kernel NULL pointer dereference at 0x00000038
#             Faulting instruction address: 0xc0000000004ddf30
#             Oops: Kernel access of bad area, sig: 11 [#1]
#             ...
#             NIP [...] request_key_auth_describe+0x90/0xd0
#             LR [...] request_key_auth_describe+0x54/0xd0
#             Call Trace:
#             [...] request_key_auth_describe+0x54/0xd0 (unreliable)
#             [...] proc_keys_show+0x308/0x4c0
#             [...] seq_read+0x3d0/0x540
#             [...] proc_reg_read+0x90/0x110
#             [...] __vfs_read+0x3c/0x70
#             [...] vfs_read+0xb4/0x1b0
#             [...] ksys_read+0x7c/0x130
#             [...] system_call+0x5c/0x70
#     
#     Fix this by checking for a NULL pointer when describing such a key.
#     
#     Also make the read routine check for a NULL pointer to be on the safe side.
#     
#     [DH: Modified to not take already-held rcu lock and modified to also check
#      in the read routine]
#     
#     Fixes: 04c567d9313e ("[PATCH] Keys: Fix race between two instantiators of a key")
#     Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
#     Signed-off-by: Hillf Danton <hdanton@sina.com>
#     Signed-off-by: David Howells <dhowells@redhat.com>
#     Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-gcc --version
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-ld --version
# < git log --format=%s --max-count=1 d41a3effbb53b1bcea41e328d16a4d046a508381
# < make -s -j 32 ARCH=arm O=/kisskb/build/linus_multi_v7_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-  multi_v7_defconfig
# make -s -j 32 ARCH=arm O=/kisskb/build/linus_multi_v7_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-  
/kisskb/src/arch/arm/crypto/Makefile:27: These CRC Extensions modules need binutils 2.23 or higher
/kisskb/src/arch/arm/crypto/Makefile:28:  crc32-arm-ce.o
/kisskb/src/arch/arm/crypto/Makefile:37: These ARMv8 Crypto Extensions modules need binutils 2.23 or higher
/kisskb/src/arch/arm/crypto/Makefile:38:  aes-arm-ce.o sha1-arm-ce.o sha2-arm-ce.o ghash-arm-ce.o
/kisskb/src/crypto/sha512_generic.c: In function 'sha512_transform':
/kisskb/src/crypto/sha512_generic.c:149:1: warning: the frame size of 1184 bytes is larger than 1024 bytes [-Wframe-larger-than=]
/kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl':
/kisskb/src/kernel/printk/printk.c:194:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/sound/hda/hdac_regmap.c: In function 'hda_reg_write':
/kisskb/src/sound/hda/hdac_regmap.c:283:16: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields':
/kisskb/src/kernel/rcu/srcutree.c:140:32: warning: 'levelspread[<U2140>]' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/kernel/rcu/srcutree.c:88:6: note: 'levelspread[<U2140>]' was declared here
/kisskb/src/fs/proc/inode.c: In function 'proc_reg_open':
/kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here
/kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read':
/kisskb/src/drivers/base/regmap/regmap.c:2591:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write':
/kisskb/src/drivers/base/regmap/regmap.c:1852:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/core/devlink.c: In function 'devlink_fmsg_prepare_skb':
/kisskb/src/net/core/devlink.c:4443:6: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon':
/kisskb/src/net/mac80211/mlme.c:1576:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/mac80211/mlme.c:1533:6: note: 'pwr_level_cisco' was declared here
/kisskb/src/drivers/clk/sunxi-ng/ccu_mux.c: In function 'ccu_mux_helper_determine_rate':
/kisskb/src/drivers/clk/sunxi-ng/ccu_mux.c:150:22: warning: 'best_parent' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c: In function 'sh_mobile_i2c_isr':
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c:399:26: warning: 'data' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c:372:16: note: 'data' was declared here
/kisskb/src/drivers/clk/ti/clk.c: In function 'omap2_clk_for_each':
/kisskb/src/drivers/clk/ti/clk.c:579:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/soc/qcom/wcnss_ctrl.c: In function 'wcnss_async_probe':
/kisskb/src/drivers/soc/qcom/wcnss_ctrl.c:299:5: warning: 'expect_cbc' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_open':
/kisskb/src/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1010:12: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1000:6: note: 'ret' was declared here
/kisskb/src/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c: In function 'get_scale_config':
/kisskb/src/drivers/gpu/drm/msm/disp/mdp5/mdp5.xml.h:1036:16: warning: 'uv_filter' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c:695:22: note: 'uv_filter' was declared here
/kisskb/src/drivers/usb/core/devio.c: In function 'async_completed':
/kisskb/src/drivers/usb/core/devio.c:613:23: warning: 'errno' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/gpu/drm/sun4i/sun4i_tcon.c: In function 'sun4i_tcon_bind':
/kisskb/src/drivers/gpu/drm/sun4i/sun4i_tcon.c:1176:35: warning: 'has_lvds_alt' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function 'sun6i_dsi_encoder_enable':
/kisskb/src/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: warning: missing braces around initializer [-Wmissing-braces]
/kisskb/src/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: warning: (near initialization for 'opts.mipi_dphy') [-Wmissing-braces]
/kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c: In function 'gk104_top_oneinit':
/kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:104:1: warning: 'inst' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:104:1: warning: 'type' may be used uninitialized in this function [-Wuninitialized]
Completed OK
# rm -rf /kisskb/build/linus_multi_v7_defconfig_arm
# Build took: 0:03:06.725156