Buildresult: linus/um-allmodconfig/um-x86_64 built on Sep 6 2019, 11:39

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	Failed
Date/Time:	Sep 6 2019, 11:39
Duration:	0:05:33.545047
Builder:	ka4
Revision:	keys: Fix missing null pointer check in request_key_auth_describe() (`d41a3effbb53b1bcea41e328d16a4d046a508381)`
Target:	linus/um-allmodconfig/um-x86_64
Branch:	linus
Compiler:	um-x86_64 (x86_64-linux-gcc.br_real (Buildroot 2017.05) 5.4.0 / GNU ld (GNU Binutils) 2.27)
Config:	allmodconfig (download)
Log:	Download original Possible errors mm/hmm.c:753:9: error: implicit declaration of function 'pud_pfn' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors make[2]: * [scripts/Makefile.build:281: mm/hmm.o] Error 1 make[1]: * [Makefile:1083: mm] Error 2 drivers/misc/lkdtm/bugs.c:279:8: error: implicit declaration of function 'native_read_cr4' [-Werror=implicit-function-declaration] drivers/misc/lkdtm/bugs.c:281:13: error: 'X86_CR4_SMEP' undeclared (first use in this function) drivers/misc/lkdtm/bugs.c:288:2: error: implicit declaration of function 'native_write_cr4' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors make[4]: * [scripts/Makefile.build:281: drivers/misc/lkdtm/bugs.o] Error 1 make[3]: * [scripts/Makefile.build:497: drivers/misc/lkdtm] Error 2 make[2]: * [scripts/Makefile.build:497: drivers/misc] Error 2 make[1]: * [Makefile:1083: drivers] Error 2 make: * [Makefile:179: sub-make] Error 2 Possible warnings (3) arch/um/os-Linux/signal.c:93:1: warning: the frame size of 2960 bytes is larger than 2048 bytes [-Wframe-larger-than=] arch/um/os-Linux/signal.c:51:1: warning: the frame size of 2976 bytes is larger than 2048 bytes [-Wframe-larger-than=] security/apparmor/policy_unpack.c:523:9: warning: 'pos' may be used uninitialized in this function [-Wmaybe-uninitialized] Full Log # git rev-parse -q --verify d41a3effbb53b1bcea41e328d16a4d046a508381^{commit} d41a3effbb53b1bcea41e328d16a4d046a508381 already have revision, skipping fetch # git checkout -q -f -B kisskb d41a3effbb53b1bcea41e328d16a4d046a508381 # git clean -qxdf # < git log -1 # commit d41a3effbb53b1bcea41e328d16a4d046a508381 # Author: Hillf Danton <hdanton@sina.com> # Date: Mon Sep 2 13:37:29 2019 +0100 # # keys: Fix missing null pointer check in request_key_auth_describe() # # If a request_key authentication token key gets revoked, there's a window in # which request_key_auth_describe() can see it with a NULL payload - but it # makes no check for this and something like the following oops may occur: # # BUG: Kernel NULL pointer dereference at 0x00000038 # Faulting instruction address: 0xc0000000004ddf30 # Oops: Kernel access of bad area, sig: 11 [#1] # ... # NIP [...] request_key_auth_describe+0x90/0xd0 # LR [...] request_key_auth_describe+0x54/0xd0 # Call Trace: # [...] request_key_auth_describe+0x54/0xd0 (unreliable) # [...] proc_keys_show+0x308/0x4c0 # [...] seq_read+0x3d0/0x540 # [...] proc_reg_read+0x90/0x110 # [...] __vfs_read+0x3c/0x70 # [...] vfs_read+0xb4/0x1b0 # [...] ksys_read+0x7c/0x130 # [...] system_call+0x5c/0x70 # # Fix this by checking for a NULL pointer when describing such a key. # # Also make the read routine check for a NULL pointer to be on the safe side. # # [DH: Modified to not take already-held rcu lock and modified to also check # in the read routine] # # Fixes: 04c567d9313e ("[PATCH] Keys: Fix race between two instantiators of a key") # Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com> # Signed-off-by: Hillf Danton <hdanton@sina.com> # Signed-off-by: David Howells <dhowells@redhat.com> # Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 d41a3effbb53b1bcea41e328d16a4d046a508381 # < make -s -j 10 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 allmodconfig # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_KCOV=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_GCC_PLUGIN_CYC_COMPLEXITY=n # Added to kconfig CONFIG_GCC_PLUGIN_SANCOV=n # Added to kconfig CONFIG_GCC_PLUGIN_LATENT_ENTROPY=n # Added to kconfig CONFIG_GCC_PLUGIN_STRUCTLEAK=n # Added to kconfig CONFIG_GCC_PLUGIN_RANDSTRUCT=n # Added to kconfig CONFIG_UML_NET=n # Added to kconfig CONFIG_UML_NET_ETHERTAP=n # Added to kconfig CONFIG_UML_NET_TUNTAP=n # Added to kconfig CONFIG_UML_NET_SLIP=n # Added to kconfig CONFIG_UML_NET_DAEMON=n # Added to kconfig CONFIG_UML_NET_VDE=n # Added to kconfig CONFIG_UML_NET_MCAST=n # Added to kconfig CONFIG_UML_NET_PCAP=n # Added to kconfig CONFIG_UML_NET_SLIRP=n # Added to kconfig CONFIG_GCOV_KERNEL=n # yes \n \| make -s -j 10 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 oldconfig yes: standard output: Broken pipe # make -s -j 10 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 /kisskb/src/arch/um/os-Linux/signal.c: In function 'timer_real_alarm_handler': /kisskb/src/arch/um/os-Linux/signal.c:93:1: warning: the frame size of 2960 bytes is larger than 2048 bytes [-Wframe-larger-than=] } ^ /kisskb/src/arch/um/os-Linux/signal.c: In function 'sig_handler_common': /kisskb/src/arch/um/os-Linux/signal.c:51:1: warning: the frame size of 2976 bytes is larger than 2048 bytes [-Wframe-larger-than=] } ^ /kisskb/src/security/apparmor/policy_unpack.c: In function 'unpack_profile': /kisskb/src/security/apparmor/policy_unpack.c:523:9: warning: 'pos' may be used uninitialized in this function [-Wmaybe-uninitialized] str[pos] = ':'; ^ /kisskb/src/security/apparmor/policy_unpack.c:494:14: note: 'pos' was declared here int c, j, pos, size2 = unpack_strdup(e, &str, NULL); ^ /kisskb/src/mm/hmm.c: In function 'hmm_vma_walk_pud': /kisskb/src/mm/hmm.c:753:9: error: implicit declaration of function 'pud_pfn' [-Werror=implicit-function-declaration] pfn = pud_pfn(pud) + ((addr & ~PUD_MASK) >> PAGE_SHIFT); ^ cc1: some warnings being treated as errors make[2]: * [/kisskb/src/scripts/Makefile.build:281: mm/hmm.o] Error 1 make[1]: * [/kisskb/src/Makefile:1083: mm] Error 2 make[1]: * Waiting for unfinished jobs.... /kisskb/src/drivers/misc/lkdtm/bugs.c: In function 'lkdtm_UNSET_SMEP': /kisskb/src/drivers/misc/lkdtm/bugs.c:279:8: error: implicit declaration of function 'native_read_cr4' [-Werror=implicit-function-declaration] cr4 = native_read_cr4(); ^ /kisskb/src/drivers/misc/lkdtm/bugs.c:281:13: error: 'X86_CR4_SMEP' undeclared (first use in this function) if ((cr4 & X86_CR4_SMEP) != X86_CR4_SMEP) { ^ /kisskb/src/drivers/misc/lkdtm/bugs.c:281:13: note: each undeclared identifier is reported only once for each function it appears in /kisskb/src/drivers/misc/lkdtm/bugs.c:288:2: error: implicit declaration of function 'native_write_cr4' [-Werror=implicit-function-declaration] native_write_cr4(cr4); ^ cc1: some warnings being treated as errors make[4]: * [/kisskb/src/scripts/Makefile.build:281: drivers/misc/lkdtm/bugs.o] Error 1 make[3]: * [/kisskb/src/scripts/Makefile.build:497: drivers/misc/lkdtm] Error 2 make[2]: * [/kisskb/src/scripts/Makefile.build:497: drivers/misc] Error 2 make[2]: * Waiting for unfinished jobs.... make[1]: * [/kisskb/src/Makefile:1083: drivers] Error 2 make: * [Makefile:179: sub-make] Error 2 Command 'make -s -j 10 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_um-allmodconfig_um-x86_64 # Build took: 0:05:33.545047

© Michael Ellerman 2006-2018.