# git rev-parse -q --verify 950b07c14e8c59444e2359f15fd70ed5112e11a0^{commit} 950b07c14e8c59444e2359f15fd70ed5112e11a0 already have revision, skipping fetch # git checkout -q -f -B kisskb 950b07c14e8c59444e2359f15fd70ed5112e11a0 # git clean -qxdf # < git log -1 # commit 950b07c14e8c59444e2359f15fd70ed5112e11a0 # Author: Linus Torvalds # Date: Sat Sep 7 14:25:54 2019 -0700 # # Revert "x86/apic: Include the LDR when clearing out APIC registers" # # This reverts commit 558682b5291937a70748d36fd9ba757fb25b99ae. # # Chris Wilson reports that it breaks his CPU hotplug test scripts. In # particular, it breaks offlining and then re-onlining the boot CPU, which # we treat specially (and the BIOS does too). # # The symptoms are that we can offline the CPU, but it then does not come # back online again: # # smpboot: CPU 0 is now offline # smpboot: Booting Node 0 Processor 0 APIC 0x0 # smpboot: do_boot_cpu failed(-1) to wakeup CPU#0 # # Thomas says he knows why it's broken (my personal suspicion: our magic # handling of the "cpu0_logical_apicid" thing), but for 5.3 the right fix # is to just revert it, since we've never touched the LDR bits before, and # it's not worth the risk to do anything else at this stage. # # [ Hotpluging of the boot CPU is special anyway, and should be off by # default. See the "BOOTPARAM_HOTPLUG_CPU0" config option and the # cpu0_hotplug kernel parameter. # # In general you should not do it, and it has various known limitations # (hibernate and suspend require the boot CPU, for example). # # But it should work, even if the boot CPU is special and needs careful # treatment - Linus ] # # Link: https://lore.kernel.org/lkml/156785100521.13300.14461504732265570003@skylake-alporthouse-com/ # Reported-by: Chris Wilson # Acked-by: Thomas Gleixner # Cc: Bandan Das # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-ld --version # < git log --format=%s --max-count=1 950b07c14e8c59444e2359f15fd70ed5112e11a0 # < make -s -j 32 ARCH=parisc O=/kisskb/build/linus_parisc-defconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- defconfig # make -s -j 32 ARCH=parisc O=/kisskb/build/linus_parisc-defconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- /kisskb/src/drivers/scsi/ncr53c8xx.c: In function 'ncr_int_sir': /kisskb/src/drivers/scsi/ncr53c8xx.c:6713:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (tp->lp[0]) { ^ /kisskb/src/drivers/scsi/ncr53c8xx.c:6717:2: note: here case SIR_RESEL_BAD_TARGET: /* Will send a TARGET RESET message */ ^~~~ /kisskb/src/drivers/scsi/ncr53c8xx.c: In function 'ncr_prepare_setting': /kisskb/src/drivers/scsi/ncr53c8xx.c:3908:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (np->sv_scntl3) { ^ /kisskb/src/drivers/scsi/ncr53c8xx.c:3913:3: note: here case 3: /* SYMBIOS controllers report HVD through GPIO3 */ ^~~~ /kisskb/src/drivers/scsi/ncr53c8xx.c:3914:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (INB(nc_gpreg) & 0x08) ^ /kisskb/src/drivers/scsi/ncr53c8xx.c:3916:3: note: here case 2: /* Set HVD unconditionally */ ^~~~ /kisskb/src/drivers/scsi/ncr53c8xx.c:3917:18: warning: this statement may fall through [-Wimplicit-fallthrough=] np->scsi_mode = SMODE_HVD; /kisskb/src/drivers/scsi/ncr53c8xx.c:3918:3: note: here case 1: /* Trust previous settings for HVD */ ^~~~ Completed OK # rm -rf /kisskb/build/linus_parisc-defconfig_parisc # Build took: 0:01:12.940944