Buildresult: linus/s390-defconfig/s390x-gcc4.6 built on Oct 3 2019, 11:04

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	Failed
Date/Time:	Oct 3 2019, 11:04
Duration:	0:00:03.244274
Builder:	ka4
Revision:	timer-of: don't use conditional expression with mixed 'void' types (`0f1a7b3fac0583083ca19d4de47403511ced3521)`
Target:	linus/s390-defconfig/s390x-gcc4.6
Branch:	linus
Compiler:	s390x-gcc4.6 (s390x-linux-gcc (GCC) 4.6.3 / GNU ld (GNU Binutils) 2.22)
Config:	defconfig (download)
Log:	Download original Possible errors cc1: error: unrecognized command line option '-mtune=zEC12' cc1: error: unrecognized command line option '-mtune=zEC12' make[2]: * [scripts/Makefile.build:99: scripts/mod/devicetable-offsets.s] Error 1 make[2]: * [scripts/Makefile.build:266: scripts/mod/empty.o] Error 1 make[1]: * [Makefile:1128: prepare0] Error 2 make: * [Makefile:179: sub-make] Error 2 No warnings found in log. Full Log # git rev-parse -q --verify 0f1a7b3fac0583083ca19d4de47403511ced3521^{commit} 0f1a7b3fac0583083ca19d4de47403511ced3521 already have revision, skipping fetch # git checkout -q -f -B kisskb 0f1a7b3fac0583083ca19d4de47403511ced3521 # git clean -qxdf # < git log -1 # commit 0f1a7b3fac0583083ca19d4de47403511ced3521 # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Wed Oct 2 16:16:07 2019 -0700 # # timer-of: don't use conditional expression with mixed 'void' types # # Randy Dunlap reports on the sparse list that sparse warns about this # expression: # # of_irq->percpu ? free_percpu_irq(of_irq->irq, clkevt) : # free_irq(of_irq->irq, clkevt); # # and honestly, sparse is correct to warn. The return type of # free_percpu_irq() is 'void', while free_irq() returns a 'const void ' # that is the devname argument passed in to the request_irq(). # # You can't mix a void type with a non-void types in a conditional # expression according to the C standard. It so happens that gcc seems to # accept it - and the resulting type of the expression is void - but # there's really no reason for the kernel to have this kind of # non-standard expression with no real upside. # # The natural way to write that expression is with an if-statement: # # if (of_irq->percpu) # free_percpu_irq(of_irq->irq, clkevt); # else # free_irq(of_irq->irq, clkevt); # # which is more legible anyway. # # I'm not sure why that timer-of code seems to have this odd pattern. It # does the same at allocation time, but at least there the types match, # and it makes sense as an expression. # # Reported-by: Randy Dunlap <rdunlap@infradead.org> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/gcc-4.6.3-nolibc/s390x-linux/bin/s390x-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/s390x-linux/bin/s390x-linux-ld --version # < git log --format=%s --max-count=1 0f1a7b3fac0583083ca19d4de47403511ced3521 # < make -s -j 10 ARCH=s390 O=/kisskb/build/linus_s390-defconfig_s390x CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/s390x-linux/bin/s390x-linux- defconfig # make -s -j 10 ARCH=s390 O=/kisskb/build/linus_s390-defconfig_s390x CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/s390x-linux/bin/s390x-linux- cc1: error: unrecognized command line option '-mtune=zEC12' cc1: error: unrecognized command line option '-mtune=zEC12' make[2]: [/kisskb/src/scripts/Makefile.build:99: scripts/mod/devicetable-offsets.s] Error 1 make[2]: * Waiting for unfinished jobs.... make[2]: * [/kisskb/src/scripts/Makefile.build:266: scripts/mod/empty.o] Error 1 make[1]: * [/kisskb/src/Makefile:1128: prepare0] Error 2 make: *** [Makefile:179: sub-make] Error 2 Command 'make -s -j 10 ARCH=s390 O=/kisskb/build/linus_s390-defconfig_s390x CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/s390x-linux/bin/s390x-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_s390-defconfig_s390x # Build took: 0:00:03.244274

© Michael Ellerman 2006-2018.