# git rev-parse -q --verify 0f1a7b3fac0583083ca19d4de47403511ced3521^{commit}
0f1a7b3fac0583083ca19d4de47403511ced3521
already have revision, skipping fetch
# git checkout -q -f -B kisskb 0f1a7b3fac0583083ca19d4de47403511ced3521
# git clean -qxdf
# < git log -1
# commit 0f1a7b3fac0583083ca19d4de47403511ced3521
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Wed Oct 2 16:16:07 2019 -0700
# 
#     timer-of: don't use conditional expression with mixed 'void' types
#     
#     Randy Dunlap reports on the sparse list that sparse warns about this
#     expression:
#     
#             of_irq->percpu ? free_percpu_irq(of_irq->irq, clkevt) :
#                     free_irq(of_irq->irq, clkevt);
#     
#     and honestly, sparse is correct to warn.  The return type of
#     free_percpu_irq() is 'void', while free_irq() returns a 'const void *'
#     that is the devname argument passed in to the request_irq().
#     
#     You can't mix a void type with a non-void types in a conditional
#     expression according to the C standard.  It so happens that gcc seems to
#     accept it - and the resulting type of the expression is void - but
#     there's really no reason for the kernel to have this kind of
#     non-standard expression with no real upside.
#     
#     The natural way to write that expression is with an if-statement:
#     
#             if (of_irq->percpu)
#                     free_percpu_irq(of_irq->irq, clkevt);
#             else
#                     free_irq(of_irq->irq, clkevt);
#     
#     which is more legible anyway.
#     
#     I'm not sure why that timer-of code seems to have this odd pattern.  It
#     does the same at allocation time, but at least there the types match,
#     and it makes sense as an expression.
#     
#     Reported-by: Randy Dunlap <rdunlap@infradead.org>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version
# < git log --format=%s --max-count=1 0f1a7b3fac0583083ca19d4de47403511ced3521
# < make -s -j 24 ARCH=powerpc O=/kisskb/build/linus_pseries_defconfig+POWERNV=n_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  pseries_defconfig
# Added to kconfig CONFIG_PPC_POWERNV=n
# yes \n | make -s -j 24 ARCH=powerpc O=/kisskb/build/linus_pseries_defconfig+POWERNV=n_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  oldconfig
yes: standard output: Broken pipe
# make -s -j 24 ARCH=powerpc O=/kisskb/build/linus_pseries_defconfig+POWERNV=n_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  
/kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl':
/kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read':
/kisskb/src/drivers/base/regmap/regmap.c:2591:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write':
/kisskb/src/drivers/base/regmap/regmap.c:1852:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page':
/kisskb/src/mm/hugetlb.c:1497:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/bridge/br_netlink.c: In function 'br_afspec.isra.30':
/kisskb/src/net/bridge/br_netlink.c:648:7: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/core/devlink.c: In function 'devlink_fmsg_prepare_skb':
/kisskb/src/net/core/devlink.c:4484:6: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc':
/kisskb/src/fs/nfsd/nfs4xdr.c:2076:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c: In function 'proc_reg_open':
/kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here
/kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char':
/kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/tun.c: In function 'tun_get_user':
/kisskb/src/drivers/net/tun.c:1836:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/tun.c:1749:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq':
/kisskb/src/drivers/tty/serial/8250/8250_core.c:248:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/tty/serial/8250/8250_core.c:228:19: note: 'i' was declared here
/kisskb/src/drivers/usb/core/devio.c: In function 'async_completed':
/kisskb/src/drivers/usb/core/devio.c:625:23: warning: 'errno' may be used uninitialized in this function [-Wuninitialized]
Completed OK
# rm -rf /kisskb/build/linus_pseries_defconfig+POWERNV=n_powerpc-gcc4.6
# Build took: 0:02:53.039176