# git rev-parse -q --verify 0f1a7b3fac0583083ca19d4de47403511ced3521^{commit}
0f1a7b3fac0583083ca19d4de47403511ced3521
already have revision, skipping fetch
# git checkout -q -f -B kisskb 0f1a7b3fac0583083ca19d4de47403511ced3521
# git clean -qxdf
# < git log -1
# commit 0f1a7b3fac0583083ca19d4de47403511ced3521
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Wed Oct 2 16:16:07 2019 -0700
# 
#     timer-of: don't use conditional expression with mixed 'void' types
#     
#     Randy Dunlap reports on the sparse list that sparse warns about this
#     expression:
#     
#             of_irq->percpu ? free_percpu_irq(of_irq->irq, clkevt) :
#                     free_irq(of_irq->irq, clkevt);
#     
#     and honestly, sparse is correct to warn.  The return type of
#     free_percpu_irq() is 'void', while free_irq() returns a 'const void *'
#     that is the devname argument passed in to the request_irq().
#     
#     You can't mix a void type with a non-void types in a conditional
#     expression according to the C standard.  It so happens that gcc seems to
#     accept it - and the resulting type of the expression is void - but
#     there's really no reason for the kernel to have this kind of
#     non-standard expression with no real upside.
#     
#     The natural way to write that expression is with an if-statement:
#     
#             if (of_irq->percpu)
#                     free_percpu_irq(of_irq->irq, clkevt);
#             else
#                     free_irq(of_irq->irq, clkevt);
#     
#     which is more legible anyway.
#     
#     I'm not sure why that timer-of code seems to have this odd pattern.  It
#     does the same at allocation time, but at least there the types match,
#     and it makes sense as an expression.
#     
#     Reported-by: Randy Dunlap <rdunlap@infradead.org>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-gcc --version
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-ld --version
# < git log --format=%s --max-count=1 0f1a7b3fac0583083ca19d4de47403511ced3521
# < make -s -j 24 ARCH=sh O=/kisskb/build/linus_ul2_defconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-  ul2_defconfig
# make -s -j 24 ARCH=sh O=/kisskb/build/linus_ul2_defconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-  
  Generating include/generated/machtypes.h
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/kisskb/src/arch/sh/kernel/cpu/sh4/../sh3/../../entry-common.S: Assembler messages:
/kisskb/src/arch/sh/kernel/cpu/sh4/../sh3/../../entry-common.S:385: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence
/kisskb/src/arch/sh/kernel/cpu/sh4/../sh3/../../entry-common.S:388: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence
/kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields':
/kisskb/src/kernel/rcu/srcutree.c:121:34: warning: 'levelspread[<U6b40>]' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/kernel/rcu/srcutree.c:88:6: note: 'levelspread[<U6b40>]' was declared here
/kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl':
/kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/mm/vmstat.c: In function 'sysctl_vm_numa_stat_handler':
/kisskb/src/mm/vmstat.c:90:5: warning: 'oldval' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page':
/kisskb/src/mm/hugetlb.c:1497:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c: In function 'proc_reg_open':
/kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here
/kisskb/src/drivers/sh/clk/cpg.c: In function 'r8':
/kisskb/src/drivers/sh/clk/cpg.c:41:2: warning: passing argument 1 of 'ioread8' discards 'const' qualifier from pointer target type [enabled by default]
/kisskb/src/include/asm-generic/iomap.h:29:21: note: expected 'void *' but argument is of type 'const void *'
/kisskb/src/drivers/sh/clk/cpg.c: In function 'r16':
/kisskb/src/drivers/sh/clk/cpg.c:46:2: warning: passing argument 1 of 'ioread16' discards 'const' qualifier from pointer target type [enabled by default]
/kisskb/src/include/asm-generic/iomap.h:30:21: note: expected 'void *' but argument is of type 'const void *'
/kisskb/src/drivers/sh/clk/cpg.c: In function 'r32':
/kisskb/src/drivers/sh/clk/cpg.c:51:2: warning: passing argument 1 of 'ioread32' discards 'const' qualifier from pointer target type [enabled by default]
/kisskb/src/include/asm-generic/iomap.h:32:21: note: expected 'void *' but argument is of type 'const void *'
/kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon':
/kisskb/src/net/mac80211/mlme.c:1576:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/mac80211/mlme.c:1533:6: note: 'pwr_level_cisco' was declared here
/kisskb/src/drivers/usb/core/devio.c: In function 'async_completed':
/kisskb/src/drivers/usb/core/devio.c:625:23: warning: 'errno' may be used uninitialized in this function [-Wuninitialized]
mm/page_alloc.o: In function `get_page_from_freelist':
page_alloc.c:(.text+0x3148): undefined reference to `node_reclaim_distance'
make[1]: *** [/kisskb/src/Makefile:1094: vmlinux] Error 1
make: *** [Makefile:179: sub-make] Error 2
Command 'make -s -j 24 ARCH=sh O=/kisskb/build/linus_ul2_defconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-  ' returned non-zero exit status 2
# rm -rf /kisskb/build/linus_ul2_defconfig_sh4
# Build took: 0:00:54.671281