# git rev-parse -q --verify 0f1a7b3fac0583083ca19d4de47403511ced3521^{commit}
0f1a7b3fac0583083ca19d4de47403511ced3521
already have revision, skipping fetch
# git checkout -q -f -B kisskb 0f1a7b3fac0583083ca19d4de47403511ced3521
# git clean -qxdf
# < git log -1
# commit 0f1a7b3fac0583083ca19d4de47403511ced3521
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Wed Oct 2 16:16:07 2019 -0700
# 
#     timer-of: don't use conditional expression with mixed 'void' types
#     
#     Randy Dunlap reports on the sparse list that sparse warns about this
#     expression:
#     
#             of_irq->percpu ? free_percpu_irq(of_irq->irq, clkevt) :
#                     free_irq(of_irq->irq, clkevt);
#     
#     and honestly, sparse is correct to warn.  The return type of
#     free_percpu_irq() is 'void', while free_irq() returns a 'const void *'
#     that is the devname argument passed in to the request_irq().
#     
#     You can't mix a void type with a non-void types in a conditional
#     expression according to the C standard.  It so happens that gcc seems to
#     accept it - and the resulting type of the expression is void - but
#     there's really no reason for the kernel to have this kind of
#     non-standard expression with no real upside.
#     
#     The natural way to write that expression is with an if-statement:
#     
#             if (of_irq->percpu)
#                     free_percpu_irq(of_irq->irq, clkevt);
#             else
#                     free_irq(of_irq->irq, clkevt);
#     
#     which is more legible anyway.
#     
#     I'm not sure why that timer-of code seems to have this odd pattern.  It
#     does the same at allocation time, but at least there the types match,
#     and it makes sense as an expression.
#     
#     Reported-by: Randy Dunlap <rdunlap@infradead.org>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version
# < git log --format=%s --max-count=1 0f1a7b3fac0583083ca19d4de47403511ced3521
# < make -s -j 8 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-  randconfig
KCONFIG_SEED=0x28EF000E
# Added to kconfig CONFIG_STANDALONE=y
# Added to kconfig CONFIG_BUILD_DOCSRC=n
# Added to kconfig CONFIG_MODULE_SIG=n
# Added to kconfig CONFIG_CPU_BIG_ENDIAN=y
# Added to kconfig CONFIG_PPC64=y
# Added to kconfig CONFIG_PPC_DISABLE_WERROR=y
# Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y
# Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y
# Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n
# Added to kconfig CONFIG_GCC_PLUGINS=n
# Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y
# Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n
# Added to kconfig CONFIG_UBSAN=n
# yes \n | make -s -j 8 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-  oldconfig
yes: standard output: Broken pipe
# make -s -j 8 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-  
In file included from /kisskb/src/arch/powerpc/xmon/xmon.c:63:
/kisskb/src/arch/powerpc/xmon/dis-asm.h: In function 'print_insn_powerpc':
/kisskb/src/arch/powerpc/xmon/dis-asm.h:16:13: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=]
  printf("%.8x", insn);
          ~~~^   ~~~~
          %.8lx
/kisskb/src/arch/powerpc/xmon/dis-asm.h: In function 'print_insn_spu':
/kisskb/src/arch/powerpc/xmon/dis-asm.h:22:13: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=]
  printf("%.8x", insn);
          ~~~^   ~~~~
          %.8lx
/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: warning: orphan section `.gnu.hash' from `linker stubs' being placed in section `.gnu.hash'.
/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: warning: orphan section `.gnu.hash' from `linker stubs' being placed in section `.gnu.hash'.
/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: warning: orphan section `.gnu.hash' from `linker stubs' being placed in section `.gnu.hash'.
Completed OK
# rm -rf /kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc8
# Build took: 0:09:14.201984