# git rev-parse -q --verify cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3^{commit} cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 already have revision, skipping fetch # git checkout -q -f -B kisskb cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 # git clean -qxdf # < git log -1 # commit cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 # Author: Eric Sandeen # Date: Wed Oct 2 16:17:54 2019 -0500 # # vfs: Fix EOVERFLOW testing in put_compat_statfs64 # # Today, put_compat_statfs64() disallows nearly any field value over # 2^32 if f_bsize is only 32 bits, but that makes no sense. # compat_statfs64 is there for the explicit purpose of providing 64-bit # fields for f_files, f_ffree, etc. And f_bsize is always only 32 bits. # # As a result, 32-bit userspace gets -EOVERFLOW for i.e. large file # counts even with -D_FILE_OFFSET_BITS=64 set. # # In reality, only f_bsize and f_frsize can legitimately overflow # (fields like f_type and f_namelen should never be large), so test # only those fields. # # This bug was discussed at length some time ago, and this is the proposal # Al suggested at https://lkml.org/lkml/2018/8/6/640. It seemed to get # dropped amid the discussion of other related changes, but this # part seems obviously correct on its own, so I've picked it up and # sent it, for expediency. # # Fixes: 64d2ab32efe3 ("vfs: fix put_compat_statfs64() does not handle errors") # Signed-off-by: Eric Sandeen # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux-ld --version # < git log --format=%s --max-count=1 cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 # < make -s -j 48 ARCH=i386 O=/kisskb/build/linus_i386-allnoconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- allnoconfig # make -s -j 48 ARCH=i386 O=/kisskb/build/linus_i386-allnoconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/e820.c: In function 'e820__setup_pci_gap': /kisskb/src/arch/x86/kernel/e820.c:664:16: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/linus_i386-allnoconfig_i386 # Build took: 0:00:13.468087