# git rev-parse -q --verify cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3^{commit} cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 already have revision, skipping fetch # git checkout -q -f -B kisskb cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 # git clean -qxdf # < git log -1 # commit cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 # Author: Eric Sandeen # Date: Wed Oct 2 16:17:54 2019 -0500 # # vfs: Fix EOVERFLOW testing in put_compat_statfs64 # # Today, put_compat_statfs64() disallows nearly any field value over # 2^32 if f_bsize is only 32 bits, but that makes no sense. # compat_statfs64 is there for the explicit purpose of providing 64-bit # fields for f_files, f_ffree, etc. And f_bsize is always only 32 bits. # # As a result, 32-bit userspace gets -EOVERFLOW for i.e. large file # counts even with -D_FILE_OFFSET_BITS=64 set. # # In reality, only f_bsize and f_frsize can legitimately overflow # (fields like f_type and f_namelen should never be large), so test # only those fields. # # This bug was discussed at length some time ago, and this is the proposal # Al suggested at https://lkml.org/lkml/2018/8/6/640. It seemed to get # dropped amid the discussion of other related changes, but this # part seems obviously correct on its own, so I've picked it up and # sent it, for expediency. # # Fixes: 64d2ab32efe3 ("vfs: fix put_compat_statfs64() does not handle errors") # Signed-off-by: Eric Sandeen # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-ld --version # < git log --format=%s --max-count=1 cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 # < make -s -j 48 ARCH=arm O=/kisskb/build/linus_lpc32xx_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- lpc32xx_defconfig # make -s -j 48 ARCH=arm O=/kisskb/build/linus_lpc32xx_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- /kisskb/src/ipc/shm.c: In function 'ksys_shmdt': /kisskb/src/ipc/shm.c:1712:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:121:34: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:88:6: note: 'levelspread[]' was declared here /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here /kisskb/src/drivers/gpio/gpiolib-of.c: In function 'of_gpiochip_add': /kisskb/src/drivers/gpio/gpiolib-of.c:626:8: warning: 'dflags' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpio/gpiolib-of.c:612:19: note: 'dflags' was declared here /kisskb/src/drivers/gpio/gpiolib-of.c:626:8: warning: 'lflags' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpio/gpiolib-of.c:611:16: note: 'lflags' was declared here /kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic': /kisskb/src/net/core/gen_stats.c:157:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_sideband_msg_build': /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c:429:23: warning: 'hdrlen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/mtd/ubi/eba.c: In function 'try_write_vid_and_data': /kisskb/src/drivers/mtd/ubi/eba.c:988:7: warning: 'opnum' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list': /kisskb/src/net/core/dev.c:3407:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/soc-pcm.c: In function 'soc_pcm_trigger': /kisskb/src/sound/soc/soc-pcm.c:1074:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/soc-pcm.c: In function 'soc_pcm_bespoke_trigger': /kisskb/src/sound/soc/soc-pcm.c:1092:9: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/usb/core/devio.c: In function 'async_completed': /kisskb/src/drivers/usb/core/devio.c:625:23: warning: 'errno' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/drm_atomic.c: In function 'drm_atomic_check_only': /kisskb/src/drivers/gpu/drm/drm_atomic.c:426:38: warning: 'crtc_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/drm_atomic.c:405:25: note: 'crtc_state' was declared here /kisskb/src/lib/rhashtable.c: In function 'rht_deferred_worker': /kisskb/src/include/linux/rhashtable.h:110:10: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c:222:28: note: 'next' was declared here WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL Completed OK # rm -rf /kisskb/build/linus_lpc32xx_defconfig_arm # Build took: 0:01:00.917957