# git rev-parse -q --verify cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3^{commit} cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 already have revision, skipping fetch # git checkout -q -f -B kisskb cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 # git clean -qxdf # < git log -1 # commit cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 # Author: Eric Sandeen # Date: Wed Oct 2 16:17:54 2019 -0500 # # vfs: Fix EOVERFLOW testing in put_compat_statfs64 # # Today, put_compat_statfs64() disallows nearly any field value over # 2^32 if f_bsize is only 32 bits, but that makes no sense. # compat_statfs64 is there for the explicit purpose of providing 64-bit # fields for f_files, f_ffree, etc. And f_bsize is always only 32 bits. # # As a result, 32-bit userspace gets -EOVERFLOW for i.e. large file # counts even with -D_FILE_OFFSET_BITS=64 set. # # In reality, only f_bsize and f_frsize can legitimately overflow # (fields like f_type and f_namelen should never be large), so test # only those fields. # # This bug was discussed at length some time ago, and this is the proposal # Al suggested at https://lkml.org/lkml/2018/8/6/640. It seemed to get # dropped amid the discussion of other related changes, but this # part seems obviously correct on its own, so I've picked it up and # sent it, for expediency. # # Fixes: 64d2ab32efe3 ("vfs: fix put_compat_statfs64() does not handle errors") # Signed-off-by: Eric Sandeen # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-ld --version # < git log --format=%s --max-count=1 cc3a7bfe62b947b423fcb2cfe89fcba92bf48fa3 # < make -s -j 8 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # Added to kconfig CONFIG_MIPS_CPS_NS16550_BASE=0x1b0003f8 # Added to kconfig CONFIG_MIPS_CPS_NS16550_SHIFT=0 # yes \n | make -s -j 8 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- oldconfig yes: standard output: Broken pipe # make -s -j 8 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- /kisskb/src/arch/mips/vdso/Makefile:61: MIPS VDSO requires binutils >= 2.25 :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] /kisskb/src/fs/afs/dynroot.c: In function 'afs_lookup_atcell': /kisskb/src/fs/afs/dynroot.c:117:6: warning: 'len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/mips/vdso/Makefile:61: MIPS VDSO requires binutils >= 2.25 /kisskb/build/tmp/ccJR4VHn.s: Assembler messages: /kisskb/build/tmp/ccJR4VHn.s:222: Error: can't resolve `_start' {*UND* section} - `L0' {.text section} /kisskb/build/tmp/ccJR4VHn.s:680: Error: can't resolve `_start' {*UND* section} - `L0' {.text section} /kisskb/build/tmp/ccJR4VHn.s:911: Error: can't resolve `_start' {*UND* section} - `L0' {.text section} /kisskb/build/tmp/ccJR4VHn.s:1238: Error: can't resolve `_start' {*UND* section} - `L0' {.text section} /kisskb/build/tmp/ccJR4VHn.s:1457: Error: can't resolve `_start' {*UND* section} - `L0' {.text section} make[3]: *** [/kisskb/src/scripts/Makefile.build:266: arch/mips/vdso/vgettimeofday.o] Error 1 make[2]: *** [/kisskb/src/scripts/Makefile.build:509: arch/mips/vdso] Error 2 make[1]: *** [/kisskb/src/Makefile:1670: arch/mips] Error 2 make[1]: *** Waiting for unfinished jobs.... /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_nodes': /kisskb/src/kernel/rcu/srcutree.c:140:32: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/sched/core.c: In function 'try_to_wake_up': /kisskb/src/kernel/sched/core.c:2648:12: warning: 'cpu' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/btrfs/ref-verify.c: In function 'process_extent_item': /kisskb/src/fs/btrfs/ref-verify.c:492:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/btrfs/ref-verify.c: In function 'process_leaf': /kisskb/src/fs/btrfs/ref-verify.c:545:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/f2fs/file.c: In function 'f2fs_precache_extents': /kisskb/src/fs/f2fs/file.c:3095:6: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/f2fs/node.c: In function '__set_nat_cache_dirty': /kisskb/src/include/linux/list.h:93:12: warning: 'head' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/f2fs/node.c:236:24: note: 'head' was declared here /kisskb/src/fs/gfs2/bmap.c: In function 'gfs2_iomap_get': /kisskb/src/fs/gfs2/bmap.c:956:18: warning: 'height' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/gfs2/bmap.c:957:8: warning: 'len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/gfs2/bmap.c:957:8: warning: 'lblock' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2076:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/nfsd/nfs4xdr.c:2081:42: warning: 'end' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here /kisskb/src/fs/ocfs2/alloc.c: In function 'ocfs2_trim_mainbm': /kisskb/src/fs/ocfs2/alloc.c:7608:17: warning: 'first_bit' may be used uninitialized in this function [-Wuninitialized] make: *** [Makefile:179: sub-make] Error 2 Command 'make -s -j 8 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_mips-allmodconfig_mips # Build took: 0:03:38.201389