# git rev-parse -q --verify a8a30219ba78b1abb92091102b632f8e9bbdbf03^{commit} a8a30219ba78b1abb92091102b632f8e9bbdbf03 already have revision, skipping fetch # git checkout -q -f -B kisskb a8a30219ba78b1abb92091102b632f8e9bbdbf03 # git clean -qxdf # < git log -1 # commit a8a30219ba78b1abb92091102b632f8e9bbdbf03 # Author: Frederic Barrat # Date: Wed Oct 16 18:28:33 2019 +0200 # # powerpc/powernv/eeh: Fix oops when probing cxl devices # # Recent cleanup in the way EEH support is added to a device causes a # kernel oops when the cxl driver probes a device and creates virtual # devices discovered on the FPGA: # # BUG: Kernel NULL pointer dereference at 0x000000a0 # Faulting instruction address: 0xc000000000048070 # Oops: Kernel access of bad area, sig: 7 [#1] # ... # NIP eeh_add_device_late.part.9+0x50/0x1e0 # LR eeh_add_device_late.part.9+0x3c/0x1e0 # Call Trace: # _dev_info+0x5c/0x6c (unreliable) # pnv_pcibios_bus_add_device+0x60/0xb0 # pcibios_bus_add_device+0x40/0x60 # pci_bus_add_device+0x30/0x100 # pci_bus_add_devices+0x64/0xd0 # cxl_pci_vphb_add+0xe0/0x130 [cxl] # cxl_probe+0x504/0x5b0 [cxl] # local_pci_probe+0x6c/0x110 # work_for_cpu_fn+0x38/0x60 # # The root cause is that those cxl virtual devices don't have a # representation in the device tree and therefore no associated pci_dn # structure. In eeh_add_device_late(), pdn is NULL, so edev is NULL and # we oops. # # We never had explicit support for EEH for those virtual devices. # Instead, EEH events are reported to the (real) pci device and handled # by the cxl driver. Which can then forward to the virtual devices and # handle dependencies. The fact that we try adding EEH support for the # virtual devices is new and a side-effect of the recent cleanup. # # This patch fixes it by skipping adding EEH support on powernv for # devices which don't have a pci_dn structure. # # The cxl driver doesn't create virtual devices on pseries so this patch # doesn't fix it there intentionally. # # Fixes: b905f8cdca77 ("powerpc/eeh: EEH for pSeries hot plug") # Signed-off-by: Frederic Barrat # Reviewed-by: Sam Bobroff # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20191016162833.22509-1-fbarrat@linux.ibm.com # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 a8a30219ba78b1abb92091102b632f8e9bbdbf03 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # Added to kconfig CONFIG_PPC_E500MC=y # Added to kconfig CONFIG_VIRTUALIZATION=y # Added to kconfig CONFIG_KVM_E500MC=y # Added to kconfig # yes \n | make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- oldconfig yes: standard output: Broken pipe # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:9, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' if (IS_ERR_VALUE(fep->ring_mem_addr)) ^~~~~~~~~~~~ In file included from /kisskb/src/include/linux/acpi.h:15, from /kisskb/src/include/linux/i2c.h:13, from /kisskb/src/include/uapi/linux/fb.h:6, from /kisskb/src/include/linux/fb.h:6, from /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:20: /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c: In function 'fsl_diu_ioctl': /kisskb/src/include/linux/device.h:1743:2: warning: this statement may fall through [-Wimplicit-fallthrough=] _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1287:3: note: in expansion of macro 'dev_warn' dev_warn(info->dev, ^~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1290:2: note: here case MFB_SET_PIXFMT: ^~~~ In file included from /kisskb/src/include/linux/acpi.h:15, from /kisskb/src/include/linux/i2c.h:13, from /kisskb/src/include/uapi/linux/fb.h:6, from /kisskb/src/include/linux/fb.h:6, from /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:20: /kisskb/src/include/linux/device.h:1743:2: warning: this statement may fall through [-Wimplicit-fallthrough=] _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1296:3: note: in expansion of macro 'dev_warn' dev_warn(info->dev, ^~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1299:2: note: here case MFB_GET_PIXFMT: ^~~~ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe04b14) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xdf42e0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6598357 Bytes = 6443.71 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6599096 Bytes = 6444.43 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6562959 Bytes = 6409.14 KiB = 6.26 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6598181 Bytes = 6443.54 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6598155 Bytes = 6443.51 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6598249 Bytes = 6443.60 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6601014 Bytes = 6446.30 KiB = 6.30 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6598374 Bytes = 6443.72 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6600874 Bytes = 6446.17 KiB = 6.30 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6598359 Bytes = 6443.71 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6597238 Bytes = 6442.62 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6597998 Bytes = 6443.36 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6597739 Bytes = 6443.10 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6599115 Bytes = 6444.45 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6600873 Bytes = 6446.17 KiB = 6.30 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-rc2-ga8a30219ba78 Created: Fri Oct 25 23:42:14 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6597902 Bytes = 6443.26 KiB = 6.29 MiB Load Address: 00f00000 Entry Point: 00f002b4 Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc8 # Build took: 0:02:49.099312