# git rev-parse -q --verify b5baf00a90701b96e99ca3ca04d9f746bfe8ed89^{commit}
b5baf00a90701b96e99ca3ca04d9f746bfe8ed89
already have revision, skipping fetch
# git checkout -q -f -B kisskb b5baf00a90701b96e99ca3ca04d9f746bfe8ed89
# git clean -qxdf
# < git log -1
# commit b5baf00a90701b96e99ca3ca04d9f746bfe8ed89
# Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
# Date:   Sun Nov 10 14:55:42 2019 +0100
# 
#     random: Don't freeze in add_hwgenerator_randomness() if stopping kthread
#     
#     Since commit 59b569480dc8
#     ("random: Use wait_event_freezable() in add_hwgenerator_randomness()")
#     there is a race in add_hwgenerator_randomness() between freezing and
#     stopping the calling kthread.
#     
#     This commit changed wait_event_interruptible() call with
#     kthread_freezable_should_stop() as a condition into wait_event_freezable()
#     with just kthread_should_stop() as a condition to fix a warning that
#     kthread_freezable_should_stop() might sleep inside the wait.
#     
#     wait_event_freezable() ultimately calls __refrigerator() with its
#     check_kthr_stop argument set to false, which causes it to keep the kthread
#     frozen even if somebody calls kthread_stop() on it.
#     
#     Calling wait_event_freezable() with kthread_should_stop() as a condition
#     is racy because it doesn't take into account the situation where this
#     condition becomes true on a kthread marked for freezing only after this
#     condition has already been checked.
#     
#     Calling freezing() should avoid the issue that the commit 59b569480dc8 has
#     fixed, as it is only a checking function, it doesn't actually do the
#     freezing.
#     
#     add_hwgenerator_randomness() has two post-boot users: in khwrng the
#     kthread will be frozen anyway by call to kthread_freezable_should_stop()
#     in its main loop, while its second user (ath9k-hwrng) is not freezable at
#     all.
#     
#     This change allows a VM with virtio-rng loaded to write s2disk image
#     successfully.
#     
#     Fixes: 59b569480dc8 ("random: Use wait_event_freezable() in add_hwgenerator_randomness()")
#     Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
#     Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version
# < git log --format=%s --max-count=1 b5baf00a90701b96e99ca3ca04d9f746bfe8ed89
# < make -s -j 10 ARCH=powerpc O=/kisskb/build/crypto_ppc64_defconfig+NO_TM_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  ppc64_defconfig
# Added to kconfig CONFIG_PPC_TRANSACTIONAL_MEM=n
# yes \n | make -s -j 10 ARCH=powerpc O=/kisskb/build/crypto_ppc64_defconfig+NO_TM_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  oldconfig
yes: standard output: Broken pipe
# make -s -j 10 ARCH=powerpc O=/kisskb/build/crypto_ppc64_defconfig+NO_TM_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl':
/kisskb/src/kernel/printk/printk.c:194:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page':
/kisskb/src/mm/hugetlb.c:1465:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read':
/kisskb/src/drivers/base/regmap/regmap.c:2591:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write':
/kisskb/src/drivers/base/regmap/regmap.c:1852:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/bridge/br_netlink.c: In function 'br_afspec.isra.28':
/kisskb/src/net/bridge/br_netlink.c:648:7: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/kernel/futex.c: In function 'do_futex':
/kisskb/src/kernel/futex.c:1676:3: warning: 'oldval' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/kernel/futex.c:1651:6: note: 'oldval' was declared here
/kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc':
/kisskb/src/fs/nfsd/nfs4xdr.c:2065:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/core/devlink.c: In function 'devlink_fmsg_prepare_skb':
/kisskb/src/net/core/devlink.c:4443:6: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c: In function 'proc_reg_open':
/kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here
/kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char':
/kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq':
/kisskb/src/drivers/tty/serial/8250/8250_core.c:248:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/tty/serial/8250/8250_core.c:228:19: note: 'i' was declared here
/kisskb/src/drivers/usb/core/devio.c: In function 'async_completed':
/kisskb/src/drivers/usb/core/devio.c:613:23: warning: 'errno' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/tun.c: In function 'tun_get_user':
/kisskb/src/drivers/net/tun.c:1831:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/tun.c:1744:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized]
Completed OK
# rm -rf /kisskb/build/crypto_ppc64_defconfig+NO_TM_powerpc-gcc4.6
# Build took: 0:03:11.138272