Buildresult: crypto/x86_64-allnoconfig/x86_64-gcc8 built on Nov 15 2019, 17:41

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Nov 15 2019, 17:41
Duration:	0:00:24.067667
Builder:	blade4b
Revision:	random: Don't freeze in add_hwgenerator_randomness() if stopping kthread (`b5baf00a90701b96e99ca3ca04d9f746bfe8ed89)`
Target:	crypto/x86_64-allnoconfig/x86_64-gcc8
Branch:	crypto
Compiler:	x86_64-gcc8 (x86_64-linux-gcc (GCC) 8.1.0 / GNU ld (GNU Binutils) 2.30)
Config:	allnoconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify b5baf00a90701b96e99ca3ca04d9f746bfe8ed89^{commit} b5baf00a90701b96e99ca3ca04d9f746bfe8ed89 already have revision, skipping fetch # git checkout -q -f -B kisskb b5baf00a90701b96e99ca3ca04d9f746bfe8ed89 # git clean -qxdf # < git log -1 # commit b5baf00a90701b96e99ca3ca04d9f746bfe8ed89 # Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name> # Date: Sun Nov 10 14:55:42 2019 +0100 # # random: Don't freeze in add_hwgenerator_randomness() if stopping kthread # # Since commit 59b569480dc8 # ("random: Use wait_event_freezable() in add_hwgenerator_randomness()") # there is a race in add_hwgenerator_randomness() between freezing and # stopping the calling kthread. # # This commit changed wait_event_interruptible() call with # kthread_freezable_should_stop() as a condition into wait_event_freezable() # with just kthread_should_stop() as a condition to fix a warning that # kthread_freezable_should_stop() might sleep inside the wait. # # wait_event_freezable() ultimately calls __refrigerator() with its # check_kthr_stop argument set to false, which causes it to keep the kthread # frozen even if somebody calls kthread_stop() on it. # # Calling wait_event_freezable() with kthread_should_stop() as a condition # is racy because it doesn't take into account the situation where this # condition becomes true on a kthread marked for freezing only after this # condition has already been checked. # # Calling freezing() should avoid the issue that the commit 59b569480dc8 has # fixed, as it is only a checking function, it doesn't actually do the # freezing. # # add_hwgenerator_randomness() has two post-boot users: in khwrng the # kthread will be frozen anyway by call to kthread_freezable_should_stop() # in its main loop, while its second user (ath9k-hwrng) is not freezable at # all. # # This change allows a VM with virtio-rng loaded to write s2disk image # successfully. # # Fixes: 59b569480dc8 ("random: Use wait_event_freezable() in add_hwgenerator_randomness()") # Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> # Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 b5baf00a90701b96e99ca3ca04d9f746bfe8ed89 # < make -s -j 24 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- allnoconfig # make -s -j 24 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- Completed OK # rm -rf /kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc8 # Build took: 0:00:24.067667

© Michael Ellerman 2006-2018.