# git rev-parse -q --verify 942523fd67563ea677cc03fc97635893d4350749^{commit} 942523fd67563ea677cc03fc97635893d4350749 already have revision, skipping fetch # git checkout -q -f -B kisskb 942523fd67563ea677cc03fc97635893d4350749 # git clean -qxdf # < git log -1 # commit 942523fd67563ea677cc03fc97635893d4350749 # Author: Oliver O'Halloran # Date: Wed Nov 13 20:40:35 2019 +1100 # # powerpc/powernv: Disable native PCIe port management # # On PowerNV the PCIe topology is (currently) managed by the powernv # platform code in cooperation with firmware. The PCIe-native service # drivers bypass both and this can cause problems. # # Historically this hasn't been a big deal since the only port service # driver that saw much use was the AER driver. The AER driver relies on # a kernel service to report when errors occur rather than acting # autonomously so it's fairly easy to ignore. On PowerNV (and pseries) # AER events are handled through EEH, which ignores the AER service, so # it's never been an issue. # # Unfortunately, the hotplug port service driver (pciehp) does act # autonomously and conflicts with the platform specific hotplug # driver (pnv_php). The main issue is that pciehp claims the interrupt # associated with the PCIe capability which in turn prevents pnv_php # from claiming it. # # This results in hotplug events being handled by pciehp which does not # notify firmware when the PCIe topology changes, and does not # setup/teardown the arch specific PCI device structures (pci_dn) when # the topology changes. The end result is that hot-added devices cannot # be enabled and hot-removed devices may not be fully torn-down on # removal. # # We can fix these problems by setting the "pcie_ports_disabled" flag # during platform initialisation. The flag indicates the platform owns # the PCIe ports which stops the portbus driver from being registered. # # Fixes: 66725152fb9f ("PCI/hotplug: PowerPC PowerNV PCI hotplug driver") # Signed-off-by: Oliver O'Halloran # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20191113094035.22394-1-oohall@gmail.com # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 942523fd67563ea677cc03fc97635893d4350749 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_83xx_mpc8313_rdb_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- 83xx/mpc8313_rdb_defconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_83xx_mpc8313_rdb_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/arch/powerpc/kernel/vdso32/gettimeofday.S: Assembler messages: /kisskb/src/arch/powerpc/kernel/vdso32/gettimeofday.S:39: Error: unsupported relocation against __kernel_datapage_offset /kisskb/src/arch/powerpc/kernel/vdso32/gettimeofday.S:84: Error: unsupported relocation against __kernel_datapage_offset /kisskb/src/arch/powerpc/kernel/vdso32/gettimeofday.S:211: Error: unsupported relocation against __kernel_datapage_offset /kisskb/src/arch/powerpc/kernel/vdso32/gettimeofday.S:245: Error: unsupported relocation against __kernel_datapage_offset make[4]: *** [/kisskb/src/arch/powerpc/kernel/vdso32/Makefile:49: arch/powerpc/kernel/vdso32/gettimeofday.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:509: arch/powerpc/kernel/vdso32] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:509: arch/powerpc/kernel] Error 2 make[2]: *** Waiting for unfinished jobs.... /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2591:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] make[1]: *** [/kisskb/src/Makefile:1650: arch/powerpc] Error 2 make[1]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1852:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:248:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:228:19: note: 'i' was declared here /kisskb/src/drivers/usb/core/devio.c: In function 'async_completed': /kisskb/src/drivers/usb/core/devio.c:625:23: warning: 'errno' may be used uninitialized in this function [-Wuninitialized] make: *** [Makefile:179: sub-make] Error 2 Command 'make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_83xx_mpc8313_rdb_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next_83xx_mpc8313_rdb_defconfig_powerpc-gcc4.6 # Build took: 0:00:28.169146