# git rev-parse -q --verify 942523fd67563ea677cc03fc97635893d4350749^{commit} 942523fd67563ea677cc03fc97635893d4350749 already have revision, skipping fetch # git checkout -q -f -B kisskb 942523fd67563ea677cc03fc97635893d4350749 # git clean -qxdf # < git log -1 # commit 942523fd67563ea677cc03fc97635893d4350749 # Author: Oliver O'Halloran # Date: Wed Nov 13 20:40:35 2019 +1100 # # powerpc/powernv: Disable native PCIe port management # # On PowerNV the PCIe topology is (currently) managed by the powernv # platform code in cooperation with firmware. The PCIe-native service # drivers bypass both and this can cause problems. # # Historically this hasn't been a big deal since the only port service # driver that saw much use was the AER driver. The AER driver relies on # a kernel service to report when errors occur rather than acting # autonomously so it's fairly easy to ignore. On PowerNV (and pseries) # AER events are handled through EEH, which ignores the AER service, so # it's never been an issue. # # Unfortunately, the hotplug port service driver (pciehp) does act # autonomously and conflicts with the platform specific hotplug # driver (pnv_php). The main issue is that pciehp claims the interrupt # associated with the PCIe capability which in turn prevents pnv_php # from claiming it. # # This results in hotplug events being handled by pciehp which does not # notify firmware when the PCIe topology changes, and does not # setup/teardown the arch specific PCI device structures (pci_dn) when # the topology changes. The end result is that hot-added devices cannot # be enabled and hot-removed devices may not be fully torn-down on # removal. # # We can fix these problems by setting the "pcie_ports_disabled" flag # during platform initialisation. The flag indicates the platform owns # the PCIe ports which stops the portbus driver from being registered. # # Fixes: 66725152fb9f ("PCI/hotplug: PowerPC PowerNV PCI hotplug driver") # Signed-off-by: Oliver O'Halloran # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20191113094035.22394-1-oohall@gmail.com # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 942523fd67563ea677cc03fc97635893d4350749 # < make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-next_corenet32_smp_defconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- corenet32_smp_defconfig # make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-next_corenet32_smp_defconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/acpi.h:15, from /kisskb/src/include/linux/i2c.h:13, from /kisskb/src/include/uapi/linux/fb.h:6, from /kisskb/src/include/linux/fb.h:6, from /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:20: /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c: In function 'fsl_diu_ioctl': /kisskb/src/include/linux/device.h:1743:2: warning: this statement may fall through [-Wimplicit-fallthrough=] _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1287:3: note: in expansion of macro 'dev_warn' dev_warn(info->dev, ^~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1290:2: note: here case MFB_SET_PIXFMT: ^~~~ In file included from /kisskb/src/include/linux/acpi.h:15, from /kisskb/src/include/linux/i2c.h:13, from /kisskb/src/include/uapi/linux/fb.h:6, from /kisskb/src/include/linux/fb.h:6, from /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:20: /kisskb/src/include/linux/device.h:1743:2: warning: this statement may fall through [-Wimplicit-fallthrough=] _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1296:3: note: in expansion of macro 'dev_warn' dev_warn(info->dev, ^~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1299:2: note: here case MFB_GET_PIXFMT: ^~~~ INFO: Uncompressed kernel (size 0xe69450) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) Image Name: Linux-5.4.0-rc2-g942523fd6756 Created: Sat Nov 16 01:52:52 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6788188 Bytes = 6629.09 KiB = 6.47 MiB Load Address: 00000000 Entry Point: 00000000 Completed OK # rm -rf /kisskb/build/powerpc-next_corenet32_smp_defconfig_powerpc-gcc8 # Build took: 0:03:09.058673