# git rev-parse -q --verify be8d3292869350190dac9cd58c75bc005e3fd5c2^{commit} be8d3292869350190dac9cd58c75bc005e3fd5c2 already have revision, skipping fetch # git checkout -q -f -B kisskb be8d3292869350190dac9cd58c75bc005e3fd5c2 # git clean -qxdf # < git log -1 # commit be8d3292869350190dac9cd58c75bc005e3fd5c2 # Author: Oliver O'Halloran # Date: Mon Nov 18 17:55:53 2019 +1100 # # powerpc/powernv: Disable native PCIe port management # # On PowerNV the PCIe topology is (currently) managed by the powernv platform # code in Linux in cooperation with the platform firmware. Linux's native # PCIe port service drivers operate independently of both and this can cause # problems. # # The main issue is that the portbus driver will conflict with the platform # specific hotplug driver (pnv_php) over ownership of the MSI used to notify # the host when a hotplug event occurs. The portbus driver claims this MSI on # behalf of the individual port services because the same interrupt is used # for hotplug events, PMEs (on root ports), and link bandwidth change # notifications. The portbus driver will always claim the interrupt even if # the individual port service drivers, such as pciehp, are compiled out. # # The second, bigger, problem is that the hotplug port service driver # fundamentally does not work on PowerNV. The platform assumes that all # PCI devices have a corresponding arch-specific handle derived from the DT # node for the device (pci_dn) and without one the platform will not allow # a PCI device to be enabled. This problem is largely due to historical # baggage, but it can't be resolved without significant re-factoring of the # platform PCI support. # # We can fix these problems in the interim by setting the # "pcie_ports_disabled" flag during platform initialisation. The flag # indicates the platform owns the PCIe ports which stops the portbus driver # from being registered. # # This does have the side effect of disabling all port services drivers # that is: AER, PME, BW notifications, hotplug, and DPC. However, this is # not a huge disadvantage on PowerNV since these services are either unused # or handled through other means. # # Fixes: 66725152fb9f ("PCI/hotplug: PowerPC PowerNV PCI hotplug driver") # Signed-off-by: Oliver O'Halloran # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20191118065553.30362-1-oohall@gmail.com # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 be8d3292869350190dac9cd58c75bc005e3fd5c2 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_corenet64_smp_defconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- corenet64_smp_defconfig # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_corenet64_smp_defconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/acpi.h:15, from /kisskb/src/include/linux/i2c.h:13, from /kisskb/src/include/uapi/linux/fb.h:6, from /kisskb/src/include/linux/fb.h:6, from /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:20: /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c: In function 'fsl_diu_ioctl': /kisskb/src/include/linux/device.h:1743:2: warning: this statement may fall through [-Wimplicit-fallthrough=] _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1287:3: note: in expansion of macro 'dev_warn' dev_warn(info->dev, ^~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1290:2: note: here case MFB_SET_PIXFMT: ^~~~ In file included from /kisskb/src/include/linux/acpi.h:15, from /kisskb/src/include/linux/i2c.h:13, from /kisskb/src/include/uapi/linux/fb.h:6, from /kisskb/src/include/linux/fb.h:6, from /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:20: /kisskb/src/include/linux/device.h:1743:2: warning: this statement may fall through [-Wimplicit-fallthrough=] _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1296:3: note: in expansion of macro 'dev_warn' dev_warn(info->dev, ^~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1299:2: note: here case MFB_GET_PIXFMT: ^~~~ INFO: Uncompressed kernel (size 0x10d3210) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x1100000) Image Name: Linux-5.4.0-rc2-gbe8d32928693 Created: Tue Nov 19 00:28:09 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 7261418 Bytes = 7091.23 KiB = 6.93 MiB Load Address: 00000000 Entry Point: 00000000 Completed OK # rm -rf /kisskb/build/powerpc-next_corenet64_smp_defconfig_powerpc-gcc8 # Build took: 0:02:55.582096