# git rev-parse -q --verify cfe255e01d0d6bf2a23d46613c3d4cfe4505dd02^{commit} cfe255e01d0d6bf2a23d46613c3d4cfe4505dd02 already have revision, skipping fetch # git checkout -q -f -B kisskb cfe255e01d0d6bf2a23d46613c3d4cfe4505dd02 # git clean -qxdf # < git log -1 # commit cfe255e01d0d6bf2a23d46613c3d4cfe4505dd02 # Author: Oliver O'Halloran # Date: Mon Nov 18 17:55:53 2019 +1100 # # powerpc/powernv: Disable native PCIe port management # # On PowerNV the PCIe topology is (currently) managed by the powernv platform # code in Linux in cooperation with the platform firmware. Linux's native # PCIe port service drivers operate independently of both and this can cause # problems. # # The main issue is that the portbus driver will conflict with the platform # specific hotplug driver (pnv_php) over ownership of the MSI used to notify # the host when a hotplug event occurs. The portbus driver claims this MSI on # behalf of the individual port services because the same interrupt is used # for hotplug events, PMEs (on root ports), and link bandwidth change # notifications. The portbus driver will always claim the interrupt even if # the individual port service drivers, such as pciehp, are compiled out. # # The second, bigger, problem is that the hotplug port service driver # fundamentally does not work on PowerNV. The platform assumes that all # PCI devices have a corresponding arch-specific handle derived from the DT # node for the device (pci_dn) and without one the platform will not allow # a PCI device to be enabled. This problem is largely due to historical # baggage, but it can't be resolved without significant re-factoring of the # platform PCI support. # # We can fix these problems in the interim by setting the # "pcie_ports_disabled" flag during platform initialisation. The flag # indicates the platform owns the PCIe ports which stops the portbus driver # from being registered. # # This does have the side effect of disabling all port services drivers # that is: AER, PME, BW notifications, hotplug, and DPC. However, this is # not a huge disadvantage on PowerNV since these services are either unused # or handled through other means. # # Fixes: 66725152fb9f ("PCI/hotplug: PowerPC PowerNV PCI hotplug driver") # Signed-off-by: Oliver O'Halloran # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20191118065553.30362-1-oohall@gmail.com # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 cfe255e01d0d6bf2a23d46613c3d4cfe4505dd02 # < make -s -j 48 ARCH=x86 O=/kisskb/build/powerpc-next_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # yes \n | make -s -j 48 ARCH=x86 O=/kisskb/build/powerpc-next_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- oldconfig yes: standard output: Broken pipe # make -s -j 48 ARCH=x86 O=/kisskb/build/powerpc-next_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- /kisskb/src/tools/objtool /kisskb/src/security/integrity/platform_certs/load_uefi.c:17:19: warning: 'efi_cert_sha256_guid' defined but not used [-Wunused-variable] static efi_guid_t efi_cert_sha256_guid __initdata = EFI_CERT_SHA256_GUID; ^~~~~~~~~~~~~~~~~~~~ /kisskb/src/security/integrity/platform_certs/load_uefi.c:15:19: warning: 'efi_cert_x509_sha256_guid' defined but not used [-Wunused-variable] static efi_guid_t efi_cert_x509_sha256_guid __initdata = ^~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/security/integrity/platform_certs/load_uefi.c:14:19: warning: 'efi_cert_x509_guid' defined but not used [-Wunused-variable] static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID; ^~~~~~~~~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/powerpc-next_x86-allmodconfig_x86_64-gcc8 # Build took: 0:24:43.721774