# git rev-parse -q --verify 4ee812f6143d78d8ba1399671d78c8d78bf2817c^{commit} 4ee812f6143d78d8ba1399671d78c8d78bf2817c already have revision, skipping fetch # git checkout -q -f -B kisskb 4ee812f6143d78d8ba1399671d78c8d78bf2817c # git clean -qxdf # < git log -1 # commit 4ee812f6143d78d8ba1399671d78c8d78bf2817c # Author: Michael Ellerman # Date: Wed Nov 20 22:27:38 2019 +1100 # # crypto: vmx - Avoid weird build failures # # In the vmx crypto Makefile we assign to a variable called TARGET and # pass that to the aesp8-ppc.pl and ghashp8-ppc.pl scripts. # # The variable is meant to describe what flavour of powerpc we're # building for, eg. either 32 or 64-bit, and big or little endian. # # Unfortunately TARGET is a fairly common name for a make variable, and # if it happens that TARGET is specified as a command line parameter to # make, the value specified on the command line will override our value. # # In particular this can happen if the kernel Makefile is driven by an # external Makefile that uses TARGET for something. # # This leads to weird build failures, eg: # nonsense at /build/linux/drivers/crypto/vmx/ghashp8-ppc.pl line 45. # /linux/drivers/crypto/vmx/Makefile:20: recipe for target 'drivers/crypto/vmx/ghashp8-ppc.S' failed # # Which shows that we passed an empty value for $(TARGET) to the perl # script, confirmed with make V=1: # # perl /linux/drivers/crypto/vmx/ghashp8-ppc.pl > drivers/crypto/vmx/ghashp8-ppc.S # # We can avoid this confusion by using override, to tell make that we # don't want anything to override our variable, even a value specified # on the command line. We can also use a less common name, given the # script calls it "flavour", let's use that. # # Signed-off-by: Michael Ellerman # Signed-off-by: Herbert Xu # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 4ee812f6143d78d8ba1399671d78c8d78bf2817c # < make -s -j 10 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- allnoconfig # make -s -j 10 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- /kisskb/src/tools/objtool Completed OK # rm -rf /kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc8 # Build took: 0:00:21.948697