Buildresult: linus/i386-allnoconfig/i386-gcc4.6 built on Nov 27 2019, 09:44

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	Failed
Date/Time:	Nov 27 2019, 09:44
Duration:	0:00:26.412319
Builder:	ka3
Revision:	Revert "vfs: properly and reliably lock f_pos in fdget_pos()" (`2be7d348fe924f0c5583c6a805bd42cecda93104)`
Target:	linus/i386-allnoconfig/i386-gcc4.6
Branch:	linus
Compiler:	i386-gcc4.6 (i386-linux-gcc (GCC) 4.6.3 / GNU ld (GNU Binutils) 2.22)
Config:	allnoconfig (download)
Log:	Download original Possible errors arch/x86/mm/cpu_entry_area.c:190:2: error: call to '__compiletime_assert_190' declared with attribute error: BUILD_BUG_ON failed: (CPU_ENTRY_AREA_PAGES+1)PAGE_SIZE != CPU_ENTRY_AREA_MAP_SIZE make[3]: [scripts/Makefile.build:266: arch/x86/mm/cpu_entry_area.o] Error 1 make[2]: * [scripts/Makefile.build:509: arch/x86/mm] Error 2 make[1]: * [Makefile:1652: arch/x86] Error 2 make: * [Makefile:179: sub-make] Error 2 Possible warnings (2) kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] arch/x86/kernel/e820.c:664:16: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] Full Log # git rev-parse -q --verify 2be7d348fe924f0c5583c6a805bd42cecda93104^{commit} 2be7d348fe924f0c5583c6a805bd42cecda93104 already have revision, skipping fetch # git checkout -q -f -B kisskb 2be7d348fe924f0c5583c6a805bd42cecda93104 # git clean -qxdf # < git log -1 # commit 2be7d348fe924f0c5583c6a805bd42cecda93104 # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Tue Nov 26 11:34:06 2019 -0800 # # Revert "vfs: properly and reliably lock f_pos in fdget_pos()" # # This reverts commit 0be0ee71816b2b6725e2b4f32ad6726c9d729777. # # I was hoping it would be benign to switch over entirely to FMODE_STREAM, # and we'd have just a couple of small fixups we'd need, but it looks like # we're not quite there yet. # # While it worked fine on both my desktop and laptop, they are fairly # similar in other respects, and run mostly the same loads. Kenneth # Crudup reports that it seems to break both his vmware installation and # the KDE upower service. In both cases apparently leading to timeouts # due to waitinmg for the f_pos lock. # # There are a number of character devices in particular that definitely # want stream-like behavior, but that currently don't get marked as # streams, and as a result get the exclusion between concurrent # read()/write() on the same file descriptor. Which doesn't work well for # them. # # The most obvious example if this is /dev/console and /dev/tty, which use # console_fops and tty_fops respectively (and ptmx_fops for the pty master # side). It may be that it's just this that causes problems, but we # clearly weren't ready yet. # # Because there's a number of other likely common cases that don't have # llseek implementations and would seem to act as stream devices: # # /dev/fuse (fuse_dev_operations) # /dev/mcelog (mce_chrdev_ops) # /dev/mei0 (mei_fops) # /dev/net/tun (tun_fops) # /dev/nvme0 (nvme_dev_fops) # /dev/tpm0 (tpm_fops) # /proc/self/ns/mnt (ns_file_operations) # /dev/snd/pcm* (snd_pcm_f_ops[]) # # and while some of these could be trivially automatically detected by the # vfs layer when the character device is opened by just noticing that they # have no read or write operations either, it often isn't that obvious. # # Some character devices most definitely do use the file position, even if # they don't allow seeking: the firmware update code, for example, uses # simple_read_from_buffer() that does use f_pos, but doesn't allow seeking # back and forth. # # We'll revisit this when there's a better way to detect the problem and # fix it (possibly with a coccinelle script to do more of the FMODE_STREAM # annotations). # # Reported-by: Kenneth R. Crudup <kenny@panix.com> # Cc: Kirill Smelkov <kirr@nexedi.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux-ld --version # < git log --format=%s --max-count=1 2be7d348fe924f0c5583c6a805bd42cecda93104 # < make -s -j 10 ARCH=i386 O=/kisskb/build/linus_i386-allnoconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- allnoconfig # make -s -j 10 ARCH=i386 O=/kisskb/build/linus_i386-allnoconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/mm/cpu_entry_area.c: In function 'setup_cpu_entry_areas': /kisskb/src/arch/x86/mm/cpu_entry_area.c:190:2: error: call to '__compiletime_assert_190' declared with attribute error: BUILD_BUG_ON failed: (CPU_ENTRY_AREA_PAGES+1)PAGE_SIZE != CPU_ENTRY_AREA_MAP_SIZE make[3]: [/kisskb/src/scripts/Makefile.build:266: arch/x86/mm/cpu_entry_area.o] Error 1 make[2]: * [/kisskb/src/scripts/Makefile.build:509: arch/x86/mm] Error 2 make[2]: * Waiting for unfinished jobs.... /kisskb/src/arch/x86/kernel/e820.c: In function 'e820__setup_pci_gap': /kisskb/src/arch/x86/kernel/e820.c:664:16: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] make[1]: * [/kisskb/src/Makefile:1652: arch/x86] Error 2 make[1]: * Waiting for unfinished jobs.... make: * [Makefile:179: sub-make] Error 2 Command 'make -s -j 10 ARCH=i386 O=/kisskb/build/linus_i386-allnoconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_i386-allnoconfig_i386 # Build took: 0:00:26.412319

© Michael Ellerman 2006-2018.