# git rev-parse -q --verify 2be7d348fe924f0c5583c6a805bd42cecda93104^{commit} 2be7d348fe924f0c5583c6a805bd42cecda93104 already have revision, skipping fetch # git checkout -q -f -B kisskb 2be7d348fe924f0c5583c6a805bd42cecda93104 # git clean -qxdf # < git log -1 # commit 2be7d348fe924f0c5583c6a805bd42cecda93104 # Author: Linus Torvalds # Date: Tue Nov 26 11:34:06 2019 -0800 # # Revert "vfs: properly and reliably lock f_pos in fdget_pos()" # # This reverts commit 0be0ee71816b2b6725e2b4f32ad6726c9d729777. # # I was hoping it would be benign to switch over entirely to FMODE_STREAM, # and we'd have just a couple of small fixups we'd need, but it looks like # we're not quite there yet. # # While it worked fine on both my desktop and laptop, they are fairly # similar in other respects, and run mostly the same loads. Kenneth # Crudup reports that it seems to break both his vmware installation and # the KDE upower service. In both cases apparently leading to timeouts # due to waitinmg for the f_pos lock. # # There are a number of character devices in particular that definitely # want stream-like behavior, but that currently don't get marked as # streams, and as a result get the exclusion between concurrent # read()/write() on the same file descriptor. Which doesn't work well for # them. # # The most obvious example if this is /dev/console and /dev/tty, which use # console_fops and tty_fops respectively (and ptmx_fops for the pty master # side). It may be that it's just this that causes problems, but we # clearly weren't ready yet. # # Because there's a number of other likely common cases that don't have # llseek implementations and would seem to act as stream devices: # # /dev/fuse (fuse_dev_operations) # /dev/mcelog (mce_chrdev_ops) # /dev/mei0 (mei_fops) # /dev/net/tun (tun_fops) # /dev/nvme0 (nvme_dev_fops) # /dev/tpm0 (tpm_fops) # /proc/self/ns/mnt (ns_file_operations) # /dev/snd/pcm* (snd_pcm_f_ops[]) # # and while some of these could be trivially automatically detected by the # vfs layer when the character device is opened by just noticing that they # have no read or write operations either, it often isn't that obvious. # # Some character devices most definitely do use the file position, even if # they don't allow seeking: the firmware update code, for example, uses # simple_read_from_buffer() that does use f_pos, but doesn't allow seeking # back and forth. # # We'll revisit this when there's a better way to detect the problem and # fix it (possibly with a coccinelle script to do more of the FMODE_STREAM # annotations). # # Reported-by: Kenneth R. Crudup # Cc: Kirill Smelkov # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-ld --version # < git log --format=%s --max-count=1 2be7d348fe924f0c5583c6a805bd42cecda93104 # < make -s -j 32 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # Added to kconfig CONFIG_MIPS_CPS_NS16550_BASE=0x1b0003f8 # Added to kconfig CONFIG_MIPS_CPS_NS16550_SHIFT=0 # yes \n | make -s -j 32 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- oldconfig yes: standard output: Broken pipe # make -s -j 32 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- /kisskb/src/security/integrity/ima/ima_crypto.c: In function 'ima_calc_field_array_hash_tfm.isra.3': /kisskb/src/security/integrity/ima/ima_crypto.c:510:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ /kisskb/src/fs/btrfs/tree-checker.c: In function 'check_extent_data_item': /kisskb/src/fs/btrfs/tree-checker.c:230:43: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=] "invalid item size, have %u expect [%lu, %u)", ~~^ %u /kisskb/src/net/netfilter/nf_flow_table_offload.c: In function 'nf_flow_rule_match': /kisskb/src/net/netfilter/nf_flow_table_offload.c:80:21: warning: unsigned conversion from 'int' to '__be16' {aka 'short unsigned int'} changes value from '327680' to '0' [-Woverflow] mask->tcp.flags = TCP_FLAG_RST | TCP_FLAG_FIN; ^~~~~~~~~~~~ /kisskb/src/drivers/input/joystick/analog.c:160:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^~~~~~~ In file included from /kisskb/src/arch/mips/include/asm/page.h:261, from /kisskb/src/arch/mips/include/asm/io.h:29, from /kisskb/src/arch/mips/include/asm/mmiowb.h:5, from /kisskb/src/include/linux/spinlock.h:60, from /kisskb/src/include/linux/wait.h:9, from /kisskb/src/include/linux/net.h:19, from /kisskb/src/drivers/infiniband/sw/siw/siw_qp_tx.c:8: /kisskb/src/drivers/infiniband/sw/siw/siw_qp_tx.c: In function 'siw_tx_hdt': /kisskb/src/arch/mips/include/asm/page.h:249:53: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define virt_to_pfn(kaddr) PFN_DOWN(virt_to_phys((void *)(kaddr))) ^ /kisskb/src/include/asm-generic/memory_model.h:33:41: note: in definition of macro '__pfn_to_page' #define __pfn_to_page(pfn) (mem_map + ((pfn) - ARCH_PFN_OFFSET)) ^~~ /kisskb/src/arch/mips/include/asm/page.h:249:31: note: in expansion of macro 'PFN_DOWN' #define virt_to_pfn(kaddr) PFN_DOWN(virt_to_phys((void *)(kaddr))) ^~~~~~~~ /kisskb/src/arch/mips/include/asm/page.h:250:41: note: in expansion of macro 'virt_to_pfn' #define virt_to_page(kaddr) pfn_to_page(virt_to_pfn(kaddr)) ^~~~~~~~~~~ /kisskb/src/drivers/infiniband/sw/siw/siw_qp_tx.c:528:23: note: in expansion of macro 'virt_to_page' page_array[seg] = virt_to_page(va & PAGE_MASK); ^~~~~~~~~~~~ In file included from /kisskb/src/drivers/net/phy/mdio-cavium.c:11: /kisskb/src/drivers/net/phy/mdio-cavium.c: In function 'cavium_mdiobus_set_mode': /kisskb/src/drivers/net/phy/mdio-cavium.h:114:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_readq(addr) readq((void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-cavium.c:21:16: note: in expansion of macro 'oct_mdio_readq' smi_clk.u64 = oct_mdio_readq(p->register_base + SMI_CLK); ^~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-cavium.c:24:2: note: in expansion of macro 'oct_mdio_writeq' oct_mdio_writeq(smi_clk.u64, p->register_base + SMI_CLK); ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-cavium.c: In function 'cavium_mdiobus_c45_addr': /kisskb/src/drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-cavium.c:39:2: note: in expansion of macro 'oct_mdio_writeq' oct_mdio_writeq(smi_wr.u64, p->register_base + SMI_WR_DAT); ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-cavium.c:47:2: note: in expansion of macro 'oct_mdio_writeq' oct_mdio_writeq(smi_cmd.u64, p->register_base + SMI_CMD); ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-cavium.h:114:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_readq(addr) readq((void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-cavium.c:54:16: note: in expansion of macro 'oct_mdio_readq' smi_wr.u64 = oct_mdio_readq(p->register_base + SMI_WR_DAT); ^~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-cavium.c: In function 'cavium_mdiobus_read': /kisskb/src/drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-cavium.c:86:2: note: in expansion of macro 'oct_mdio_writeq' oct_mdio_writeq(smi_cmd.u64, p->register_base + SMI_CMD); ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-cavium.h:114:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_readq(addr) readq((void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-cavium.c:93:16: note: in expansion of macro 'oct_mdio_readq' smi_rd.u64 = oct_mdio_readq(p->register_base + SMI_RD_DAT); ^~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-cavium.c: In function 'cavium_mdiobus_write': /kisskb/src/drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-cavium.c:125:2: note: in expansion of macro 'oct_mdio_writeq' oct_mdio_writeq(smi_wr.u64, p->register_base + SMI_WR_DAT); ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-cavium.c:131:2: note: in expansion of macro 'oct_mdio_writeq' oct_mdio_writeq(smi_cmd.u64, p->register_base + SMI_CMD); ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-cavium.h:114:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_readq(addr) readq((void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-cavium.c:138:16: note: in expansion of macro 'oct_mdio_readq' smi_wr.u64 = oct_mdio_readq(p->register_base + SMI_WR_DAT); ^~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe': /kisskb/src/drivers/net/phy/mdio-octeon.c:48:3: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] (u64)devm_ioremap(&pdev->dev, mdio_phys, regsize); ^ In file included from /kisskb/src/drivers/net/phy/mdio-octeon.c:14: /kisskb/src/drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-octeon.c:56:2: note: in expansion of macro 'oct_mdio_writeq' oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-octeon.c:77:2: note: in expansion of macro 'oct_mdio_writeq' oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); ^~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_remove': /kisskb/src/drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ /kisskb/src/drivers/net/phy/mdio-octeon.c:91:2: note: in expansion of macro 'oct_mdio_writeq' oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); ^~~~~~~~~~~~~~~ /kisskb/src/drivers/spi/spi-sh-msiof.c:76: warning: "STR" redefined #define STR 0x40 /* Status Register */ In file included from /kisskb/src/arch/mips/include/asm/mach-generic/spaces.h:15, from /kisskb/src/arch/mips/include/asm/addrspace.h:13, from /kisskb/src/arch/mips/include/asm/barrier.h:11, from /kisskb/src/include/linux/compiler.h:256, from /kisskb/src/arch/mips/include/asm/bitops.h:17, from /kisskb/src/include/linux/bitops.h:26, from /kisskb/src/include/linux/bitmap.h:8, from /kisskb/src/drivers/spi/spi-sh-msiof.c:10: /kisskb/src/arch/mips/include/asm/mipsregs.h:30: note: this is the location of the previous definition #define STR(x) __STR(x) In file included from /kisskb/src/arch/mips/include/asm/octeon/octeon.h:11, from /kisskb/src/drivers/staging/octeon/octeon-ethernet.h:19, from /kisskb/src/drivers/staging/octeon/ethernet.c:22: /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_writeq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:282:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] cvmx_write_csr((__force uint64_t)csr_addr, val); ^ /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_readq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:299:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] return cvmx_read_csr((__force uint64_t) csr_addr); ^ In file included from /kisskb/src/arch/mips/include/asm/octeon/octeon.h:11, from /kisskb/src/drivers/staging/octeon/octeon-ethernet.h:19, from /kisskb/src/drivers/staging/octeon/ethernet-mdio.c:16: /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_writeq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:282:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] cvmx_write_csr((__force uint64_t)csr_addr, val); ^ /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_readq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:299:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] return cvmx_read_csr((__force uint64_t) csr_addr); ^ In file included from /kisskb/src/arch/mips/include/asm/octeon/octeon.h:11, from /kisskb/src/drivers/staging/octeon/octeon-ethernet.h:19, from /kisskb/src/drivers/staging/octeon/ethernet-mem.c:12: /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_writeq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:282:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] cvmx_write_csr((__force uint64_t)csr_addr, val); ^ /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_readq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:299:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] return cvmx_read_csr((__force uint64_t) csr_addr); ^ In file included from /kisskb/src/arch/mips/include/asm/octeon/octeon.h:11, from /kisskb/src/drivers/staging/octeon/octeon-ethernet.h:19, from /kisskb/src/drivers/staging/octeon/ethernet-rgmii.c:15: /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_writeq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:282:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] cvmx_write_csr((__force uint64_t)csr_addr, val); ^ /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_readq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:299:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] return cvmx_read_csr((__force uint64_t) csr_addr); ^ In file included from /kisskb/src/arch/mips/include/asm/octeon/octeon.h:11, from /kisskb/src/drivers/staging/octeon/octeon-ethernet.h:19, from /kisskb/src/drivers/staging/octeon/ethernet-rx.c:26: /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_writeq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:282:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] cvmx_write_csr((__force uint64_t)csr_addr, val); ^ /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_readq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:299:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] return cvmx_read_csr((__force uint64_t) csr_addr); ^ In file included from /kisskb/src/drivers/staging/octeon/ethernet-rx.c:27: /kisskb/src/drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_poll': /kisskb/src/drivers/staging/octeon/ethernet-defines.h:30:38: error: 'CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE' undeclared (first use in this function); did you mean 'CONFIG_MDIO_OCTEON_MODULE'? #define USE_ASYNC_IOBDMA (CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE > 0) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/staging/octeon/ethernet-rx.c:190:6: note: in expansion of macro 'USE_ASYNC_IOBDMA' if (USE_ASYNC_IOBDMA) { ^~~~~~~~~~~~~~~~ /kisskb/src/drivers/staging/octeon/ethernet-defines.h:30:38: note: each undeclared identifier is reported only once for each function it appears in #define USE_ASYNC_IOBDMA (CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE > 0) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/staging/octeon/ethernet-rx.c:190:6: note: in expansion of macro 'USE_ASYNC_IOBDMA' if (USE_ASYNC_IOBDMA) { ^~~~~~~~~~~~~~~~ /kisskb/src/drivers/staging/octeon/ethernet-rx.c: In function 'cvm_oct_rx_initialize': /kisskb/src/drivers/staging/octeon/ethernet-rx.c:472:25: error: 'OCTEON_IRQ_WORKQ0' undeclared (first use in this function); did you mean 'OCTEON_IS_MODEL'? oct_rx_group[i].irq = OCTEON_IRQ_WORKQ0 + i; ^~~~~~~~~~~~~~~~~ OCTEON_IS_MODEL make[4]: *** [/kisskb/src/scripts/Makefile.build:265: drivers/staging/octeon/ethernet-rx.o] Error 1 make[4]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/arch/mips/include/asm/octeon/octeon.h:11, from /kisskb/src/drivers/staging/octeon/octeon-ethernet.h:19, from /kisskb/src/drivers/staging/octeon/ethernet-sgmii.c:14: /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_writeq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:282:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] cvmx_write_csr((__force uint64_t)csr_addr, val); ^ /kisskb/src/arch/mips/include/asm/octeon/cvmx.h: In function 'cvmx_readq_csr': /kisskb/src/arch/mips/include/asm/octeon/cvmx.h:299:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] return cvmx_read_csr((__force uint64_t) csr_addr); ^ In file included from /kisskb/src/arch/mips/include/asm/sibyte/sb1250.h:28, from /kisskb/src/drivers/watchdog/sb_wdog.c:58: /kisskb/src/arch/mips/include/asm/sibyte/bcm1480_scd.h:261: warning: "M_SPC_CFG_CLEAR" redefined #define M_SPC_CFG_CLEAR M_BCM1480_SPC_CFG_CLEAR In file included from /kisskb/src/arch/mips/include/asm/sibyte/sb1250.h:27, from /kisskb/src/drivers/watchdog/sb_wdog.c:58: /kisskb/src/arch/mips/include/asm/sibyte/sb1250_scd.h:392: note: this is the location of the previous definition #define M_SPC_CFG_CLEAR _SB_MAKEMASK1(32) In file included from /kisskb/src/arch/mips/include/asm/sibyte/sb1250.h:28, from /kisskb/src/drivers/watchdog/sb_wdog.c:58: /kisskb/src/arch/mips/include/asm/sibyte/bcm1480_scd.h:262: warning: "M_SPC_CFG_ENABLE" redefined #define M_SPC_CFG_ENABLE M_BCM1480_SPC_CFG_ENABLE In file included from /kisskb/src/arch/mips/include/asm/sibyte/sb1250.h:27, from /kisskb/src/drivers/watchdog/sb_wdog.c:58: /kisskb/src/arch/mips/include/asm/sibyte/sb1250_scd.h:393: note: this is the location of the previous definition #define M_SPC_CFG_ENABLE _SB_MAKEMASK1(33) make[3]: *** [/kisskb/src/scripts/Makefile.build:509: drivers/staging/octeon] Error 2 make[3]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/include/linux/printk.h:7, from /kisskb/src/include/linux/kernel.h:15, from /kisskb/src/include/linux/mlx5/driver.h:36, from /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/wq.c:33: /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/wq.c: In function 'mlx5_wq_cyc_wqe_dump': /kisskb/src/include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^~~~~~ /kisskb/src/include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' #define KERN_INFO KERN_SOH "6" /* informational */ ^~~~~~~~ /kisskb/src/include/linux/printk.h:311:9: note: in expansion of macro 'KERN_INFO' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~ /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/wq.c:92:2: note: in expansion of macro 'pr_info' pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %ld\n", ^~~~~~~ /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/wq.c:92:71: note: format string is defined here pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %ld\n", ~~^ %d make[2]: *** [/kisskb/src/scripts/Makefile.build:509: drivers/staging] Error 2 make[2]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'mlx5e_grp_sw_update_stats': /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:302:1: warning: the frame size of 1200 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ make[1]: *** [/kisskb/src/Makefile:1652: drivers] Error 2 make: *** [Makefile:179: sub-make] Error 2 Command 'make -s -j 32 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_mips-allmodconfig_mips-gcc8 # Build took: 0:19:39.274565