Buildresult: powerpc-fixes/pseries_defconfig+NO_MEMORY_HOTREMOVE/powerpc-gcc8 built on Dec 7 2019, 01:02

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Dec 7 2019, 01:02
Duration:	0:03:21.189427
Builder:	ka1
Revision:	ocxl: Fix concurrent AFU open and device removal (`3bf9c3bd86cdde4aa4d12c2705d93e1d90464710)`
Target:	powerpc-fixes/pseries_defconfig+NO_MEMORY_HOTREMOVE/powerpc-gcc8
Branch:	powerpc-fixes
Compiler:	powerpc-gcc8 (powerpc64-linux-gcc (GCC) 8.1.0 / GNU ld (GNU Binutils) 2.30)
Config:	pseries_defconfig+NO_MEMORY_HOTREMOVE (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify 3bf9c3bd86cdde4aa4d12c2705d93e1d90464710^{commit} 3bf9c3bd86cdde4aa4d12c2705d93e1d90464710 already have revision, skipping fetch # git checkout -q -f -B kisskb 3bf9c3bd86cdde4aa4d12c2705d93e1d90464710 # git clean -qxdf # < git log -1 # commit 3bf9c3bd86cdde4aa4d12c2705d93e1d90464710 # Author: Frederic Barrat <fbarrat@linux.ibm.com> # Date: Mon Jun 24 16:41:48 2019 +0200 # # ocxl: Fix concurrent AFU open and device removal # # If an ocxl device is unbound through sysfs at the same time its AFU is # being opened by a user process, the open code may dereference freed # stuctures, which can lead to kernel oops messages. You'd have to hit a # tiny time window, but it's possible. It's fairly easy to test by # making the time window bigger artificially. # # Fix it with a combination of 2 changes: # - when an AFU device is found in the IDR by looking for the device # minor number, we should hold a reference on the device until after # the context is allocated. A reference on the AFU structure is kept # when the context is allocated, so we can release the reference on # the device after the context allocation. # - with the fix above, there's still another even tinier window, # between the time the AFU device is found in the IDR and the # reference on the device is taken. We can fix this one by removing # the IDR entry earlier, when the device setup is removed, instead # of waiting for the 'release' device callback. With proper locking # around the IDR. # # Fixes: 75ca758adbaf ("ocxl: Create a clear delineation between ocxl backend & frontend") # Cc: stable@vger.kernel.org # v5.2+ # Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com> # Reviewed-by: Greg Kurz <groug@kaod.org> # Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> # Link: https://lore.kernel.org/r/20190624144148.32022-1-fbarrat@linux.ibm.com # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 3bf9c3bd86cdde4aa4d12c2705d93e1d90464710 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- pseries_defconfig # Added to kconfig CONFIG_MEMORY_HOTPLUG=y # Added to kconfig CONFIG_MEMORY_HOTREMOVE=n # yes \n \| make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- oldconfig yes: standard output: Broken pipe # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- Completed OK # rm -rf /kisskb/build/powerpc-fixes_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc-gcc8 # Build took: 0:03:21.189427

© Michael Ellerman 2006-2018.