# git rev-parse -q --verify a5b9b743fdb653c37d347b303fb60dff0c743f7e^{commit} a5b9b743fdb653c37d347b303fb60dff0c743f7e already have revision, skipping fetch # git checkout -q -f -B kisskb a5b9b743fdb653c37d347b303fb60dff0c743f7e # git clean -qxdf # < git log -1 # commit a5b9b743fdb653c37d347b303fb60dff0c743f7e # Author: Frederic Barrat # Date: Mon Jun 24 16:41:48 2019 +0200 # # ocxl: Fix concurrent AFU open and device removal # # If an ocxl device is unbound through sysfs at the same time its AFU is # being opened by a user process, the open code may dereference freed # stuctures, which can lead to kernel oops messages. You'd have to hit a # tiny time window, but it's possible. It's fairly easy to test by # making the time window bigger artificially. # # Fix it with a combination of 2 changes: # - when an AFU device is found in the IDR by looking for the device # minor number, we should hold a reference on the device until after # the context is allocated. A reference on the AFU structure is kept # when the context is allocated, so we can release the reference on # the device after the context allocation. # - with the fix above, there's still another even tinier window, # between the time the AFU device is found in the IDR and the # reference on the device is taken. We can fix this one by removing # the IDR entry earlier, when the device setup is removed, instead # of waiting for the 'release' device callback. With proper locking # around the IDR. # # Fixes: 75ca758adbaf ("ocxl: Create a clear delineation between ocxl backend & frontend") # Cc: stable@vger.kernel.org # v5.2+ # Signed-off-by: Frederic Barrat # Reviewed-by: Greg Kurz # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20190624144148.32022-1-fbarrat@linux.ibm.com # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 a5b9b743fdb653c37d347b303fb60dff0c743f7e # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_ppc44x_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ppc44x_defconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_ppc44x_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/boot/dts/virtex440-ml510.dts:335.37-439.6: Warning (pci_bridge): /plb@0/plbv46-pci@85e00000: node name is not "pci" or "pcie" arch/powerpc/boot/dts/virtex440-ml510.dtb: Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge' /kisskb/src/arch/powerpc/boot/dts/katmai.dts:322.26-361.5: Warning (pci_bridge): /plb/pciex@d00000000: node name is not "pci" or "pcie" /kisskb/src/arch/powerpc/boot/dts/katmai.dts:363.26-402.5: Warning (pci_bridge): /plb/pciex@d20000000: node name is not "pci" or "pcie" /kisskb/src/arch/powerpc/boot/dts/katmai.dts:404.26-443.5: Warning (pci_bridge): /plb/pciex@d40000000: node name is not "pci" or "pcie" arch/powerpc/boot/dts/katmai.dtb: Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge' INFO: Uncompressed kernel (size 0x5962f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5962f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5962f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5962f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5962f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5962f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5962f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5962f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5962f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x585c10) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5962f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5962f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 16:04:59 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2849443 Bytes = 2782.66 KiB = 2.72 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 16:05:00 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2881100 Bytes = 2813.57 KiB = 2.75 MiB Load Address: 00600000 Entry Point: 00601534 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 16:05:01 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2881042 Bytes = 2813.52 KiB = 2.75 MiB Load Address: 00600000 Entry Point: 00601524 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 16:05:01 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2880949 Bytes = 2813.43 KiB = 2.75 MiB Load Address: 00600000 Entry Point: 00601534 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 16:05:01 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2881572 Bytes = 2814.04 KiB = 2.75 MiB Load Address: 00600000 Entry Point: 006000c4 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 16:05:01 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2881630 Bytes = 2814.09 KiB = 2.75 MiB Load Address: 00600000 Entry Point: 00601514 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 16:05:01 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2881595 Bytes = 2814.06 KiB = 2.75 MiB Load Address: 00600000 Entry Point: 00601534 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 16:05:01 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2881088 Bytes = 2813.56 KiB = 2.75 MiB Load Address: 00600000 Entry Point: 00601544 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 16:05:01 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2881598 Bytes = 2814.06 KiB = 2.75 MiB Load Address: 00600000 Entry Point: 0060152c Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 16:05:01 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2881010 Bytes = 2813.49 KiB = 2.75 MiB Load Address: 00600000 Entry Point: 006001b8 Completed OK # rm -rf /kisskb/build/powerpc-fixes_ppc44x_defconfig_powerpc-gcc5 # Build took: 0:01:00.932011