# git rev-parse -q --verify a5b9b743fdb653c37d347b303fb60dff0c743f7e^{commit} a5b9b743fdb653c37d347b303fb60dff0c743f7e already have revision, skipping fetch # git checkout -q -f -B kisskb a5b9b743fdb653c37d347b303fb60dff0c743f7e # git clean -qxdf # < git log -1 # commit a5b9b743fdb653c37d347b303fb60dff0c743f7e # Author: Frederic Barrat # Date: Mon Jun 24 16:41:48 2019 +0200 # # ocxl: Fix concurrent AFU open and device removal # # If an ocxl device is unbound through sysfs at the same time its AFU is # being opened by a user process, the open code may dereference freed # stuctures, which can lead to kernel oops messages. You'd have to hit a # tiny time window, but it's possible. It's fairly easy to test by # making the time window bigger artificially. # # Fix it with a combination of 2 changes: # - when an AFU device is found in the IDR by looking for the device # minor number, we should hold a reference on the device until after # the context is allocated. A reference on the AFU structure is kept # when the context is allocated, so we can release the reference on # the device after the context allocation. # - with the fix above, there's still another even tinier window, # between the time the AFU device is found in the IDR and the # reference on the device is taken. We can fix this one by removing # the IDR entry earlier, when the device setup is removed, instead # of waiting for the 'release' device callback. With proper locking # around the IDR. # # Fixes: 75ca758adbaf ("ocxl: Create a clear delineation between ocxl backend & frontend") # Cc: stable@vger.kernel.org # v5.2+ # Signed-off-by: Frederic Barrat # Reviewed-by: Greg Kurz # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20190624144148.32022-1-fbarrat@linux.ibm.com # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 a5b9b743fdb653c37d347b303fb60dff0c743f7e # < make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # Added to kconfig CONFIG_PPC_E500MC=y # Added to kconfig CONFIG_VIRTUALIZATION=y # Added to kconfig CONFIG_KVM_E500MC=y # Added to kconfig # yes \n | make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- oldconfig yes: standard output: Broken pipe # make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' if (IS_ERR_VALUE(fep->ring_mem_addr)) ^~~~~~~~~~~~ In file included from /kisskb/src/include/linux/acpi.h:15, from /kisskb/src/include/linux/i2c.h:13, from /kisskb/src/include/uapi/linux/fb.h:6, from /kisskb/src/include/linux/fb.h:6, from /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:20: /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c: In function 'fsl_diu_ioctl': /kisskb/src/include/linux/device.h:1776:2: warning: this statement may fall through [-Wimplicit-fallthrough=] _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1287:3: note: in expansion of macro 'dev_warn' dev_warn(info->dev, ^~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1290:2: note: here case MFB_SET_PIXFMT: ^~~~ In file included from /kisskb/src/include/linux/acpi.h:15, from /kisskb/src/include/linux/i2c.h:13, from /kisskb/src/include/uapi/linux/fb.h:6, from /kisskb/src/include/linux/fb.h:6, from /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:20: /kisskb/src/include/linux/device.h:1776:2: warning: this statement may fall through [-Wimplicit-fallthrough=] _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1296:3: note: in expansion of macro 'dev_warn' dev_warn(info->dev, ^~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1299:2: note: here case MFB_GET_PIXFMT: ^~~~ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe57810) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe4700c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:40 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743341 Bytes = 6585.29 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:40 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6750931 Bytes = 6592.71 KiB = 6.44 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:40 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743295 Bytes = 6585.25 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:40 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743371 Bytes = 6585.32 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:40 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743493 Bytes = 6585.44 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:40 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743460 Bytes = 6585.41 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:40 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6750937 Bytes = 6592.71 KiB = 6.44 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:40 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743339 Bytes = 6585.29 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:40 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6707965 Bytes = 6550.75 KiB = 6.40 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:41 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743248 Bytes = 6585.20 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:41 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743346 Bytes = 6585.30 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:41 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743524 Bytes = 6585.47 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:41 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743318 Bytes = 6585.27 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:41 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6750545 Bytes = 6592.33 KiB = 6.44 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:41 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743339 Bytes = 6585.29 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.4.0-ga5b9b743fdb6 Created: Sat Dec 7 17:19:41 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6750951 Bytes = 6592.73 KiB = 6.44 MiB Load Address: 00f00000 Entry Point: 00f002b4 Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc8 # Build took: 0:03:04.457221