# git rev-parse -q --verify ad910e36da4ca3a1bd436989f632d062dda0c921^{commit} ad910e36da4ca3a1bd436989f632d062dda0c921 already have revision, skipping fetch # git checkout -q -f -B kisskb ad910e36da4ca3a1bd436989f632d062dda0c921 # git clean -qxdf # < git log -1 # commit ad910e36da4ca3a1bd436989f632d062dda0c921 # Author: Linus Torvalds # Date: Sat Dec 7 10:41:17 2019 -0800 # # pipe: fix poll/select race introduced by the pipe rework # # The kernel wait queues have a basic rule to them: you add yourself to # the wait-queue first, and then you check the things that you're going to # wait on. That avoids the races with the event you're waiting for. # # The same goes for poll/select logic: the "poll_wait()" goes first, and # then you check the things you're polling for. # # Of course, if you use locking, the ordering doesn't matter since the # lock will serialize with anything that changes the state you're looking # at. That's not the case here, though. # # So move the poll_wait() first in pipe_poll(), before you start looking # at the pipe state. # # Fixes: 8cefc107ca54 ("pipe: Use head and tail pointers for the ring, not cursor and length") # Cc: David Howells # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-ld --version # < git log --format=%s --max-count=1 ad910e36da4ca3a1bd436989f632d062dda0c921 # < make -s -j 80 ARCH=sh O=/kisskb/build/linus_se7780_defconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux- se7780_defconfig # make -s -j 80 ARCH=sh O=/kisskb/build/linus_se7780_defconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux- Generating include/generated/machtypes.h :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] /kisskb/src/arch/sh/kernel/cpu/sh4/../sh3/../../entry-common.S: Assembler messages: /kisskb/src/arch/sh/kernel/cpu/sh4/../sh3/../../entry-common.S:385: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh4/../sh3/../../entry-common.S:388: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here /kisskb/src/drivers/sh/clk/cpg.c: In function 'r8': /kisskb/src/drivers/sh/clk/cpg.c:41:2: warning: passing argument 1 of 'ioread8' discards 'const' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/iomap.h:29:21: note: expected 'void *' but argument is of type 'const void *' /kisskb/src/drivers/sh/clk/cpg.c: In function 'r16': /kisskb/src/drivers/sh/clk/cpg.c:46:2: warning: passing argument 1 of 'ioread16' discards 'const' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/iomap.h:30:21: note: expected 'void *' but argument is of type 'const void *' /kisskb/src/drivers/sh/clk/cpg.c: In function 'r32': /kisskb/src/drivers/sh/clk/cpg.c:51:2: warning: passing argument 1 of 'ioread32' discards 'const' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/iomap.h:32:21: note: expected 'void *' but argument is of type 'const void *' /kisskb/src/drivers/usb/core/devio.c: In function 'async_completed': /kisskb/src/drivers/usb/core/devio.c:625:23: warning: 'errno' may be used uninitialized in this function [-Wuninitialized] Kernel: arch/sh/boot/zImage is ready Completed OK # rm -rf /kisskb/build/linus_se7780_defconfig_sh4 # Build took: 0:00:38.876309