# git rev-parse -q --verify 9933819099c4600b41a042f27a074470a43cf6b9^{commit} 9933819099c4600b41a042f27a074470a43cf6b9 already have revision, skipping fetch # git checkout -q -f -B kisskb 9933819099c4600b41a042f27a074470a43cf6b9 # git clean -qxdf # < git log -1 # commit 9933819099c4600b41a042f27a074470a43cf6b9 # Author: Christophe Leroy # Date: Mon Jan 27 10:42:04 2020 +0000 # # powerpc/32s: Fix CPU wake-up from sleep mode # # Commit f7354ccac844 ("powerpc/32: Remove CURRENT_THREAD_INFO and # rename TI_CPU") broke the CPU wake-up from sleep mode (i.e. when # _TLF_SLEEPING is set) by delaying the tovirt(r2, r2). # # This is because r2 is not restored by fast_exception_return. It used # to work (by chance ?) because CPU wake-up interrupt never comes from # user, so r2 is expected to point to 'current' on return. # # Commit e2fb9f544431 ("powerpc/32: Prepare for Kernel Userspace Access # Protection") broke it even more by clobbering r0 which is not # restored by fast_exception_return either. # # Use r6 instead of r0. This is possible because r3-r6 are restored by # fast_exception_return and only r3-r5 are used for exception arguments. # # For r2 it could be converted back to virtual address, but stay on the # safe side and restore it from the stack instead. It should be live # in the cache at that moment, so loading from the stack should make # no difference compared to converting it from phys to virt. # # Fixes: f7354ccac844 ("powerpc/32: Remove CURRENT_THREAD_INFO and rename TI_CPU") # Fixes: e2fb9f544431 ("powerpc/32: Prepare for Kernel Userspace Access Protection") # Cc: stable@vger.kernel.org # Signed-off-by: Christophe Leroy # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/6d02c3ae6ad77af34392e98117e44c2bf6d13ba1.1580121710.git.christophe.leroy@c-s.fr # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 9933819099c4600b41a042f27a074470a43cf6b9 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # Added to kconfig CONFIG_PPC_E500MC=y # Added to kconfig CONFIG_VIRTUALIZATION=y # Added to kconfig CONFIG_KVM_E500MC=y # Added to kconfig # yes \n | make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- oldconfig yes: standard output: Broken pipe # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' if (IS_ERR_VALUE(fep->ring_mem_addr)) ^~~~~~~~~~~~ In file included from /kisskb/src/include/linux/acpi.h:15, from /kisskb/src/include/linux/i2c.h:13, from /kisskb/src/include/uapi/linux/fb.h:6, from /kisskb/src/include/linux/fb.h:6, from /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:20: /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c: In function 'fsl_diu_ioctl': /kisskb/src/include/linux/device.h:1776:2: warning: this statement may fall through [-Wimplicit-fallthrough=] _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1287:3: note: in expansion of macro 'dev_warn' dev_warn(info->dev, ^~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1290:2: note: here case MFB_SET_PIXFMT: ^~~~ In file included from /kisskb/src/include/linux/acpi.h:15, from /kisskb/src/include/linux/i2c.h:13, from /kisskb/src/include/uapi/linux/fb.h:6, from /kisskb/src/include/linux/fb.h:6, from /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:20: /kisskb/src/include/linux/device.h:1776:2: warning: this statement may fall through [-Wimplicit-fallthrough=] _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1296:3: note: in expansion of macro 'dev_warn' dev_warn(info->dev, ^~~~~~~~ /kisskb/src/drivers/video/fbdev/fsl-diu-fb.c:1299:2: note: here case MFB_GET_PIXFMT: ^~~~ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe617f8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe50ff4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6760883 Bytes = 6602.42 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6763372 Bytes = 6604.86 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6760882 Bytes = 6602.42 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6761083 Bytes = 6602.62 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6763397 Bytes = 6604.88 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6761298 Bytes = 6602.83 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6761511 Bytes = 6603.04 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6762789 Bytes = 6604.29 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6760796 Bytes = 6602.34 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6761045 Bytes = 6602.58 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6761303 Bytes = 6602.83 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6725804 Bytes = 6568.17 KiB = 6.41 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6761124 Bytes = 6602.66 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f00314 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6762239 Bytes = 6603.75 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6760917 Bytes = 6602.46 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f002b4 Image Name: Linux-5.5.0-rc5-g9933819099c4 Created: Thu Jan 30 03:04:23 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6760995 Bytes = 6602.53 KiB = 6.45 MiB Load Address: 00f00000 Entry Point: 00f00314 Completed OK # rm -rf /kisskb/build/powerpc-next_mpc85xx_defconfig+KVM_powerpc-gcc8 # Build took: 0:02:51.950021