# git rev-parse -q --verify 56ca73e491a54bd7be10e398593977df9ee4d4ff^{commit} 56ca73e491a54bd7be10e398593977df9ee4d4ff already have revision, skipping fetch # git checkout -q -f -B kisskb 56ca73e491a54bd7be10e398593977df9ee4d4ff # git clean -qxdf # < git log -1 # commit 56ca73e491a54bd7be10e398593977df9ee4d4ff # Author: Gustavo A. R. Silva # Date: Tue Feb 11 10:00:37 2020 -0600 # # treewide: Replace zero-length arrays with flexible array member # # The current codebase makes use of the zero-length array language # extension to the C90 standard, but the preferred mechanism to declare # variable-length types such as these ones is a flexible array member[1][2], # introduced in C99: # # struct foo { # int stuff; # struct boo array[]; # }; # # By making use of the mechanism above, we will get a compiler warning # in case the flexible array does not occur last in the structure, which # will help us prevent some kind of undefined behavior bugs from being # unadvertenly introduced[3] to the codebase from now on. # # All these instances of code were found with the help of the following # Coccinelle script: # # @@ # identifier S, member, array; # type T1, T2; # @@ # # struct S { # ... # T1 member; # T2 array[ # - 0 # ]; # }; # # [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html # [2] https://github.com/KSPP/linux/issues/21 # [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") # # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-ld --version # < git log --format=%s --max-count=1 56ca73e491a54bd7be10e398593977df9ee4d4ff # < make -s -j 24 ARCH=mips O=/kisskb/build/gustavoars_cavium_octeon_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- cavium_octeon_defconfig # make -s -j 24 ARCH=mips O=/kisskb/build/gustavoars_cavium_octeon_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- Completed OK # rm -rf /kisskb/build/gustavoars_cavium_octeon_defconfig_mips-gcc8 # Build took: 0:02:01.645795