# git rev-parse -q --verify b86f936658ba1882f799d3b4328cd7e1c5839e43^{commit} b86f936658ba1882f799d3b4328cd7e1c5839e43 already have revision, skipping fetch # git checkout -q -f -B kisskb b86f936658ba1882f799d3b4328cd7e1c5839e43 # git clean -qxdf # < git log -1 # commit b86f936658ba1882f799d3b4328cd7e1c5839e43 # Author: Gustavo A. R. Silva # Date: Fri Feb 21 09:15:44 2020 -0600 # # firmware: dmi-sysfs: Replace zero-length array with flexible-array member # # The current codebase makes use of the zero-length array language # extension to the C90 standard, but the preferred mechanism to declare # variable-length types such as these ones is a flexible array member[1][2], # introduced in C99: # # struct foo { # int stuff; # struct boo array[]; # }; # # By making use of the mechanism above, we will get a compiler warning # in case the flexible array does not occur last in the structure, which # will help us prevent some kind of undefined behavior bugs from being # inadvertently introduced[3] to the codebase from now on. # # Also, notice that, dynamic memory allocations won't be affected by # this change: # # "Flexible array members have incomplete type, and so the sizeof operator # may not be applied. As a quirk of the original implementation of # zero-length arrays, sizeof evaluates to zero."[1] # # This issue was found with the help of Coccinelle. # # [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html # [2] https://github.com/KSPP/linux/issues/21 # [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") # # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/gcc-4.6.3-nolibc/alpha-linux/bin/alpha-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/alpha-linux/bin/alpha-linux-ld --version # < git log --format=%s --max-count=1 b86f936658ba1882f799d3b4328cd7e1c5839e43 # < make -s -j 48 ARCH=alpha O=/kisskb/build/gustavoars_alpha-defconfig_alpha CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/alpha-linux/bin/alpha-linux- defconfig # < make -s -j 48 ARCH=alpha O=/kisskb/build/gustavoars_alpha-defconfig_alpha CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/alpha-linux/bin/alpha-linux- help # make -s -j 48 ARCH=alpha O=/kisskb/build/gustavoars_alpha-defconfig_alpha CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/alpha-linux/bin/alpha-linux- olddefconfig # make -s -j 48 ARCH=alpha O=/kisskb/build/gustavoars_alpha-defconfig_alpha CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/alpha-linux/bin/alpha-linux- :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:72:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here /kisskb/src/fs/io_uring.c: In function '__io_sqe_files_update': /kisskb/src/fs/io_uring.c:5824:13: warning: 'err' may be used uninitialized in this function [-Wuninitialized] WARNING: "saved_config" [vmlinux] is COMMON symbol Kernel arch/alpha/boot/vmlinux.gz is ready Completed OK # rm -rf /kisskb/build/gustavoars_alpha-defconfig_alpha # Build took: 0:00:43.691116