Buildresult: gustavoars/cavium_octeon_defconfig/mips-gcc8 built on Feb 25 2020, 03:09

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Feb 25 2020, 03:09
Duration:	0:02:11.032976
Builder:	blade4b
Revision:	firmware: dmi-sysfs: Replace zero-length array with flexible-array member (`b86f936658ba1882f799d3b4328cd7e1c5839e43)`
Target:	gustavoars/cavium_octeon_defconfig/mips-gcc8
Branch:	gustavoars
Compiler:	mips-gcc8 (mips-linux-gcc (GCC) 8.1.0 / GNU ld (GNU Binutils) 2.30)
Config:	cavium_octeon_defconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify b86f936658ba1882f799d3b4328cd7e1c5839e43^{commit} b86f936658ba1882f799d3b4328cd7e1c5839e43 already have revision, skipping fetch # git checkout -q -f -B kisskb b86f936658ba1882f799d3b4328cd7e1c5839e43 # git clean -qxdf # < git log -1 # commit b86f936658ba1882f799d3b4328cd7e1c5839e43 # Author: Gustavo A. R. Silva <gustavo@embeddedor.com> # Date: Fri Feb 21 09:15:44 2020 -0600 # # firmware: dmi-sysfs: Replace zero-length array with flexible-array member # # The current codebase makes use of the zero-length array language # extension to the C90 standard, but the preferred mechanism to declare # variable-length types such as these ones is a flexible array member[1][2], # introduced in C99: # # struct foo { # int stuff; # struct boo array[]; # }; # # By making use of the mechanism above, we will get a compiler warning # in case the flexible array does not occur last in the structure, which # will help us prevent some kind of undefined behavior bugs from being # inadvertently introduced[3] to the codebase from now on. # # Also, notice that, dynamic memory allocations won't be affected by # this change: # # "Flexible array members have incomplete type, and so the sizeof operator # may not be applied. As a quirk of the original implementation of # zero-length arrays, sizeof evaluates to zero."[1] # # This issue was found with the help of Coccinelle. # # [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html # [2] https://github.com/KSPP/linux/issues/21 # [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") # # Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-ld --version # < git log --format=%s --max-count=1 b86f936658ba1882f799d3b4328cd7e1c5839e43 # < make -s -j 24 ARCH=mips O=/kisskb/build/gustavoars_cavium_octeon_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- cavium_octeon_defconfig # < make -s -j 24 ARCH=mips O=/kisskb/build/gustavoars_cavium_octeon_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- help # make -s -j 24 ARCH=mips O=/kisskb/build/gustavoars_cavium_octeon_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- olddefconfig # make -s -j 24 ARCH=mips O=/kisskb/build/gustavoars_cavium_octeon_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- Completed OK # rm -rf /kisskb/build/gustavoars_cavium_octeon_defconfig_mips-gcc8 # Build took: 0:02:11.032976

© Michael Ellerman 2006-2018.