# git rev-parse -q --verify d5180902be1cf9f6b33a7b270bac94db453f2d80^{commit} d5180902be1cf9f6b33a7b270bac94db453f2d80 already have revision, skipping fetch # git checkout -q -f -B kisskb d5180902be1cf9f6b33a7b270bac94db453f2d80 # git clean -qxdf # < git log -1 # commit d5180902be1cf9f6b33a7b270bac94db453f2d80 # Author: Gustavo A. R. Silva # Date: Fri Feb 21 09:32:33 2020 -0600 # # firmware: google: vpd: Replace zero-length array with flexible-array member # # The current codebase makes use of the zero-length array language # extension to the C90 standard, but the preferred mechanism to declare # variable-length types such as these ones is a flexible array member[1][2], # introduced in C99: # # struct foo { # int stuff; # struct boo array[]; # }; # # By making use of the mechanism above, we will get a compiler warning # in case the flexible array does not occur last in the structure, which # will help us prevent some kind of undefined behavior bugs from being # inadvertently introduced[3] to the codebase from now on. # # Also, notice that, dynamic memory allocations won't be affected by # this change: # # "Flexible array members have incomplete type, and so the sizeof operator # may not be applied. As a quirk of the original implementation of # zero-length arrays, sizeof evaluates to zero."[1] # # This issue was found with the help of Coccinelle. # # [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html # [2] https://github.com/KSPP/linux/issues/21 # [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") # # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 d5180902be1cf9f6b33a7b270bac94db453f2d80 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # < make -s -j 48 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 48 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 22 | #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) | ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' 139 | if (IS_ERR_VALUE(fep->ring_mem_addr)) | ^~~~~~~~~~~~ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe26538) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe15d34) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:43 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6706581 Bytes = 6549.40 KiB = 6.40 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:45 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6741031 Bytes = 6583.04 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f0031c Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:45 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743273 Bytes = 6585.23 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:46 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6740650 Bytes = 6582.67 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f0031c Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:46 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6741778 Bytes = 6583.77 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:47 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6740718 Bytes = 6582.73 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:47 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6741809 Bytes = 6583.80 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f0031c Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:47 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743699 Bytes = 6585.64 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:48 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6741905 Bytes = 6583.89 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:48 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6740649 Bytes = 6582.67 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f0031c Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:49 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6741032 Bytes = 6583.04 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:49 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6740938 Bytes = 6582.95 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f0031c Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:49 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6740643 Bytes = 6582.66 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:50 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743901 Bytes = 6585.84 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:48 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6741030 Bytes = 6583.04 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.6.0-rc2-gd5180902be1c Created: Tue Feb 25 03:46:49 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6743989 Bytes = 6585.93 KiB = 6.43 MiB Load Address: 00f00000 Entry Point: 00f002cc Completed OK # rm -rf /kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 # Build took: 0:02:56.810997