# git rev-parse -q --verify d5180902be1cf9f6b33a7b270bac94db453f2d80^{commit}
d5180902be1cf9f6b33a7b270bac94db453f2d80
already have revision, skipping fetch
# git checkout -q -f -B kisskb d5180902be1cf9f6b33a7b270bac94db453f2d80
# git clean -qxdf
# < git log -1
# commit d5180902be1cf9f6b33a7b270bac94db453f2d80
# Author: Gustavo A. R. Silva <gustavo@embeddedor.com>
# Date:   Fri Feb 21 09:32:33 2020 -0600
# 
#     firmware: google: vpd: Replace zero-length array with flexible-array member
#     
#     The current codebase makes use of the zero-length array language
#     extension to the C90 standard, but the preferred mechanism to declare
#     variable-length types such as these ones is a flexible array member[1][2],
#     introduced in C99:
#     
#     struct foo {
#             int stuff;
#             struct boo array[];
#     };
#     
#     By making use of the mechanism above, we will get a compiler warning
#     in case the flexible array does not occur last in the structure, which
#     will help us prevent some kind of undefined behavior bugs from being
#     inadvertently introduced[3] to the codebase from now on.
#     
#     Also, notice that, dynamic memory allocations won't be affected by
#     this change:
#     
#     "Flexible array members have incomplete type, and so the sizeof operator
#     may not be applied. As a quirk of the original implementation of
#     zero-length arrays, sizeof evaluates to zero."[1]
#     
#     This issue was found with the help of Coccinelle.
#     
#     [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
#     [2] https://github.com/KSPP/linux/issues/21
#     [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
#     
#     Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
# < /opt/cross/kisskb/br-microblaze-full-2016.08-613-ge98b4dd/bin/microblazeel-linux-gcc --version
# < /opt/cross/kisskb/br-microblaze-full-2016.08-613-ge98b4dd/bin/microblazeel-linux-ld --version
# < git log --format=%s --max-count=1 d5180902be1cf9f6b33a7b270bac94db453f2d80
# < make -s -j 80 ARCH=microblaze O=/kisskb/build/gustavoars_nommu_defconfig_microblaze CROSS_COMPILE=/opt/cross/kisskb/br-microblaze-full-2016.08-613-ge98b4dd/bin/microblazeel-linux-  nommu_defconfig
# < make -s -j 80 ARCH=microblaze O=/kisskb/build/gustavoars_nommu_defconfig_microblaze CROSS_COMPILE=/opt/cross/kisskb/br-microblaze-full-2016.08-613-ge98b4dd/bin/microblazeel-linux-  help
# make -s -j 80 ARCH=microblaze O=/kisskb/build/gustavoars_nommu_defconfig_microblaze CROSS_COMPILE=/opt/cross/kisskb/br-microblaze-full-2016.08-613-ge98b4dd/bin/microblazeel-linux-  olddefconfig
# make -s -j 80 ARCH=microblaze O=/kisskb/build/gustavoars_nommu_defconfig_microblaze CROSS_COMPILE=/opt/cross/kisskb/br-microblaze-full-2016.08-613-ge98b4dd/bin/microblazeel-linux-  
Kernel: arch/microblaze/boot/linux.bin is ready  (#1)
Completed OK
# rm -rf /kisskb/build/gustavoars_nommu_defconfig_microblaze
# Build took: 0:00:50.624215