Buildresult: linus/bcm2835_defconfig/arm-gcc4.6 built on Feb 26 2020, 05:06

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Feb 26 2020, 05:06
Duration:	0:01:32.245625
Builder:	ka3
Revision:	floppy: check FDC index for errors before assigning it (`2e90ca68b0d2f5548804f22f0dd61145516171e3)`
Target:	linus/bcm2835_defconfig/arm-gcc4.6
Branch:	linus
Compiler:	arm-gcc4.6 (arm-unknown-linux-gnueabi-gcc (GCC) 4.6.3 / GNU ld (GNU Binutils) 2.22)
Config:	bcm2835_defconfig (download)
Log:	Download original Possible warnings (19) kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] ipc/shm.c:1712:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized] arch/arm/include/asm/irqflags.h:171:2: warning: 'flags' may be used uninitialized in this function [-Wuninitialized] include/linux/list.h:72:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] drivers/gpio/gpiolib-of.c:635:8: warning: 'dflags' may be used uninitialized in this function [-Wuninitialized] drivers/gpio/gpiolib-of.c:635:8: warning: 'lflags' may be used uninitialized in this function [-Wuninitialized] net/core/gen_stats.c:156:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] lib/mpi/mpicoder.c:336:12: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] net/core/dev.c:3602:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] include/linux/rhashtable.h:110:10: warning: 'next' may be used uninitialized in this function [-Wuninitialized] net/wireless/nl80211.c:13148:33: warning: 'wdev' may be used uninitialized in this function [-Wuninitialized] net/wireless/nl80211.c:13118:21: warning: 'rdev' may be used uninitialized in this function [-Wuninitialized] drivers/gpu/drm/drm_dp_mst_topology.c:5400:9: warning: missing braces around initializer [-Wmissing-braces] drivers/gpu/drm/drm_dp_mst_topology.c:5400:9: warning: (near initialization for 'desc.ident') [-Wmissing-braces] drivers/gpu/drm/drm_dp_mst_topology.c:729:23: warning: 'hdrlen' may be used uninitialized in this function [-Wuninitialized] mm/ksm.c:1391:15: warning: 'found_rmap_hlist_len' may be used uninitialized in this function [-Wuninitialized] net/mac80211/tx.c:2551:27: warning: 'chanctx_conf' may be used uninitialized in this function [-Wuninitialized] drivers/gpu/drm/drm_atomic.c:426:38: warning: 'crtc_state' may be used uninitialized in this function [-Wuninitialized] net/mac80211/mlme.c:1576:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] Full Log # git rev-parse -q --verify 2e90ca68b0d2f5548804f22f0dd61145516171e3^{commit} 2e90ca68b0d2f5548804f22f0dd61145516171e3 already have revision, skipping fetch # git checkout -q -f -B kisskb 2e90ca68b0d2f5548804f22f0dd61145516171e3 # git clean -qxdf # < git log -1 # commit 2e90ca68b0d2f5548804f22f0dd61145516171e3 # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Fri Feb 21 12:43:35 2020 -0800 # # floppy: check FDC index for errors before assigning it # # Jordy Zomer reported a KASAN out-of-bounds read in the floppy driver in # wait_til_ready(). # # Which on the face of it can't happen, since as Willy Tarreau points out, # the function does no particular memory access. Except through the FDCS # macro, which just indexes a static allocation through teh current fdc, # which is always checked against N_FDC. # # Except the checking happens after we've already assigned the value. # # The floppy driver is a disgrace (a lot of it going back to my original # horrd "design"), and has no real maintainer. Nobody has the hardware, # and nobody really cares. But it still gets used in virtual environment # because it's one of those things that everybody supports. # # The whole thing should be re-written, or at least parts of it should be # seriously cleaned up. The 'current fdc' index, which is used by the # FDCS macro, and which is often shadowed by a local 'fdc' variable, is a # prime example of how not to write code. # # But because nobody has the hardware or the motivation, let's just fix up # the immediate problem with a nasty band-aid: test the fdc index before # actually assigning it to the static 'fdc' variable. # # Reported-by: Jordy Zomer <jordy@simplyhacker.com> # Cc: Willy Tarreau <w@1wt.eu> # Cc: Dan Carpenter <dan.carpenter@oracle.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-ld --version # < git log --format=%s --max-count=1 2e90ca68b0d2f5548804f22f0dd61145516171e3 # < make -s -j 80 ARCH=arm O=/kisskb/build/linus_bcm2835_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- bcm2835_defconfig # < make -s -j 80 ARCH=arm O=/kisskb/build/linus_bcm2835_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- help # make -s -j 80 ARCH=arm O=/kisskb/build/linus_bcm2835_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- olddefconfig # make -s -j 80 ARCH=arm O=/kisskb/build/linus_bcm2835_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/ipc/shm.c: In function 'ksys_shmdt': /kisskb/src/ipc/shm.c:1712:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/arm/kernel/patch.c: In function '__patch_text_real': /kisskb/src/arch/arm/include/asm/irqflags.h:171:2: warning: 'flags' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/arm/kernel/patch.c:63:16: note: 'flags' was declared here /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:72:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here /kisskb/src/drivers/gpio/gpiolib-of.c: In function 'of_gpiochip_add': /kisskb/src/drivers/gpio/gpiolib-of.c:635:8: warning: 'dflags' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpio/gpiolib-of.c:621:19: note: 'dflags' was declared here /kisskb/src/drivers/gpio/gpiolib-of.c:635:8: warning: 'lflags' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpio/gpiolib-of.c:620:16: note: 'lflags' was declared here /kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic': /kisskb/src/net/core/gen_stats.c:156:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/mpi/mpicoder.c: In function 'mpi_read_raw_from_sgl': /kisskb/src/lib/mpi/mpicoder.c:336:12: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list': /kisskb/src/net/core/dev.c:3602:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c: In function 'rht_deferred_worker': /kisskb/src/include/linux/rhashtable.h:110:10: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c:222:28: note: 'next' was declared here /kisskb/src/net/wireless/nl80211.c: In function 'nl80211_vendor_cmd_dump': /kisskb/src/net/wireless/nl80211.c:13148:33: warning: 'wdev' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/wireless/nl80211.c:13118:21: warning: 'rdev' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_mst_dsc_aux_for_port': /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c:5400:9: warning: missing braces around initializer [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c:5400:9: warning: (near initialization for 'desc.ident') [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_sideband_msg_build': /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c:729:23: warning: 'hdrlen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/ksm.c: In function '__stable_node_chain': /kisskb/src/mm/ksm.c:1391:15: warning: 'found_rmap_hlist_len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/ksm.c:1363:6: note: 'found_rmap_hlist_len' was declared here /kisskb/src/net/mac80211/tx.c: In function 'ieee80211_build_hdr': /kisskb/src/net/mac80211/tx.c:2551:27: warning: 'chanctx_conf' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/drm_atomic.c: In function 'drm_atomic_check_only': /kisskb/src/drivers/gpu/drm/drm_atomic.c:426:38: warning: 'crtc_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/drm_atomic.c:405:25: note: 'crtc_state' was declared here /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon': /kisskb/src/net/mac80211/mlme.c:1576:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c:1533:6: note: 'pwr_level_cisco' was declared here Completed OK # rm -rf /kisskb/build/linus_bcm2835_defconfig_arm # Build took: 0:01:32.245625

© Michael Ellerman 2006-2018.