# git rev-parse -q --verify 59bee45b9712c759ea4d3dcc4eff1752f3a66558^{commit} 59bee45b9712c759ea4d3dcc4eff1752f3a66558 already have revision, skipping fetch # git checkout -q -f -B kisskb 59bee45b9712c759ea4d3dcc4eff1752f3a66558 # git clean -qxdf # < git log -1 # commit 59bee45b9712c759ea4d3dcc4eff1752f3a66558 # Author: Michael Ellerman # Date: Tue Mar 3 23:28:47 2020 +1100 # # powerpc/mm: Fix missing KUAP disable in flush_coherent_icache() # # Stefan reported a strange kernel fault which turned out to be due to a # missing KUAP disable in flush_coherent_icache() called from # flush_icache_range(). # # The fault looks like: # # Kernel attempted to access user page (7fffc30d9c00) - exploit attempt? (uid: 1009) # BUG: Unable to handle kernel data access on read at 0x7fffc30d9c00 # Faulting instruction address: 0xc00000000007232c # Oops: Kernel access of bad area, sig: 11 [#1] # LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA PowerNV # CPU: 35 PID: 5886 Comm: sigtramp Not tainted 5.6.0-rc2-gcc-8.2.0-00003-gfc37a1632d40 #79 # NIP: c00000000007232c LR: c00000000003b7fc CTR: 0000000000000000 # REGS: c000001e11093940 TRAP: 0300 Not tainted (5.6.0-rc2-gcc-8.2.0-00003-gfc37a1632d40) # MSR: 900000000280b033 CR: 28000884 XER: 00000000 # CFAR: c0000000000722fc DAR: 00007fffc30d9c00 DSISR: 08000000 IRQMASK: 0 # GPR00: c00000000003b7fc c000001e11093bd0 c0000000023ac200 00007fffc30d9c00 # GPR04: 00007fffc30d9c18 0000000000000000 c000001e11093bd4 0000000000000000 # GPR08: 0000000000000000 0000000000000001 0000000000000000 c000001e1104ed80 # GPR12: 0000000000000000 c000001fff6ab380 c0000000016be2d0 4000000000000000 # GPR16: c000000000000000 bfffffffffffffff 0000000000000000 0000000000000000 # GPR20: 00007fffc30d9c00 00007fffc30d8f58 00007fffc30d9c18 00007fffc30d9c20 # GPR24: 00007fffc30d9c18 0000000000000000 c000001e11093d90 c000001e1104ed80 # GPR28: c000001e11093e90 0000000000000000 c0000000023d9d18 00007fffc30d9c00 # NIP flush_icache_range+0x5c/0x80 # LR handle_rt_signal64+0x95c/0xc2c # Call Trace: # 0xc000001e11093d90 (unreliable) # handle_rt_signal64+0x93c/0xc2c # do_notify_resume+0x310/0x430 # ret_from_except_lite+0x70/0x74 # Instruction dump: # 409e002c 7c0802a6 3c62ff31 3863f6a0 f8010080 48195fed 60000000 48fe4c8d # 60000000 e8010080 7c0803a6 7c0004ac <7c00ffac> 7c0004ac 4c00012c 38210070 # # This path through handle_rt_signal64() to setup_trampoline() and # flush_icache_range() is only triggered by 64-bit processes that have # unmapped their VDSO, which is rare. # # flush_icache_range() takes a range of addresses to flush. In # flush_coherent_icache() we implement an optimisation for CPUs where we # know we don't actually have to flush the whole range, we just need to # do a single icbi. # # However we still execute the icbi on the user address of the start of # the range we're flushing. On CPUs that also implement KUAP (Power9) # that leads to the spurious fault above. # # We should be able to pass any address, including a kernel address, to # the icbi on these CPUs, which would avoid any interaction with KUAP. # But I don't want to make that change in a bug fix, just in case it # surfaces some strange behaviour on some CPU. # # So for now just disable KUAP around the icbi. Note the icbi is treated # as a load, so we allow read access, not write as you'd expect. # # Fixes: 890274c2dc4c ("powerpc/64s: Implement KUAP for Radix MMU") # Cc: stable@vger.kernel.org # v5.2+ # Reported-by: Stefan Berger # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20200303235708.26004-1-mpe@ellerman.id.au # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 59bee45b9712c759ea4d3dcc4eff1752f3a66558 # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_ps3_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ps3_defconfig # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_ps3_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- help # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_ps3_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- olddefconfig # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_ps3_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:72:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here /kisskb/src/ipc/shm.c: In function 'ksys_shmdt': /kisskb/src/ipc/shm.c:1712:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic': /kisskb/src/net/core/gen_stats.c:156:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list': /kisskb/src/net/core/dev.c:3597:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/usb/core/devio.c: In function 'async_completed': /kisskb/src/drivers/usb/core/devio.c:625:23: warning: 'errno' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/mpi/mpicoder.c: In function 'mpi_read_raw_from_sgl': /kisskb/src/lib/mpi/mpicoder.c:352:8: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/splice.c: In function '__do_compat_sys_vmsplice': /kisskb/src/fs/splice.c:1416:8: warning: 'type' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/splice.c: In function '__do_sys_vmsplice': /kisskb/src/fs/splice.c:1390:8: warning: 'type' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bluetooth/hidp/core.c: In function 'hidp_connection_add': /kisskb/src/net/bluetooth/hidp/core.c:1386:18: warning: 'session' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c: In function 'rht_deferred_worker': /kisskb/src/include/linux/rhashtable.h:110:10: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c:222:28: note: 'next' was declared here /kisskb/src/fs/cifs/smb2pdu.c: In function 'SMB2_ioctl_init': /kisskb/src/fs/cifs/smb2pdu.c:2844:19: warning: 'in_data_buf' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/wireless/nl80211.c: In function 'nl80211_vendor_cmd_dump': /kisskb/src/net/wireless/nl80211.c:13148:33: warning: 'wdev' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/wireless/nl80211.c:13118:21: warning: 'rdev' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/tx.c: In function 'ieee80211_build_hdr': /kisskb/src/net/mac80211/tx.c:2551:27: warning: 'chanctx_conf' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon': /kisskb/src/net/mac80211/mlme.c:1576:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c:1533:6: note: 'pwr_level_cisco' was declared here Completed OK # rm -rf /kisskb/build/powerpc-fixes_ps3_defconfig_powerpc-gcc4.6 # Build took: 0:01:30.264284