Buildresult: linus-rand/powerpc-randconfig/powerpc-gcc9 built on Mar 12 2020, 06:06

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	Failed
Date/Time:	Mar 12 2020, 06:06
Duration:	0:04:33.439304
Builder:	ka3
Revision:	driver code: clarify and fix platform device DMA mask allocation (`e3a36eb6dfaeea8175c05d5915dcf0b939be6dab)`
Target:	linus-rand/powerpc-randconfig/powerpc-gcc9
Branch:	linus-rand
Compiler:	powerpc-gcc9 (powerpc64-linux-gcc (GCC) 9.2.0 / GNU ld (GNU Binutils) 2.32)
Config:	randconfig (download)
Log:	Download original Possible errors drivers/vfio/pci/vfio_pci_nvlink2.c:101:10: error: implicit declaration of function 'mm_iommu_put'; did you mean 'mm_iommu_init'? [-Werror=implicit-function-declaration] drivers/vfio/pci/vfio_pci_nvlink2.c:165:14: error: implicit declaration of function 'mm_iommu_newdev' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors make[4]: * [scripts/Makefile.build:267: drivers/vfio/pci/vfio_pci_nvlink2.o] Error 1 make[3]: * [scripts/Makefile.build:505: drivers/vfio/pci] Error 2 make[2]: * [scripts/Makefile.build:505: drivers/vfio] Error 2 make[1]: * [Makefile:1683: drivers] Error 2 make: * [Makefile:180: sub-make] Error 2 Possible warnings (7) .config:6053:warning: override: reassigning to symbol PPC64 .config:6055:warning: override: reassigning to symbol SECTION_MISMATCH_WARN_ONLY .config:6056:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD fs/jffs2/xattr.c:887:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] lib/test_objagg.c:994:1: warning: the frame size of 1056 bytes is larger than 1024 bytes [-Wframe-larger-than=] drivers/net/wireguard/allowedips.c:67:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] drivers/net/wireguard/allowedips.c:54:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] Full Log # git rev-parse -q --verify e3a36eb6dfaeea8175c05d5915dcf0b939be6dab^{commit} e3a36eb6dfaeea8175c05d5915dcf0b939be6dab already have revision, skipping fetch # git checkout -q -f -B kisskb e3a36eb6dfaeea8175c05d5915dcf0b939be6dab # git clean -qxdf # < git log -1 # commit e3a36eb6dfaeea8175c05d5915dcf0b939be6dab # Author: Christoph Hellwig <hch@lst.de> # Date: Wed Mar 11 17:07:10 2020 +0100 # # driver code: clarify and fix platform device DMA mask allocation # # This does three inter-related things to clarify the usage of the # platform device dma_mask field. In the process, fix the bug introduced # by cdfee5623290 ("driver core: initialize a default DMA mask for # platform device") that caused Artem Tashkinov's laptop to not boot with # newer Fedora kernels. # # This does: # # - First off, rename the field to "platform_dma_mask" to make it # greppable. # # We have way too many different random fields called "dma_mask" in # various data structures, where some of them are actual masks, and # some of them are just pointers to the mask. And the structures all # have pointers to each other, or embed each other inside themselves, # and "pdev" sometimes means "platform device" and sometimes it means # "PCI device". # # So to make it clear in the code when you actually use this new field, # give it a unique name (it really should be something even more unique # like "platform_device_dma_mask", since it's per platform device, not # per platform, but that gets old really fast, and this is unique # enough in context). # # To further clarify when the field gets used, initialize it when we # actually start using it with the default value. # # - Then, use this field instead of the random one-off allocation in # platform_device_register_full() that is now unnecessary since we now # already have a perfectly fine allocation for it in the platform # device structure. # # - The above then allows us to fix the actual bug, where the error path # of platform_device_register_full() would unconditionally free the # platform device DMA allocation with 'kfree()'. # # That kfree() was dont regardless of whether the allocation had been # done earlier with the (now removed) kmalloc, or whether # setup_pdev_dma_masks() had already been used and the dma_mask pointer # pointed to the mask that was part of the platform device. # # It seems most people never triggered the error path, or only triggered # it from a call chain that set an explicit pdevinfo->dma_mask value (and # thus caused the unnecessary allocation that was "cleaned up" in the # error path) before calling platform_device_register_full(). # # Robin Murphy points out that in Artem's case the wdat_wdt driver failed # in platform_device_add(), and that was the one that had called # platform_device_register_full() with pdevinfo.dma_mask = 0, and would # have caused that kfree() of pdev.dma_mask corrupting the heap. # # A later unrelated kmalloc() then oopsed due to the heap corruption. # # Fixes: cdfee5623290 ("driver core: initialize a default DMA mask for platform device") # Reported-bisected-and-tested-by: Artem S. Tashkinov <aros@gmx.com> # Reviewed-by: Robin Murphy <robin.murphy@arm.com> # Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> # Signed-off-by: Christoph Hellwig <hch@lst.de> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 e3a36eb6dfaeea8175c05d5915dcf0b939be6dab # < make -s -j 80 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig KCONFIG_SEED=0xB291B34 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # < make -s -j 80 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 80 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:6053:warning: override: reassigning to symbol PPC64 .config:6055:warning: override: reassigning to symbol SECTION_MISMATCH_WARN_ONLY .config:6056:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD # make -s -j 80 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/fs/jffs2/xattr.c: In function 'jffs2_build_xattr_subsystem': /kisskb/src/fs/jffs2/xattr.c:887:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] 887 \| } \| ^ /kisskb/src/lib/test_objagg.c: In function 'test_hints_case.constprop': /kisskb/src/lib/test_objagg.c:994:1: warning: the frame size of 1056 bytes is larger than 1024 bytes [-Wframe-larger-than=] 994 \| } \| ^ /kisskb/src/drivers/vfio/pci/vfio_pci_nvlink2.c: In function 'vfio_pci_nvgpu_release': /kisskb/src/drivers/vfio/pci/vfio_pci_nvlink2.c:101:10: error: implicit declaration of function 'mm_iommu_put'; did you mean 'mm_iommu_init'? [-Werror=implicit-function-declaration] 101 \| ret = mm_iommu_put(data->mm, data->mem); \| ^~~~~~~~~~~~ \| mm_iommu_init /kisskb/src/drivers/vfio/pci/vfio_pci_nvlink2.c: In function 'vfio_pci_nvgpu_mmap': /kisskb/src/drivers/vfio/pci/vfio_pci_nvlink2.c:165:14: error: implicit declaration of function 'mm_iommu_newdev' [-Werror=implicit-function-declaration] 165 \| ret = (int) mm_iommu_newdev(data->mm, data->useraddr, \| ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[4]: * [/kisskb/src/scripts/Makefile.build:267: drivers/vfio/pci/vfio_pci_nvlink2.o] Error 1 make[4]: * Waiting for unfinished jobs.... make[3]: * [/kisskb/src/scripts/Makefile.build:505: drivers/vfio/pci] Error 2 make[2]: * [/kisskb/src/scripts/Makefile.build:505: drivers/vfio] Error 2 make[2]: * Waiting for unfinished jobs.... /kisskb/src/drivers/net/wireguard/allowedips.c: In function 'root_remove_peer_lists': /kisskb/src/drivers/net/wireguard/allowedips.c:67:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] 67 \| } \| ^ /kisskb/src/drivers/net/wireguard/allowedips.c: In function 'root_free_rcu': /kisskb/src/drivers/net/wireguard/allowedips.c:54:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] 54 \| } \| ^ make[1]: * [/kisskb/src/Makefile:1683: drivers] Error 2 make: * [Makefile:180: sub-make] Error 2 Command 'make -s -j 80 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc9 # Build took: 0:04:33.439304

© Michael Ellerman 2006-2018.