# git rev-parse -q --verify 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d^{commit} 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d already have revision, skipping fetch # git checkout -q -f -B kisskb 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d # git clean -qxdf # < git log -1 # commit 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d # Author: Masahiro Yamada # Date: Mon Mar 2 15:23:40 2020 +0900 # # kconfig: make 'imply' obey the direct dependency # # The 'imply' statement may create unmet direct dependency when the # implied symbol depends on m. # # [Test Code] # # config FOO # tristate "foo" # imply BAZ # # config BAZ # tristate "baz" # depends on BAR # # config BAR # def_tristate m # # config MODULES # def_bool y # option modules # # If you set FOO=y, BAZ is also promoted to y, which results in the # following .config file: # # CONFIG_FOO=y # CONFIG_BAZ=y # CONFIG_BAR=m # CONFIG_MODULES=y # # This does not meet the dependency 'BAZ depends on BAR'. # # Unlike 'select', what is worse, Kconfig never shows the # 'WARNING: unmet direct dependencies detected for ...' for this case. # # Because 'imply' is considered to be weaker than 'depends on', Kconfig # should take the direct dependency into account. # # For clarification, describe this case in kconfig-language.rst too. # # Signed-off-by: Masahiro Yamada # Acked-by: Nicolas Pitre # Tested-by: Geert Uytterhoeven # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d # < make -s -j 10 ARCH=powerpc O=/kisskb/build/kbuild_cell_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- cell_defconfig # < make -s -j 10 ARCH=powerpc O=/kisskb/build/kbuild_cell_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- help # make -s -j 10 ARCH=powerpc O=/kisskb/build/kbuild_cell_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- olddefconfig # make -s -j 10 ARCH=powerpc O=/kisskb/build/kbuild_cell_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:72:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here /kisskb/src/fs/ext4/extents.c: In function 'ext4_convert_unwritten_io_end_vec': /kisskb/src/fs/ext4/extents.c:5009:23: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:247:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:227:19: note: 'i' was declared here /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1426:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/trace/trace_events.c: In function 'event_create_dir': /kisskb/src/kernel/trace/trace_events.c:2040:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1836:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1749:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/usb/core/devio.c: In function 'async_completed': /kisskb/src/drivers/usb/core/devio.c:625:23: warning: 'errno' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/io_uring.c: In function '__io_sqe_files_update': /kisskb/src/fs/io_uring.c:5824:13: warning: 'err' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/kbuild_cell_defconfig_powerpc-gcc4.6 # Build took: 0:02:23.100190