# git rev-parse -q --verify 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d^{commit} 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d already have revision, skipping fetch # git checkout -q -f -B kisskb 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d # git clean -qxdf # < git log -1 # commit 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d # Author: Masahiro Yamada # Date: Mon Mar 2 15:23:40 2020 +0900 # # kconfig: make 'imply' obey the direct dependency # # The 'imply' statement may create unmet direct dependency when the # implied symbol depends on m. # # [Test Code] # # config FOO # tristate "foo" # imply BAZ # # config BAZ # tristate "baz" # depends on BAR # # config BAR # def_tristate m # # config MODULES # def_bool y # option modules # # If you set FOO=y, BAZ is also promoted to y, which results in the # following .config file: # # CONFIG_FOO=y # CONFIG_BAZ=y # CONFIG_BAR=m # CONFIG_MODULES=y # # This does not meet the dependency 'BAZ depends on BAR'. # # Unlike 'select', what is worse, Kconfig never shows the # 'WARNING: unmet direct dependencies detected for ...' for this case. # # Because 'imply' is considered to be weaker than 'depends on', Kconfig # should take the direct dependency into account. # # For clarification, describe this case in kconfig-language.rst too. # # Signed-off-by: Masahiro Yamada # Acked-by: Nicolas Pitre # Tested-by: Geert Uytterhoeven # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d # < make -s -j 24 ARCH=powerpc O=/kisskb/build/kbuild_pmac32_defconfig+SMP_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- pmac32_defconfig # Added to kconfig CONFIG_SMP=y # < make -s -j 24 ARCH=powerpc O=/kisskb/build/kbuild_pmac32_defconfig+SMP_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 24 ARCH=powerpc O=/kisskb/build/kbuild_pmac32_defconfig+SMP_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4062:warning: override: reassigning to symbol SMP # make -s -j 24 ARCH=powerpc O=/kisskb/build/kbuild_pmac32_defconfig+SMP_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/sound/ppc/pmac.h:12:0, from /kisskb/src/sound/ppc/awacs.c:16: /kisskb/src/sound/ppc/awacs.c: In function 'snd_pmac_awacs_init': /kisskb/src/include/sound/control.h:218:9: warning: 'speaker_vol' may be used uninitialized in this function [-Wmaybe-uninitialized] return _snd_ctl_add_slave(master, slave, 0); ^ /kisskb/src/sound/ppc/awacs.c:873:36: note: 'speaker_vol' was declared here struct snd_kcontrol *master_vol, *speaker_vol; ^ INFO: Uncompressed kernel (size 0x94d1d8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xa00000) Completed OK # rm -rf /kisskb/build/kbuild_pmac32_defconfig+SMP_powerpc-gcc5 # Build took: 0:02:03.418213