# git rev-parse -q --verify 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d^{commit} 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d already have revision, skipping fetch # git checkout -q -f -B kisskb 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d # git clean -qxdf # < git log -1 # commit 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d # Author: Masahiro Yamada # Date: Mon Mar 2 15:23:40 2020 +0900 # # kconfig: make 'imply' obey the direct dependency # # The 'imply' statement may create unmet direct dependency when the # implied symbol depends on m. # # [Test Code] # # config FOO # tristate "foo" # imply BAZ # # config BAZ # tristate "baz" # depends on BAR # # config BAR # def_tristate m # # config MODULES # def_bool y # option modules # # If you set FOO=y, BAZ is also promoted to y, which results in the # following .config file: # # CONFIG_FOO=y # CONFIG_BAZ=y # CONFIG_BAR=m # CONFIG_MODULES=y # # This does not meet the dependency 'BAZ depends on BAR'. # # Unlike 'select', what is worse, Kconfig never shows the # 'WARNING: unmet direct dependencies detected for ...' for this case. # # Because 'imply' is considered to be weaker than 'depends on', Kconfig # should take the direct dependency into account. # # For clarification, describe this case in kconfig-language.rst too. # # Signed-off-by: Masahiro Yamada # Acked-by: Nicolas Pitre # Tested-by: Geert Uytterhoeven # < /opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 3a9dd3ecb207b2cb8a4aabd12d20e43fa360b66d # < make -s -j 32 ARCH=x86_64 O=/kisskb/build/kbuild_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- allnoconfig # < make -s -j 32 ARCH=x86_64 O=/kisskb/build/kbuild_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 32 ARCH=x86_64 O=/kisskb/build/kbuild_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 32 ARCH=x86_64 O=/kisskb/build/kbuild_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/apic/io_apic.c: In function 'mp_map_pin_to_irq': /kisskb/src/arch/x86/kernel/apic/io_apic.c:1037:6: warning: 'irq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/e820.c: In function 'e820__setup_pci_gap': /kisskb/src/arch/x86/kernel/e820.c:665:16: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/kbuild_x86_64-allnoconfig_x86_64-gcc4.6 # Build took: 0:00:20.566558